Skip to content

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Sep 29, 2025

Short description

This PR introduces a change for reliably retrieving the full content height of a webpage inside a webview.

List of changes proposed in this pull request

  • Updated GET_CONTENT_HEIGHT_SCRIPT content replacing document.body.scrollHeight with document.documentElement.offsetHeight

How to test

Using devices with different OS and screen sizes, verify that the IPZS privacy content is correctly shown in the WebView within the eID issuance flow

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Sep 29, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.60%. Comparing base (5805e08) to head (9845f3a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7417   +/-   ##
=======================================
  Coverage   59.60%   59.60%           
=======================================
  Files        1830     1830           
  Lines       39525    39525           
  Branches     9119     9117    -2     
=======================================
  Hits        23559    23559           
- Misses      15885    15897   +12     
+ Partials       81       69   -12     
Files with missing lines Coverage Δ
ts/utils/webview.ts 90.00% <ø> (ø)

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0852ae6...9845f3a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mastro993 mastro993 marked this pull request as ready for review September 29, 2025 17:40
Copy link
Collaborator

@gispada gispada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I tested on two Android devices. I'd wait for further testing on iOS.

@ale-mazz
Copy link
Contributor

ale-mazz commented Oct 2, 2025

The first time I entered the screen, the text was cut off before paragraph 9. Then I tried again, and it didn't happen anymore.

Tested on iPhone 13 Mini.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants