-
Notifications
You must be signed in to change notification settings - Fork 109
fix(IT Wallet): [SIW-3094] Fix IPZS privacy webview's viewport height #7417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7417 +/- ##
=======================================
Coverage 59.60% 59.60%
=======================================
Files 1830 1830
Lines 39525 39525
Branches 9119 9117 -2
=======================================
Hits 23559 23559
- Misses 15885 15897 +12
+ Partials 81 69 -12
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I tested on two Android devices. I'd wait for further testing on iOS.
The first time I entered the screen, the text was cut off before paragraph 9. Then I tried again, and it didn't happen anymore. Tested on iPhone 13 Mini. |
Short description
This PR introduces a change for reliably retrieving the full content height of a webpage inside a webview.
List of changes proposed in this pull request
GET_CONTENT_HEIGHT_SCRIPT
content replacingdocument.body.scrollHeight
withdocument.documentElement.offsetHeight
How to test
Using devices with different OS and screen sizes, verify that the IPZS privacy content is correctly shown in the
WebView
within the eID issuance flow