Skip to content

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Oct 6, 2025

Caution

Before merging this PR, be sure to migrate the current preferences to avoid disruptions in production

Short description

This PR removes the choice of typeface from the Appearance preferences screen, making the components easier to maintain.

List of changes proposed in this pull request

  • Remove choice from the Appearance screen
  • Remove relative locale

Preview

Simulator Screenshot - iPhone 16 Pro - 2025-10-06 at 15 21 40

@dmnplb dmnplb added dont-merge ✋ hold Design System New visual language and reduction of previous UI clutter labels Oct 6, 2025
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Oct 6, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.41%. Comparing base (5805e08) to head (4943ec9).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5805e08) and HEAD (4943ec9). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (5805e08) HEAD (4943ec9)
10 7
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7444      +/-   ##
==========================================
- Coverage   59.60%   52.41%   -7.19%     
==========================================
  Files        1830     1818      -12     
  Lines       39525    39335     -190     
  Branches     9119     9053      -66     
==========================================
- Hits        23559    20619    -2940     
- Misses      15885    18638    +2753     
+ Partials       81       78       -3     
Files with missing lines Coverage Δ
...preferences/screens/AppearancePreferenceScreen.tsx 4.00% <ø> (+1.14%) ⬆️

... and 253 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0852ae6...4943ec9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Design System New visual language and reduction of previous UI clutter dont-merge ✋ hold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant