Skip to content

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Oct 7, 2025

Short description

This PR adds dark mode variants to the AnimatedPictogram component.

List of changes proposed in this pull request

  • Add the new dark mode Lottie assets
  • Update AnimatedPictogram to handle both light and dark mode variants

Preview

darkmode-animated-pictograms.mp4

How to test

  • Go to the Design System section → Animated Pictograms (Experimental Lab)
  • Switch to dark or light mode

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter Dark mode 🌝 Experimental lab ✨ Interface experiments that may never see the light of the day labels Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Oct 7, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.30%. Comparing base (655f389) to head (696a963).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ts/components/ui/AnimatedPictogram.tsx 83.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7446   +/-   ##
=======================================
  Coverage   59.30%   59.30%           
=======================================
  Files        1820     1820           
  Lines       39157    39166    +9     
  Branches     8970     8917   -53     
=======================================
+ Hits        23222    23229    +7     
- Misses      15852    15867   +15     
+ Partials       83       70   -13     
Files with missing lines Coverage Δ
ts/components/ui/AnimatedPictogram.tsx 91.17% <83.33%> (-4.83%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655f389...696a963. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dark mode 🌝 Design System New visual language and reduction of previous UI clutter Experimental lab ✨ Interface experiments that may never see the light of the day

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant