-
Notifications
You must be signed in to change notification settings - Fork 109
chore: [IOPID-3472,IOPID-3478,IOPID-3209] Bump IngressScreen
timeout from 10
to 25
#7448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…n handle up to 3 API (session, profile and ping) delay
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7448 +/- ##
=======================================
Coverage 59.30% 59.30%
=======================================
Files 1820 1820
Lines 39157 39163 +6
Branches 8970 8976 +6
=======================================
+ Hits 23222 23227 +5
- Misses 15852 15854 +2
+ Partials 83 82 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
IngressScreen
timeout from 10
to 25
IngressScreen
timeout from 10
to 25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This pull request updates the timeout logic for displaying blocking screens in the ingress flow, ensuring up to 3 different API from backend to be delayed and updates related tests and sagas for consistency.
Bonus fix: It also refines the blocking screen trigger logic.
List of changes proposed in this pull request
Timeout and Blocking Screen Logic Updates
IngressScreen.tsx
, ensuring up to 3 different API from backend to be delayedsetIsBlockingScreen()
and showing the blocking screen to ensure proper state management.IngressScreenNoInternetConnection
to dispatchsetIsBlockingScreen()
on first render, ensuring the blocking screen state is set immediately for no internet scenarios too.Saga Consistency
initializeApplicationSaga
to re-check the blocking screen state after transient error handling, ensuring the app halts initialization if the blocking screen is active. [1] [2]How to test
Using Proxyman, test different delay combinations for the
/ping
,/session
, and/profile
API calls. Verify that when a blocking screen error occurs, the user can only close and reopen the app. Ensure that the blocking screen appears only after 25 seconds.Demo
wrong.mov
right.mov