Skip to content

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Oct 8, 2025

Short description

This pull request updates the timeout logic for displaying blocking screens in the ingress flow, ensuring up to 3 different API from backend to be delayed and updates related tests and sagas for consistency.

Bonus fix: It also refines the blocking screen trigger logic.

List of changes proposed in this pull request

Timeout and Blocking Screen Logic Updates

  • Increased the timeout for displaying the blocking screen from 10 seconds to 25 seconds in IngressScreen.tsx, ensuring up to 3 different API from backend to be delayed
  • Updated the order of dispatching setIsBlockingScreen() and showing the blocking screen to ensure proper state management.
  • Added a hook in IngressScreenNoInternetConnection to dispatch setIsBlockingScreen() on first render, ensuring the blocking screen state is set immediately for no internet scenarios too.

Saga Consistency

  • Modified initializeApplicationSaga to re-check the blocking screen state after transient error handling, ensuring the app halts initialization if the blocking screen is active. [1] [2]

How to test

Using Proxyman, test different delay combinations for the /ping, /session, and /profile API calls. Verify that when a blocking screen error occurs, the user can only close and reopen the app. Ensure that the blocking screen appears only after 25 seconds.

Demo

wrong.mov
right.mov

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@shadowsheep1 shadowsheep1 added the IO-A&I IO - Autenticazione e Identità label Oct 8, 2025
Copy link
Contributor

github-actions bot commented Oct 8, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.30%. Comparing base (655f389) to head (b57b339).
⚠️ Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
ts/sagas/startup.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7448   +/-   ##
=======================================
  Coverage   59.30%   59.30%           
=======================================
  Files        1820     1820           
  Lines       39157    39163    +6     
  Branches     8970     8976    +6     
=======================================
+ Hits        23222    23227    +5     
- Misses      15852    15854    +2     
+ Partials       83       82    -1     
Files with missing lines Coverage Δ
ts/features/ingress/screens/IngressScreen.tsx 90.90% <100.00%> (+0.36%) ⬆️
ts/sagas/startup.ts 38.56% <0.00%> (-0.78%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 655f389...b57b339. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shadowsheep1 shadowsheep1 changed the title chore: [IOPID-3472,IOPID-3478] Bump IngressScreen timeout from 10 to 25 chore: [IOPID-3472,IOPID-3478,IOPID-3209] Bump IngressScreen timeout from 10 to 25 Oct 8, 2025
Copy link
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO-A&I IO - Autenticazione e Identità legal-review-needed ⚖️ ⛔ this PR is under legal check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants