Skip to content

Conversation

shadowsheep1
Copy link
Member

@shadowsheep1 shadowsheep1 commented Oct 8, 2025

Short description

This pull request introduces a new set of developer playground screens for CIE IAS+MRTD internal authentication, refactors the existing CIE playground screen, and updates navigation and type definitions to support the new features. It also updates the @pagopa/io-react-native-cie library to version 1.2.0 to enable these capabilities.

List of changes proposed in this pull request

New CIE IAS+MRTD Internal Authentication Playground:

  • Added three new developer playground screens for CIE IAS+MRTD internal authentication: the main playground (CieIasAndMrtdPlayground), the internal authentication flow (CieIasAndMrtdPlaygroundIntAuth), and the authentication result screen (CieIasAndMrtdPlaygroundIntAuthResult). These screens allow developers to test device NFC capabilities, start an internal authentication challenge, and view/copy/share the results. [1] [2] [3]

Navigation and Type Updates:

  • Updated the navigation stack and parameters in SettingsNavigator.tsx, SettingsParamsList.ts, and routes.ts to support the new CIE IAS+MRTD playground screens, including defining route names and parameter types. [1] [2] [3] [4] [5]
  • Added a new entry for the CIE IAS+MRTD playground in the developer mode section for easier access from the settings screen.

CIE Playground Refactor:

  • Moved and refactored the existing CiePlayground screen into a dedicated folder, updating imports and removing duplicated UI components for better code organization and maintainability. Shared status/progress UI is now imported from a common component. [1] [2] [3] [4]

Dependency Update:

  • Updated @pagopa/io-react-native-cie to version 1.2.0 in package.json to support new internal authentication features.

How to test

Go to Settings -> CIE IAS+MRTD -> Start Internal CIE Authentication -> Sign Challenge and try it out with your CIE.

Demo

🎦
ios-internal-auth.MP4

Copy link
Contributor

github-actions bot commented Oct 8, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 7.07071% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.37%. Comparing base (3770dbc) to head (f06d751).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...playgrounds/Cie/CieIasAndMrtdPlaygroundIntAuth.tsx 2.38% 41 Missing ⚠️
...evMode/playgrounds/Cie/CieIasAndMrtdPlayground.tsx 4.16% 23 Missing ⚠️
...ounds/Cie/CieIasAndMrtdPlaygroundIntAuthResult.tsx 6.66% 14 Missing ⚠️
...settings/devMode/playgrounds/Cie/utils/encoding.ts 0.00% 9 Missing ⚠️
...playgrounds/Cie/components/ReadStatusComponent.tsx 50.00% 4 Missing ⚠️
...ttings/devMode/components/DeveloperModeSection.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7450      +/-   ##
==========================================
- Coverage   59.27%   55.37%   -3.91%     
==========================================
  Files        1817     1820       +3     
  Lines       39130    39170      +40     
  Branches     8978     8910      -68     
==========================================
- Hits        23196    21689    -1507     
- Misses      15852    17416    +1564     
+ Partials       82       65      -17     
Files with missing lines Coverage Δ
...s/settings/common/navigation/SettingsNavigator.tsx 100.00% <ø> (ø)
ts/features/settings/common/navigation/routes.ts 100.00% <ø> (ø)
...settings/devMode/playgrounds/Cie/CiePlayground.tsx 7.89% <ø> (ø)
...ttings/devMode/components/DeveloperModeSection.tsx 24.82% <0.00%> (-23.75%) ⬇️
...playgrounds/Cie/components/ReadStatusComponent.tsx 50.00% <50.00%> (ø)
...settings/devMode/playgrounds/Cie/utils/encoding.ts 0.00% <0.00%> (ø)
...ounds/Cie/CieIasAndMrtdPlaygroundIntAuthResult.tsx 6.66% <6.66%> (ø)
...evMode/playgrounds/Cie/CieIasAndMrtdPlayground.tsx 4.16% <4.16%> (ø)
...playgrounds/Cie/CieIasAndMrtdPlaygroundIntAuth.tsx 2.38% <2.38%> (ø)

... and 205 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3770dbc...f06d751. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shadowsheep1 shadowsheep1 marked this pull request as ready for review October 9, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IO-A&I IO - Autenticazione e Identità

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant