Skip to content

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR hides the Alert on the SEND timeline when opening an AAR notification

Standard
notification
AAR
notification

List of changes proposed in this pull request

  • Hidden Alert
  • Updated tests and snapshots

How to test

Using the io-dev-api-server, check that:

  • standard SEND notifications have the alert in the timeline
  • AAR SEND notifications do not have the alert in the timeline

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Oct 9, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.16%. Comparing base (da2d03f) to head (5a486d9).

Files with missing lines Patch % Lines
ts/features/pn/components/TimelineListItem.tsx 33.33% 8 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (da2d03f) and HEAD (5a486d9). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (da2d03f) HEAD (5a486d9)
10 6
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7463       +/-   ##
===========================================
- Coverage   59.55%   43.16%   -16.39%     
===========================================
  Files        1828     1648      -180     
  Lines       39478    36354     -3124     
  Branches     9042     8377      -665     
===========================================
- Hits        23510    15692     -7818     
- Misses      15899    20604     +4705     
+ Partials       69       58       -11     
Files with missing lines Coverage Δ
ts/features/pn/components/MessageBottomMenu.tsx 96.00% <ø> (ø)
ts/features/pn/components/MessageDetails.tsx 80.00% <ø> (-5.00%) ⬇️
ts/features/pn/components/TimelineListItem.tsx 20.58% <33.33%> (-46.08%) ⬇️

... and 680 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2d03f...5a486d9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far LGTM -- will re-review when mergeable

@Vangaorth
Copy link
Contributor Author

Has to be merged after the release of phase 2

Copy link
Collaborator

@Alessandro-Laregina Alessandro-Laregina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants