-
Notifications
You must be signed in to change notification settings - Fork 109
feat: [IOCOM-2670] Add Push Notification engagement flow after SEND activation success (if needed) #7477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ChrisMattew
wants to merge
67
commits into
master
Choose a base branch
from
IOCOM-2670-new-push-notification-engagement-screen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: [IOCOM-2670] Add Push Notification engagement flow after SEND activation success (if needed) #7477
ChrisMattew
wants to merge
67
commits into
master
from
IOCOM-2670-new-push-notification-engagement-screen
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p type in the action props
…ing logic to the Send Engagement screen
…nResultScreenContent
…-engagement-screen
…OperationResultScreenContent" This reverts commit bd9821f.
…idth prop type in the action props" This reverts commit f963ccc.
…ction props and update snapshots
…ScreenContent with WhatsNewScreenContent
🎉 All dependencies have been resolved ! |
…-notification-engagement-screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Depends on #7412
Short description
This PR adds navigation to the push notification activation screen (when notifications are not yet enabled) after a successful activation of the SEND service during the app startup SEND engagement flow (see more details in #7412)
List of changes proposed in this pull request
ts/features/pn/aar/screen/SendAARPushEngagementScreen.tsx
tots/features/pushNotifications/screens/PushNotificationEngagementScreen.tsx
to make it reusable across multiple flows. The screen now expects aflow
route param to populate Mixpanel events correctly.useAARpushEngagementScreenLogic
hook tots/features/pushNotifications/hooks/usePushNotificationEngagement.tsx
, now taking aflow
parameter for Mixpanel events.PushNotificationEngagementScreen
inAuthenticatedStackNavigator
underNOTIFICATIONS_ROUTES.PUSH_NOTIFICATION_ENGAGEMENT
.Demo
SEND activation error
send-activation-error.mp4
send-activation.error.mp4
Push already enabled
push-not-shown-if-already-enabled.mp4
push-not-shown-if-already-enabled.mp4
Only SEND activation
send-enabling-without-push-enabling.mp4
send-enabling-without-push-enabling.mp4
SEND & Push activation
send-and-push-activation.mp4
send-and-push-activation.mp4
Push Notification engagement dismiss
dismiss-push-notificationengagement-screen.mp4
dismiss-push-notificationengagement-screen.mp4
How to test
Follow the "How to test" section described in this PR, then repeat the steps shown in the Demo videos.