refactor: [IOCOM-2676] Store full recipientInfo object in SEND AAR reducer #7484

Alessandro-Laregina · 2025-10-15T16:00:14Z

Short description

This PR updates the AAR reducer state to store the full recipientInfo object returned by the backend instead of just the fullNameDestinatario string.

List of changes proposed in this pull request

Updated the AAR reducer to store the complete recipientInfo object.
Updated types/interfaces to reflect the new structure of the state.

How to test

Automated tests should succeed

github-actions · 2025-10-15T16:00:26Z

PR Title Validation for conventional commit type

✅ All good! PR title follows the conventional commit type.

github-actions · 2025-10-15T16:00:26Z

Jira Pull Request Link

This Pull Request refers to Jira issues:

IOCOM-2676

codecov · 2025-10-15T16:13:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.60%. Comparing base (5805e08) to head (9534290).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7484   +/-   ##
=======================================
  Coverage   59.60%   59.60%           
=======================================
  Files        1830     1830           
  Lines       39525    39525           
  Branches     9119     9060   -59     
=======================================
  Hits        23559    23559           
- Misses      15885    15896   +11     
+ Partials       81       70   -11

Files with missing lines	Coverage Δ
.../features/pn/aar/saga/fetchNotificationDataSaga.ts	`97.14% <ø> (ø)`
ts/features/pn/aar/saga/fetchQrCodeSaga.ts	`95.83% <ø> (ø)`
ts/features/pn/aar/store/selectors/index.ts	`94.59% <100.00%> (ø)`
ts/features/pn/aar/utils/stateUtils.ts	`100.00% <ø> (ø)`
ts/features/pn/aar/utils/testUtils.ts	`100.00% <ø> (ø)`

... and 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0852ae6...9534290. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…-deve-avere-solo-full-name-destinatario-ma-lintero-oggetto-denomination-restituito-dal-backend

Vangaorth · 2025-10-16T15:28:47Z

ts/features/pn/aar/hooks/__tests__/useSendAarFlowManager.test.tsx

      type: sendAARFlowStates.displayingNotificationData,
-      fullNameDestinatario: "mario rossi",
+      recipientInfo: {
+        denomination: "nomecognome",


denomination: "Mario Rossi"

Vangaorth · 2025-10-16T15:29:11Z

ts/features/pn/aar/hooks/__tests__/useSendAarFlowManager.test.tsx

-      fullNameDestinatario: "mario rossi",
+      recipientInfo: {
+        denomination: "nomecognome",
+        taxId: "taxID"


taxId: "RSSMRA74D22A001Q"

Vangaorth · 2025-10-16T15:29:44Z

ts/features/pn/aar/saga/__tests__/fetchNotificationDataSaga.test.ts

  mandateId: "MANDATE123",
-  fullNameDestinatario: "Mario Rossi"
+  recipientInfo: {
+    denomination: "nomecognome",


denomination: "Mario Rossi"
taxId: "RSSMRA74D22A001Q"

Vangaorth · 2025-10-16T15:29:54Z

ts/features/pn/aar/saga/__tests__/fetchQrCodeSaga.test.ts

          iun: "123123",
-          fullNameDestinatario: "nomecognome",
+          recipientInfo: {
+            denomination: "nomecognome",


denomination: "Mario Rossi"
taxId: "RSSMRA74D22A001Q"

Vangaorth · 2025-10-16T15:29:59Z

ts/features/pn/aar/saga/__tests__/fetchQrCodeSaga.test.ts

        iun: "123123",
-        fullNameDestinatario: "nomecognome",
+        recipientInfo: {
+          denomination: "nomecognome",


denomination: "Mario Rossi"
taxId: "RSSMRA74D22A001Q"

Vangaorth · 2025-10-16T15:31:28Z

ts/features/pn/aar/saga/fetchQrCodeSaga.ts

                type: sendAARFlowStates.fetchingNotificationData,
                iun,
-                fullNameDestinatario: recipientInfo.denomination,
+                recipientInfo,


Maybe it's better to create a new instance via spread (see above)

Vangaorth · 2025-10-16T15:31:32Z

ts/features/pn/aar/saga/fetchQrCodeSaga.ts

                type: sendAARFlowStates.notAddresseeFinal,
                iun: data.value.iun,
-                fullNameDestinatario: data.value.recipientInfo.denomination,
+                recipientInfo: data.value.recipientInfo,


Maybe it's better to create a new instance via spread (see above)

Vangaorth · 2025-10-16T15:33:51Z

ts/features/pn/aar/utils/testUtils.ts

    iun: "000000000001",
-    fullNameDestinatario: "Mario Rossi"
+    recipientInfo: {
+      denomination: "nomecognome",


denomination: "Mario Rossi"
taxId: "RSSMRA74D22A001Q"

Vangaorth · 2025-10-16T15:33:55Z

ts/features/pn/aar/utils/testUtils.ts

    type: "displayingNotificationData",
-    fullNameDestinatario: "Mario Rossi",
+    recipientInfo: {
+      denomination: "nomecognome",


denomination: "Mario Rossi"
taxId: "RSSMRA74D22A001Q"

Vangaorth · 2025-10-16T15:33:59Z

ts/features/pn/aar/utils/testUtils.ts

    type: "notAddresseeFinal",
-    fullNameDestinatario: "Mario Rossi",
+    recipientInfo: {
+      denomination: "nomecognome",


denomination: "Mario Rossi"
taxId: "RSSMRA74D22A001Q"

Refactor fullname string in recipientInfo object

8f3d825

Alessandro-Laregina added the IO-Comunicazione label Oct 15, 2025

Alessandro-Laregina requested review from a team, ChrisMattew, freddi301 and gispada as code owners October 15, 2025 16:00

Alessandro-Laregina had a problem deploying to dev October 15, 2025 16:07 — with GitHub Actions Error

Alessandro-Laregina had a problem deploying to dev October 15, 2025 16:07 — with GitHub Actions Failure

Alessandro-Laregina temporarily deployed to dev October 15, 2025 16:07 — with GitHub Actions Inactive

Alessandro-Laregina had a problem deploying to dev October 15, 2025 16:07 — with GitHub Actions Error

Alessandro-Laregina temporarily deployed to dev October 15, 2025 16:07 — with GitHub Actions Inactive

Alessandro-Laregina had a problem deploying to dev October 15, 2025 16:07 — with GitHub Actions Error

Alessandro-Laregina and others added 2 commits October 16, 2025 09:13

fix test

eaffb5b

Merge branch 'master' into IOCOM-2676-fe-lo-stato-del-reducer-aar-non…

9534290

…-deve-avere-solo-full-name-destinatario-ma-lintero-oggetto-denomination-restituito-dal-backend

Alessandro-Laregina temporarily deployed to dev October 16, 2025 07:21 — with GitHub Actions Inactive

Vangaorth requested changes Oct 16, 2025

View reviewed changes

refactor: [IOCOM-2676] Store full recipientInfo object in SEND AAR reducer #7484

Are you sure you want to change the base?

refactor: [IOCOM-2676] Store full recipientInfo object in SEND AAR reducer #7484

Conversation

Alessandro-Laregina commented Oct 15, 2025

Short description

List of changes proposed in this pull request

How to test

Uh oh!

github-actions bot commented Oct 15, 2025

PR Title Validation for conventional commit type

Uh oh!

github-actions bot commented Oct 15, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira Pull Request Link

Uh oh!

codecov bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Oct 15, 2025 •

edited by atlassian bot

Loading

codecov bot commented Oct 15, 2025 •

edited

Loading