-
Notifications
You must be signed in to change notification settings - Fork 109
feat: [IOCOM-2636] AAR error tracking #7485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # ts/features/pn/aar/store/selectors/index.ts
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7485 +/- ##
==========================================
+ Coverage 59.69% 59.76% +0.06%
==========================================
Files 1839 1839
Lines 39659 39714 +55
Branches 9163 9115 -48
==========================================
+ Hits 23675 23734 +59
- Misses 15901 15909 +8
+ Partials 83 71 -12
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
const titleReport = input.title != null ? ` ${input.title}` : ""; | ||
const traceIdReport = input.traceId != null ? ` ${input.traceId}` : ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const titleReport = input.title != null ? ` ${input.title}` : ""; | |
const traceIdReport = input.traceId != null ? ` ${input.traceId}` : ""; | |
const titleReport = ` ${input.title??""}`; | |
const traceIdReport = ` ${input.traceId??""}` |
what about nullish coalescence for this whole section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing it like that leads to a worst debug string when data is nullish. The "verbose" solution produces:
"Some other parts of the log"
while the nullish:
"Some other parts of the log "
While the extra spaces here seem minor, when combined with different nullish cases, thye lead to a dirtier log string.
Short description
This PR adds error tracking for the phase 2 of SEND's AAR.
It also fixes the error toast not showing when an attachment download fails.
Simulator.Screen.Recording.-.iPhone.16.-.2025-10-16.at.10.50.12.mp4
List of changes proposed in this pull request
useIOToast
hook instead of theToast
property of the design systemHow to test
Using the io-dev-api-server, check that every failure entry point is properly tracked:
Also check that, in debug modo, the ladybug feature is working on the SENDAARErrorComponent