Skip to content

Conversation

LeleDallas
Copy link
Contributor

@LeleDallas LeleDallas commented Oct 16, 2025

Short description

This pull request introduces several UI improvements and refactors to enhance consistency, clarity, and user experience across the bonus and IDPay onboarding features

List of changes proposed in this pull request

  • Updated the color scheme for progress bars and value displays in BonusCardCounter, BonusProgressBar, and ProgressBar components to use blueIO-500 instead of blueItalia-500
  • Corrected the error message key for empty values in the multi-value prerequisites onboarding screen to use the appropriate translation
  • Removed an extra divider in the discount details bottom sheet for a cleaner UI
  • Enhanced divider rendering logic in IdPayInitiativeTimelineComponent to avoid unnecessary dividers at the end of the timeline
  • Updated IdPayCompletionScreen to use the new subtitle format, enabling rich text styling (including bold) and improved alignment
  • Updated IDPay GenericError copy

How to test

  • Try to onboard successfully an initiative and ensure that now success screen copy is aligned with design
  • Try to onboard with a GenericError and ensure that copy title is aligned with design
  • With light mode enabled, check that color of progress bar and expensive amount from IDPAY_DETAILS_MONITORING and IDPAY_BARCODE_RESULT are now aligned with design
  • Check that in IDPAY_DETAILS_MONITORING timeline list last element (bottom-most) has no divider
  • Tap on Usa il bonus CTA, ensure that there's no Divider below Genera un codice sconto

@LeleDallas LeleDallas self-assigned this Oct 16, 2025
@LeleDallas LeleDallas added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Oct 16, 2025
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Oct 16, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.60%. Comparing base (7948343) to head (60dd0fc).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ls/components/IdPayInitiativeTimelineComponent.tsx 0.00% 3 Missing ⚠️
...idpay/onboarding/screens/IdPayCompletionScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7486      +/-   ##
==========================================
- Coverage   59.60%   59.60%   -0.01%     
==========================================
  Files        1830     1830              
  Lines       39532    39535       +3     
  Branches     9124     9126       +2     
==========================================
  Hits        23564    23564              
- Misses      15887    15889       +2     
- Partials       81       82       +1     
Files with missing lines Coverage Δ
ts/components/BonusCard/BonusCardCounter.tsx 96.00% <100.00%> (ø)
...s/features/bonus/common/components/ProgressBar.tsx 90.00% <100.00%> (ø)
...tails/hooks/useIdPayDiscountDetailsBottomSheet.tsx 53.57% <ø> (ø)
...ing/screens/IdPayMultiValuePrerequisitesScreen.tsx 4.54% <ø> (ø)
...idpay/onboarding/screens/IdPayCompletionScreen.tsx 4.16% <0.00%> (-0.19%) ⬇️
...ls/components/IdPayInitiativeTimelineComponent.tsx 75.00% <0.00%> (-3.95%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7948343...60dd0fc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LeleDallas LeleDallas changed the title chore: [IOBP-2074] Adjust bonus screen copy and cosmetics changes chore: [IOBP-2074, IOBP-2070] Adjust bonus screen copy and cosmetics changes Oct 16, 2025
@LeleDallas LeleDallas changed the title chore: [IOBP-2074, IOBP-2070] Adjust bonus screen copy and cosmetics changes chore: [IOBP-2074,IOBP-2070] Adjust bonus screen copy and cosmetics changes Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IDPay IO-Bonus e pagamenti IO - Bonus e pagamenti

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants