-
Notifications
You must be signed in to change notification settings - Fork 109
fix: [IOPID-3480,IOPID-3487] email address validation: polling and email validation #7490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes two issues in the email validation flow: ensures proper cleanup of polling resources when validation fails, and prevents duplicate validation emails from being sent to users.
Key Changes:
- Added
stopPollingSaga()
call on validation error to clean up polling resources - Updated
useEffect
dependency array to includestopPollingSaga
for proper effect behavior - Fixed
sendEmailAtFirstRender
parameter to prevent duplicate validation emails
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
EmailValidationSendEmailScreen.tsx | Added polling cleanup on error and updated effect dependencies |
EmailInsertScreen.tsx | Fixed parameter controlling when validation email is sent |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
params: { | ||
isOnboarding, | ||
sendEmailAtFirstRender: isOnboarding | ||
sendEmailAtFirstRender |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change from isOnboarding
to sendEmailAtFirstRender
appears problematic. The variable sendEmailAtFirstRender
is not defined in the visible context, which will cause a runtime error. If this variable should be derived from isOnboarding
or another source, it needs to be defined before being passed as a parameter.
Copilot uses AI. Check for mistakes.
This pull request introduces a minor update to the email validation flow. The most significant changes ensure that polling is properly stopped on error and not send double validation email
Email validation flow improvements (IOPID-3487):
stopPollingSaga()
when an error occurs during the email validation request to ensure polling is stopped and resources are cleaned up.useEffect
to includestopPollingSaga
, ensuring proper effect behavior.Double email validation (IOPID-3480):