fix: [IOPLT-000] Setup Android screen orientation based on OS version#7658
Open
LeleDallas wants to merge 18 commits intomasterfrom
Open
fix: [IOPLT-000] Setup Android screen orientation based on OS version#7658LeleDallas wants to merge 18 commits intomasterfrom
LeleDallas wants to merge 18 commits intomasterfrom
Conversation
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7658 +/- ##
=======================================
Coverage 60.55% 60.55%
=======================================
Files 1934 1934
Lines 42667 42667
Branches 9861 9868 +7
=======================================
Hits 25838 25838
+ Misses 16752 16740 -12
- Partials 77 89 +12 see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This pull request updates the way screen orientation is handled for the
MainActivityin the Android app. The main change ensures that portrait orientation is explicitly set only for devices running versions earlier than Android Oreo (API 26), instead of enforcing it via the manifest for all versions.Previously the fix was developed here #7628 but was not compatible with Android 8
List of changes proposed in this pull request
android:screenOrientation="portrait"attribute from theMainActivitydeclaration inAndroidManifest, so orientation is no longer forced at the manifest levelMainActivityto programmatically set portrait orientation only for devices running Android versions lower than Oreo (API 26), improving compatibility with newer Android versionsHow to test
Ensure that on Android now the App cannot be in landscape mode and on Android 8 app is not crashing