feat(IT-Wallet): [SIW-2178] Credentials storage optimization

ts/components/SectionStatus/__tests__/index.test.tsx

@@ -1,26 +1,25 @@
+import { IOColors } from "@pagopa/io-app-design-system";
 import { fireEvent } from "@testing-library/react-native";
 import * as O from "fp-ts/lib/Option";
-import configureMockStore from "redux-mock-store";
-import { IOColors } from "@pagopa/io-app-design-system";
 import I18n from "i18next";
+import configureMockStore from "redux-mock-store";
 import { ToolEnum } from "../../../../definitions/content/AssistanceToolConfig";
 import { Config } from "../../../../definitions/content/Config";
 import {
   LevelEnum,
   SectionStatus
 } from "../../../../definitions/content/SectionStatus";
-
-import { SectionStatusKey } from "../../../store/reducers/backendStatus/sectionStatus";
-import { renderScreenWithNavigationStoreContext } from "../../../utils/testWrapper";
-import { openWebUrl } from "../../../utils/url";
-import SectionStatusComponent from "../index";
 import { PersistedFeaturesState } from "../../../features/common/store/reducers";
 import { ItWalletState } from "../../../features/itwallet/common/store/reducers";
-import { GlobalState } from "../../../store/reducers/types";
 import { CredentialType } from "../../../features/itwallet/common/utils/itwMocksUtils";
-import { StoredCredential } from "../../../features/itwallet/common/utils/itwTypesUtils";
+import { CredentialMetadata } from "../../../features/itwallet/common/utils/itwTypesUtils";
 import { ItwCredentialsState } from "../../../features/itwallet/credentials/store/reducers";
 import { setLocale } from "../../../i18n";
+import { SectionStatusKey } from "../../../store/reducers/backendStatus/sectionStatus";
+import { GlobalState } from "../../../store/reducers/types";
+import { renderScreenWithNavigationStoreContext } from "../../../utils/testWrapper";
+import { openWebUrl } from "../../../utils/url";
+import SectionStatusComponent from "../index";
 
 jest.mock("../../../utils/url");
 
@@ -65,7 +64,7 @@ const mockSectionStatusState = (
     features: {
       itWallet: {
         credentials: {
-          credentials: { [CredentialType.PID]: {} as StoredCredential }
+          credentials: { [CredentialType.PID]: {} as CredentialMetadata }
         } as ItwCredentialsState,
         issuance: { integrityKeyTag: O.some("key-tag") }
       } as ItWalletState
@@ -187,7 +186,7 @@ describe("Section Status Component should return null", () => {
         features: {
           itWallet: {
             credentials: {
-              credentials: { [CredentialType.PID]: {} as StoredCredential }
+              credentials: { [CredentialType.PID]: {} as CredentialMetadata }
             } as ItwCredentialsState,
             issuance: { integrityKeyTag: O.some("key-tag") }
           } as ItWalletState

ts/features/itwallet/analytics/properties/basePropertyBuilder.ts

@@ -3,20 +3,16 @@ import { pipe } from "fp-ts/lib/function";
 import { GlobalState } from "../../../../store/reducers/types";
 import { itwAuthLevelSelector } from "../../common/store/selectors/preferences";
 import { getCredentialStatus } from "../../common/utils/itwCredentialStatusUtils";
-import { isItwCredential } from "../../common/utils/itwCredentialUtils";
 import { CredentialType } from "../../common/utils/itwMocksUtils";
 import {
   itwCredentialsEidStatusSelector,
   itwCredentialsSelector
 } from "../../credentials/store/selectors";
 import { itwLifecycleIsITWalletValidSelector } from "../../lifecycle/store/selectors";
-import { ItwJwtCredentialStatus } from "../../common/utils/itwTypesUtils";
 import { mapPIDStatusToMixpanel } from "../utils";
 import {
-  ItwStatus,
-  ItwPIDStatus,
-  ItwCredentialMixpanelStatus,
-  CREDENTIAL_STATUS_MAP
+  CREDENTIAL_STATUS_MAP,
+  ItwCredentialMixpanelStatus
 } from "../utils/types";
 import { ItwBaseProperties } from "./propertyTypes";
 
@@ -27,9 +23,10 @@ export const buildItwBaseProperties = (
   state: GlobalState
 ): ItwBaseProperties => {
   const isItwL3 = itwLifecycleIsITWalletValidSelector(state);
+  const pidStatus = itwCredentialsEidStatusSelector(state);
 
-  const ITW_STATUS_V2 = getWalletStatus(state);
-  const ITW_PID = getPIDMixpanelStatus(state, true);
+  const ITW_STATUS_V2 = itwAuthLevelSelector(state) ?? "not_active";
+  const ITW_PID = mapPIDStatusToMixpanel(pidStatus);
 
   const ITW_PG_V3 = getMixpanelCredentialStatus(
     CredentialType.DRIVING_LICENSE,
@@ -53,7 +50,7 @@ export const buildItwBaseProperties = (
    */
   const v2Props = !isItwL3
     ? {
-        ITW_ID_V2: getPIDMixpanelStatus(state, false),
+        ITW_ID_V2: mapPIDStatusToMixpanel(pidStatus),
         ITW_PG_V2: getMixpanelCredentialStatus(
           CredentialType.DRIVING_LICENSE,
           state
@@ -79,32 +76,6 @@ export const buildItwBaseProperties = (
   };
 };
 
-const getWalletStatus = (state: GlobalState): ItwStatus => {
-  const authLevel = itwAuthLevelSelector(state);
-  return authLevel ? authLevel : "not_active";
-};
-
-/**
- * Returns the PID status for Mixpanel analytics.
- * - If `isL3` is true → we consider the status from the current L3 PID (IT Wallet).
- * - If `isL3` is false → we use the current eID status.
- */
-export const getPIDMixpanelStatus = (
-  state: GlobalState,
-  isL3: boolean
-): ItwPIDStatus =>
-  pipe(
-    isL3
-      ? pipe(
-          itwLifecycleIsITWalletValidSelector(state),
-          O.fromPredicate(Boolean),
-          O.chain(() => O.fromNullable(itwCredentialsEidStatusSelector(state)))
-        )
-      : O.fromNullable(itwCredentialsEidStatusSelector(state)),
-    O.map<ItwJwtCredentialStatus, ItwPIDStatus>(mapPIDStatusToMixpanel),
-    O.getOrElse((): ItwPIDStatus => "not_available")
-  );
-
 /**
  * Returns the Mixpanel status for a credential type, considering IT Wallet.
  * - If `isItwL3` is explicitly false, returns `"not_available"`.
@@ -121,9 +92,6 @@ const getMixpanelCredentialStatus = (
     return "not_available";
   }
   const credential = itwCredentialsSelector(state)[type];
-  if (isItwL3 && credential && !isItwCredential(credential)) {
-    return "not_available";
-  }
 
   return pipe(
     O.fromNullable(credential),

ts/features/itwallet/analytics/properties/propertyUpdaters.ts

@@ -13,15 +13,13 @@ import {
   isMixpanelInstanceInitialized,
   registerSuperProperties
 } from "../../../../mixpanel";
-import { isItwAnalyticsCredential } from "../utils";
+import { isItwAnalyticsCredential, mapPIDStatusToMixpanel } from "../utils";
+import { itwCredentialsEidStatusSelector } from "../../credentials/store/selectors";
 import {
   ItwProfileProperties,
   forceUpdateItwProfileProperties
 } from "./profileProperties";
-import {
-  buildItwBaseProperties,
-  getPIDMixpanelStatus
-} from "./basePropertyBuilder";
+import { buildItwBaseProperties } from "./basePropertyBuilder";
 import {
   ItwSuperProperties,
   buildItwSuperProperties,
@@ -66,15 +64,16 @@ export const updateItwStatusAndPIDProperties = (state: GlobalState) => {
     return;
   }
 
-  const isItwL3 = itwLifecycleIsITWalletValidSelector(state);
-  const eIDStatus = !isItwL3 ? getPIDMixpanelStatus(state, false) : undefined;
-  const pidStatus = getPIDMixpanelStatus(state, true);
+  const pidStatus = itwCredentialsEidStatusSelector(state);
 
   const baseProps = {
     ITW_STATUS_V2: authLevel,
-    ITW_PID: pidStatus
+    ITW_PID: mapPIDStatusToMixpanel(pidStatus)
   };
 
+  const isItwL3 = itwLifecycleIsITWalletValidSelector(state);
+  const eIDStatus = !isItwL3 ? mapPIDStatusToMixpanel(pidStatus) : undefined;
+
   forceUpdateItwProfileProperties({
     ...baseProps,
     ...(eIDStatus ? { ITW_ID_V2: eIDStatus } : {})

ts/features/itwallet/analytics/saga/__tests__/credentialAnalyticsHandlers.test.ts

@@ -17,7 +17,7 @@ import {
   handleCredentialStoredAnalytics,
   handleCredentialRemovedAnalytics
 } from "../credentialAnalyticsHandlers";
-import { StoredCredential } from "../../../common/utils/itwTypesUtils";
+import { CredentialMetadata } from "../../../common/utils/itwTypesUtils";
 import { CredentialType } from "../../../common/utils/itwMocksUtils";
 
 jest.mock("../../properties/propertyUpdaters", () => ({
@@ -27,35 +27,36 @@ jest.mock("../../properties/propertyUpdaters", () => ({
 
 const expirationClaim = { value: "2100-09-04", name: "exp" };
 const jwtExpiration = "2100-09-04T00:00:00.000Z";
-const mockedEid: StoredCredential = {
-  credential: "",
+const mockedEid: CredentialMetadata = {
   credentialType: CredentialType.PID,
   credentialId: "dc_sd_jwt_PersonIdentificationData",
   parsedCredential: {
     expiry_date: expirationClaim
   },
   format: "dc+sd-jwt",
   keyTag: "1",
-  issuerConf: {} as StoredCredential["issuerConf"],
+  issuerConf: {} as CredentialMetadata["issuerConf"],
   jwt: {
     issuedAt: "2024-09-30T07:32:49.000Z",
     expiration: jwtExpiration
-  }
+  },
+  spec_version: "1.0.0"
 };
-const mockedMdl: StoredCredential = {
-  credential: "",
+
+const mockedMdl: CredentialMetadata = {
   credentialType: CredentialType.DRIVING_LICENSE,
   credentialId: "dc_sd_jwt_mDL",
   parsedCredential: {
     expiry_date: expirationClaim
   },
   format: "dc+sd-jwt",
   keyTag: "2",
-  issuerConf: {} as StoredCredential["issuerConf"],
+  issuerConf: {} as CredentialMetadata["issuerConf"],
   jwt: {
     issuedAt: "2024-09-30T07:32:49.000Z",
     expiration: jwtExpiration
-  }
+  },
+  spec_version: "1.0.0"
 };
 
 const store: DeepPartial<GlobalState> = {

ts/features/itwallet/analytics/saga/credentialAnalyticsHandlers.ts

@@ -12,8 +12,8 @@ import {
 } from "../properties/propertyUpdaters";
 import { getMixPanelCredential } from "../utils";
 import { MixPanelCredential } from "../utils/types";
-import { StoredCredential } from "../../common/utils/itwTypesUtils";
 import { GlobalState } from "../../../../store/reducers/types";
+import { CredentialMetadata } from "../../common/utils/itwTypesUtils";
 
 const MIXPANEL_EID_CREDENTIALS: ReadonlySet<MixPanelCredential> = new Set([
   "ITW_PID",
@@ -71,7 +71,7 @@ export function* handleCredentialRemovedAnalytics(
 }
 
 function getAnalyticsCredentialFromStored(
-  credentials: ReadonlyArray<StoredCredential>,
+  credentials: ReadonlyArray<CredentialMetadata>,
   isItwL3: boolean
 ): MixPanelCredential | undefined {
   if (credentials.length === 0) {

ts/features/itwallet/analytics/utils/index.ts

@@ -9,7 +9,7 @@ import { ItwPIDStatus, MixPanelCredential, CREDENTIALS_MAP } from "./types";
  * Maps an PID status to its corresponding Mixpanel tracking status.
  */
 export const mapPIDStatusToMixpanel = (
-  status: ItwJwtCredentialStatus
+  status: ItwJwtCredentialStatus | undefined
 ): ItwPIDStatus => {
   switch (status) {
     case "valid":