Skip to content

feat: [IOPLT-1555] Properly handles app language selection and persistence#7817

Draft
CrisTofani wants to merge 4 commits intomasterfrom
IOPLT-1555
Draft

feat: [IOPLT-1555] Properly handles app language selection and persistence#7817
CrisTofani wants to merge 4 commits intomasterfrom
IOPLT-1555

Conversation

@CrisTofani
Copy link
Contributor

Short description

This pull request refactors and simplifies the language and locale selection logic in the application streamlining related state management. It also cleans up unused saga code related to language preference synchronization and sets a default preferred language. The changes focus on improving maintainability and user experience for language selection in the preferences screen.

List of changes proposed in this pull request

  • Feature A
  • Feature B

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 29, 2026

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.21%. Comparing base (2effdae) to head (bbf82a4).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...preferences/screens/LanguagesPreferencesScreen.tsx 31.57% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7817      +/-   ##
==========================================
+ Coverage   60.19%   60.21%   +0.01%     
==========================================
  Files        1932     1932              
  Lines       42343    42328      -15     
  Branches     9710     9764      +54     
==========================================
- Hits        25489    25486       -3     
+ Misses      16778    16767      -11     
+ Partials       76       75       -1     
Files with missing lines Coverage Δ
ts/config.ts 100.00% <ø> (ø)
ts/sagas/preferences.ts 0.00% <ø> (ø)
ts/sagas/startup.ts 38.66% <ø> (+1.00%) ⬆️
ts/store/reducers/persistedPreferences.ts 74.19% <ø> (ø)
...preferences/screens/LanguagesPreferencesScreen.tsx 53.52% <31.57%> (-3.63%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc80479...bbf82a4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Activities related to internationalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants