feat: [IOPLT-1555] Properly handles app language selection and persistence#7817
Draft
CrisTofani wants to merge 4 commits intomasterfrom
Draft
feat: [IOPLT-1555] Properly handles app language selection and persistence#7817CrisTofani wants to merge 4 commits intomasterfrom
CrisTofani wants to merge 4 commits intomasterfrom
Conversation
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7817 +/- ##
==========================================
+ Coverage 60.19% 60.21% +0.01%
==========================================
Files 1932 1932
Lines 42343 42328 -15
Branches 9710 9764 +54
==========================================
- Hits 25489 25486 -3
+ Misses 16778 16767 -11
+ Partials 76 75 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This pull request refactors and simplifies the language and locale selection logic in the application streamlining related state management. It also cleans up unused saga code related to language preference synchronization and sets a default preferred language. The changes focus on improving maintainability and user experience for language selection in the preferences screen.
List of changes proposed in this pull request
How to test
Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.