chore: [IOPLT-1540] Update reanimated to 4.x#7836
Open
Conversation
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
reanimated 4.xreanimated to 4.x
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #7836 +/- ##
==========================================
+ Coverage 60.48% 60.50% +0.01%
==========================================
Files 1948 1947 -1
Lines 42996 42995 -1
Branches 9868 9862 -6
==========================================
+ Hits 26008 26014 +6
+ Misses 16909 16903 -6
+ Partials 79 78 -1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR depends on:
reanimatedv.4.xio-app-design-system#529Short description
Migrate to the new
reanimatedmajor version with the least effort possible (for now)List of changes proposed in this pull request
reanimatedto the latest4.xversion availablereanimatedto avoid generating randomnativeIDattributes in thejestsnapshotsjestSetupwith a cleaner approach by using recommendedsetUpTestsmethod. The main consequence is that a lot of snapshots have been updated.runOnJswith analogue method offered byreact-native-workletsTestAuthenticationScreentest to avoid failing testsDismissablein favor of the one exposed by the DS libraryreact-native-skiato ensure it is up to dateio-app-design-systemto the6.xpre-release version to avoid version mismatchesListItemSwipeActionDSDynamicCardRotationItwCredentialTrustmarkNote
We need to keep the patch until
reanimatedv.4.2.2is releasedHow to test
Ensure that each section of the app is tested accurately, but focus on the following:
ListItemSwipeAction)Warning
If you experience poor performance on your Android device, please refer to the description of the PR linked above