Skip to content

feat(IT-Wallet): [SIW-3867] Adds HCE support detection to NFC utilities and UI#7849

Open
mastro993 wants to merge 6 commits intomasterfrom
SIW-3867-read-hce-info-android
Open

feat(IT-Wallet): [SIW-3867] Adds HCE support detection to NFC utilities and UI#7849
mastro993 wants to merge 6 commits intomasterfrom
SIW-3867-read-hce-info-android

Conversation

@mastro993
Copy link
Contributor

@mastro993 mastro993 commented Feb 9, 2026

Short description

This PR adds methods to retrive HCE support status on Android devices.

List of changes proposed in this pull request

Native module refactor and feature addition:

  • Renamed the native module and package from NfcAntennaInfoModule/NfcAntennaInfoPackage to NfcInfoModule/NfcInfoPackage, and updated all references accordingly for broader NFC information handling. [1] [2] [3] [4]
  • Added a new method isHceSupported to the native module to check if the device supports Host Card Emulation (HCE).

TypeScript API and analytics integration:

  • Added the isHceSupported function to the nfc utility, with platform checks and error handling, and updated the analytics saga to track HCE support in addition to antenna info. [1] [2] [3] [4] [5]
  • Renamed analytics saga and related function names from updateNfcAntennaInfoTrackingProperties to updateNfcInfoTrackingProperties to reflect the broader scope. [1] [2]

Developer playground UI improvements:

  • Enhanced the NfcPlayground screen to display HCE support status using a badge, and refactored error handling and state management to accommodate the new information. [1] [2]

How to test

Go to Settings → Playgrounds → NFC

Preview

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2026

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 24.32432% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.46%. Comparing base (d91e90c) to head (4e2952e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...res/settings/devMode/playgrounds/NfcPlayground.tsx 11.76% 15 Missing ⚠️
ts/features/itwallet/analytics/saga/index.ts 0.00% 6 Missing ⚠️
ts/utils/nfc.ts 16.66% 5 Missing ⚠️
ts/components/debug/DebugPrettyPrint.tsx 0.00% 1 Missing ⚠️
ts/features/itwallet/common/saga/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7849      +/-   ##
==========================================
- Coverage   60.47%   60.46%   -0.01%     
==========================================
  Files        1942     1942              
  Lines       42840    42859      +19     
  Branches     9825     9830       +5     
==========================================
+ Hits        25907    25916       +9     
- Misses      16854    16865      +11     
+ Partials       79       78       -1     
Files with missing lines Coverage Δ
ts/components/debug/utils.ts 100.00% <100.00%> (+6.66%) ⬆️
ts/components/debug/DebugPrettyPrint.tsx 59.09% <0.00%> (ø)
ts/features/itwallet/common/saga/index.ts 3.33% <0.00%> (ø)
ts/utils/nfc.ts 45.45% <16.66%> (+1.01%) ⬆️
ts/features/itwallet/analytics/saga/index.ts 0.00% <0.00%> (ø)
...res/settings/devMode/playgrounds/NfcPlayground.tsx 10.00% <11.76%> (+1.30%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91e90c...4e2952e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mastro993 mastro993 marked this pull request as ready for review February 11, 2026 09:06
Copy link
Contributor

@ale-mazz ale-mazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Xiaomi 15T Pro, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants