Skip to content

fix: [IEL-55]: Add missing title to sign clauses screen#7858

Open
freddi301 wants to merge 4 commits intomasterfrom
IEL-55-missing-title-sign-clauses-screen
Open

fix: [IEL-55]: Add missing title to sign clauses screen#7858
freddi301 wants to merge 4 commits intomasterfrom
IEL-55-missing-title-sign-clauses-screen

Conversation

@freddi301
Copy link
Collaborator

@freddi301 freddi301 commented Feb 11, 2026

Short description

There was no screen title set on orror on clauses screen

List of changes proposed in this pull request

  • add second level header

How to test

  • Changes these files before running:
diff --git a/src/config.ts b/src/config.ts
index 5c6110b1..039b5f06 100644
--- a/src/config.ts
+++ b/src/config.ts
@@ -93,7 +93,7 @@ const defaultConfig: IoDevServerConfig = {
     paymentWithValidDueDateCount: 0,
     paymentWithExpiredDueDateCount: 0,
     fci: {
-      waitForSignatureCount: 0,
+      waitForSignatureCount: 1,
       rejectedCount: 0,
       expiredCount: 0,
       expired90Count: 0,
diff --git a/src/payloads/features/fci/qtsp-filled-document.ts b/src/payloads/features/fci/qtsp-filled-document.ts
index 0936c287..a7a9528a 100644
--- a/src/payloads/features/fci/qtsp-filled-document.ts
+++ b/src/payloads/features/fci/qtsp-filled-document.ts
@@ -9,5 +9,5 @@ export const createFilledDocumentBody: CreateFilledDocument = {
 };
 
 export const qtspFilledDocument: FilledDocumentDetailView = {
-  filled_document_url: templateUrl
+  filled_document_url: templateUrl + "kkk"
 };
  • Run the app with dev server
  • Follow the video
  • Pay attention to the top of the screen
Before After
before.mp4
after.mp4

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

Jira Pull Request Link

This Pull Request refers to Jira issues:

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.55%. Comparing base (a991ba4) to head (12dd1d9).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a991ba4) and HEAD (12dd1d9). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (a991ba4) HEAD (12dd1d9)
10 7
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7858       +/-   ##
===========================================
- Coverage   60.46%   49.55%   -10.92%     
===========================================
  Files        1942     1932       -10     
  Lines       42861    42760      -101     
  Branches     9827     9879       +52     
===========================================
- Hits        25916    21188     -4728     
- Misses      16867    21504     +4637     
+ Partials       78       68       -10     
Files with missing lines Coverage Δ
...eatures/fci/screens/valid/FciQtspClausesScreen.tsx 71.11% <100.00%> (+0.65%) ⬆️

... and 360 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1891e18...12dd1d9. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@freddi301 freddi301 changed the title fix [IEL-55]: Add missing title to sign clauses screen fix: [IEL-55]: Add missing title to sign clauses screen Feb 11, 2026
@freddi301 freddi301 marked this pull request as ready for review February 11, 2026 09:20
Copy link
Collaborator

@soixdev91 soixdev91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines 88 to 93
useHeaderSecondLevel({
title: "",
supportRequest: true,
contextualHelp: emptyContextualHelp
});

Copy link
Contributor

@Ladirico Ladirico Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, this logic is not needed here. We don't usually show the header in error screens, for this reason, the header is not present in the figma. Tt would make sense to only insert options={{ headerShown: false }} inside the navigator (here)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed here 47c1e96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 IO-Ecosystem Links IO - Ecosystem Links

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants