Skip to content

chore(IT-Wallet): [SIW-3849] Add source to avoid sending mixpanel method tracking on notfound bottomsheet#7867

Open
DavideOnano wants to merge 3 commits intomasterfrom
SIW-3849/fix-mixpanel-identification-event-trigger
Open

chore(IT-Wallet): [SIW-3849] Add source to avoid sending mixpanel method tracking on notfound bottomsheet#7867
DavideOnano wants to merge 3 commits intomasterfrom
SIW-3849/fix-mixpanel-identification-event-trigger

Conversation

@DavideOnano
Copy link
Collaborator

Short description

Fix IT-Wallet analytics in the CIE+PIN KO path: when users declare they don’t have the PIN and choose an alternative method, ITW_ID_METHOD_SELECTED is no longer tracked.

List of changes proposed in this pull request

  • Added optional source to select-identification-mode event.
  • Set source: l3-missing-pin-ko in the “Non ho il PIN” CIE bottom-sheet flow.
  • Skipped ITW_ID_METHOD_SELECTED tracking when source is l3-missing-pin-ko.
  • Added eid action tests.

How to test

In L3 activation, go through CIE+PIN -> "Non ho il pin" -> choose another method.
Verify ITW_KO_STATE_ACTION_SELECTED is tracked and ITW_ID_METHOD_SELECTED is not.

@DavideOnano DavideOnano self-assigned this Feb 12, 2026
@github-actions
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.48%. Comparing base (61892e7) to head (f97e554).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7867      +/-   ##
==========================================
+ Coverage   60.46%   60.48%   +0.01%     
==========================================
  Files        1942     1942              
  Lines       42859    42861       +2     
  Branches     9908     9827      -81     
==========================================
+ Hits        25916    25923       +7     
- Misses      16854    16859       +5     
+ Partials       89       79      -10     
Files with missing lines Coverage Δ
...identification/cie/hooks/useCieInfoBottomSheet.tsx 5.76% <ø> (ø)
ts/features/itwallet/machine/eid/actions.ts 7.14% <100.00%> (+6.23%) ⬆️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61892e7...f97e554. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant