chore(IT-Wallet): [SIW-3849] Add source to avoid sending mixpanel method tracking on notfound bottomsheet#7867
Open
DavideOnano wants to merge 3 commits intomasterfrom
Open
Conversation
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7867 +/- ##
==========================================
+ Coverage 60.46% 60.48% +0.01%
==========================================
Files 1942 1942
Lines 42859 42861 +2
Branches 9908 9827 -81
==========================================
+ Hits 25916 25923 +7
- Misses 16854 16859 +5
+ Partials 89 79 -10
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Fix IT-Wallet analytics in the CIE+PIN KO path: when users declare they don’t have the PIN and choose an alternative method,
ITW_ID_METHOD_SELECTEDis no longer tracked.List of changes proposed in this pull request
select-identification-modeevent.l3-missing-pin-koin the “Non ho il PIN” CIE bottom-sheet flow.ITW_ID_METHOD_SELECTEDtracking when source isl3-missing-pin-ko.How to test
In L3 activation, go through CIE+PIN -> "Non ho il pin" -> choose another method.
Verify
ITW_KO_STATE_ACTION_SELECTEDis tracked andITW_ID_METHOD_SELECTEDis not.