-
Notifications
You must be signed in to change notification settings - Fork 0
[#IOPID-3459] ovveride MailerConfig for ValidationEmail #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5ba891a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPID-3459 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for overriding MailUp configuration specifically for validation emails by adding optional environment variables and configuration handling to use different MailUp credentials for validation emails while keeping the existing credentials for other email types.
- Adds optional override environment variables for MailUp credentials in validation email flow
- Implements configuration logic to create separate mailer transporters for login and validation emails
- Updates function calls to use the appropriate mailer transporter based on email type
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
infra/resources/prod/function_profile.tf | Adds optional override environment variables for MailUp validation email credentials |
apps/io-profile/src/main.ts | Creates separate mailer transporters and updates function calls to use appropriate transporter |
apps/io-profile/src/config.ts | Implements configuration logic to handle MailUp credential overrides for validation emails |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Tip ✅ All Terraform module locks are up to dateNo module changes detected - everything is in sync! 📋 Pre-commit Output Log
Generated on Tue Oct 14 08:28:49 UTC 2025 |
Tip ✅ All Terraform module locks are up to dateNo module changes detected - everything is in sync! 📋 Pre-commit Output Log
Generated on Tue Oct 14 08:44:10 UTC 2025 |
|
📖 Terraform Plan (infra/resources/prod) - successShow Plan # module.function_profile.azurerm_linux_function_app.this will be updated in-place
~ resource "azurerm_linux_function_app" "this" {
~ app_settings = {
+ "OVERRIDE_MAILUP_SECRET_VALIDATION_EMAIL" = (sensitive value)
+ "OVERRIDE_MAILUP_USERNAME_VALIDATION_EMAIL" = (sensitive value)
# (44 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-main-rg-01/providers/Microsoft.Web/sites/io-p-itn-auth-profile-func-02"
name = "io-p-itn-auth-profile-func-02"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"ModuleName" = "azure_function_app"
"ModuleSource" = "DX"
"ModuleVersion" = "1.0.1"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (33 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.function_profile.azurerm_linux_function_app_slot.this[0] will be updated in-place
~ resource "azurerm_linux_function_app_slot" "this" {
~ app_settings = {
+ "OVERRIDE_MAILUP_SECRET_VALIDATION_EMAIL" = (sensitive value)
+ "OVERRIDE_MAILUP_USERNAME_VALIDATION_EMAIL" = (sensitive value)
# (45 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-auth-main-rg-01/providers/Microsoft.Web/sites/io-p-itn-auth-profile-func-02/slots/staging"
name = "staging"
tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Auth&Identity"
"ModuleName" = "azure_function_app"
"ModuleSource" = "DX"
"ModuleVersion" = "1.0.1"
"Owner" = "IO"
"Source" = "https://github.com/pagopa/io-auth-n-identity-domain/tree/main/infra/resources/prod"
}
# (31 unchanged attributes hidden)
~ site_config {
~ health_check_eviction_time_in_min = 0 -> 2
# (33 unchanged attributes hidden)
# (1 unchanged block hidden)
}
# (1 unchanged block hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy. |
Override MailerConfig with other MailUp Auth Config for validation email flow.
List of Changes
getValidationEmailMailerConfig
function, which implements the override logic for Validation Email Mailer Configuration.getValidationEmailMailerConfig
.Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: