Conversation
🦋 Changeset detectedLatest commit: 1f954ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Jira Pull Request LinkThis Pull Request refers to the following Jira issue IOPLT-1469 |
Contributor
Terraform Plan 📖Terraform Plan�[0m�[1mInitializing the backend...�[0m
�[0m�[32m
Successfully configured the backend "azurerm"! Terraform will automatically
use this backend unless the backend configuration changes.�[0m
�[0m�[1mInitializing provider plugins...�[0m
- Finding hashicorp/azurerm versions matching ">= 3.86.0, <= 3.116.0"...
- Installing hashicorp/azurerm v3.116.0...
- Installed hashicorp/azurerm v3.116.0 (signed by HashiCorp)
Terraform has created a lock file �[1m.terraform.lock.hcl�[0m to record the provider
selections it made above. Include this file in your version control repository
so that Terraform can guarantee to make the same selections by default when
you run "terraform init" in the future.�[0m
�[0m�[1m�[32mTerraform has been successfully initialized!�[0m�[32m�[0m
�[0m�[32m
You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.
If you ever set or change modules or backend configuration for Terraform,
rerun this command to reinitialize your working directory. If you forget, other
commands will detect it and remind you to do so if necessary.�[0m
data.azurerm_resource_group.this: Reading...
data.azurerm_resource_group.this: Read complete after 0s [id=/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards]
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_portal_dashboard.this will be updated in-place
~ resource "azurerm_portal_dashboard" "this" {
~ dashboard_properties = jsonencode(
~ {
~ metadata = {
~ model = {
~ filters = {
~ value = {
~ MsPortalFx_TimeRange = {
~ displayCache = {
name = "Local Time"
~ value = "Past 4 hours" -> "Past 48 hours"
}
~ filteredPartIds = [
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1e0",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1e2",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1e4",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1e6",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1e8",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1ea",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1ec",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1ee",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1f0",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1f2",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1f4",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1f6",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1f8",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1fa",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1fc",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c1fe",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c200",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c202",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c204",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c206",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c208",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c20a",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c20c",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c20e",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c210",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c212",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c214",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c216",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c218",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c21a",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c21c",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c21e",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c220",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c222",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c224",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c226",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c228",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c22a",
- "StartboardPart-LogsDashboardPart-8811c540-2ff7-43c3-b567-e3ef68b4c22c",
+ "StartboardPart-LogsDashboardPart-9badbd78-7607-4131-8fa1-8b85191432ed",
+ "StartboardPart-LogsDashboardPart-9badbd78-7607-4131-8fa1-8b85191432ef",
+ "StartboardPart-LogsDashboardPart-9badbd78-7607-4131-8fa1-8b85191432f1",
+ "StartboardPart-LogsDashboardPart-9badbd78-7607-4131-8fa1-8b85191432f3",
+ "StartboardPart-LogsDashboardPart-9badbd78-7607-4131-8fa1-8b85191432f5",
+ "StartboardPart-LogsDashboardPart-9badbd78-7607-4131-8fa1-8b85191432f7",
+ "StartboardPart-LogsDashboardPart-9badbd78-7607-4131-8fa1-8b85191432f9",
+ "StartboardPart-LogsDashboardPart-9badbd78-7607-4131-8fa1-8b85191432fb",
+ "StartboardPart-LogsDashboardPart-9badbd78-7607-4131-8fa1-8b85191432fd",
]
~ model = {
~ relative = "4h" -> "48h"
# (2 unchanged attributes hidden)
}
}
}
}
# (2 unchanged attributes hidden)
}
}
# (1 unchanged attribute hidden)
}
)
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/dashboards/providers/Microsoft.Portal/dashboards/io-p-opex_iobackend_api_backend"
name = "io-p-opex_iobackend_api_backend"
~ tags = {
"CostCenter" = "TS310 - PAGAMENTI & SERVIZI"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"Owner" = "io"
"Source" = "https://github.com/pagopa/io-backend"
- "hidden-title" = "io-p-opex_iobackend_api_backend" -> null
}
# (2 unchanged attributes hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR duplicates IO-COM endpoints using a new Communication API (/api/communication/v1) with modern stateless authentication. The changes introduce a new controller without Redis dependencies, add SEND activation endpoints, and set up Opex dashboard monitoring.
Changes:
- New Communication API routes (
/api/communication/v1) alongside legacy routes (/api/v1) - New
CommunicationControllerusing stateless authentication vs legacyMessagesController - Removed
notifyanddeleteInstallationmethods from NotificationService/Controller - Added Opex dashboard configuration for the new API endpoints
- Removed
ALLOW_NOTIFY_IP_SOURCE_RANGEconfiguration (no longer needed)
Reviewed changes
Copilot reviewed 32 out of 34 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/routes/communicationRoutes.ts |
New file with both legacy and modern Communication API route registration |
src/controllers/communicationController.ts |
New stateless controller using UserIdentity without Redis |
src/routes/pnRoutes.ts |
Refactored SEND activation routes (legacy + new) |
src/controllers/notificationController.ts |
Removed notify method and related dependencies |
src/services/notificationService.ts |
Removed notify and deleteInstallation methods |
openapi/generated/api_communication.yaml |
New OpenAPI spec for Communication API |
src/config.ts |
Removed ALLOW_NOTIFY_IP_SOURCE_RANGE, changed notification defaults |
.opex/api_communication/** |
New Opex dashboard configuration files |
| Test files | Updated tests to remove notify/deleteInstallation coverage |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Garma00
requested changes
Jan 22, 2026
arcogabbo
reviewed
Jan 23, 2026
Contributor
There was a problem hiding this comment.
This PR should mark api_backend.yaml spec into a state of deprecation. Can we label api_backend.yaml as deprecated as done here for example?
Contributor
Author
There was a problem hiding this comment.
Thanks, done in apply suggestions from code review
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Garma00
approved these changes
Jan 29, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of Changes
api_communication.yamlwith all IO-COM endpoints, usingapi/communication/v1as base pathextractLollipopLocalsFromLollipopHeadersutility, that do not need redisNOTE:
communicationControllerwas needed to introduce newextractLollipopLocalsFromLollipopHeadersutility. It will replace oldmessageControlleras soon as we remove old endpointsALLOW_NOTIFY_IP_SOURCE_RANGEwas removed, as it was anymore usedMotivation and Context
Duplicate IO-COM endpoint using new x-user middleware
How Has This Been Tested?
Unit tests
Screenshots (if appropriate):
Types of changes
Checklist: