[IOPLT-1167] Duplication of endpoints #1591
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbcocco
force-pushed
the
IOPLT-1167-duplication-of-endpoints-for-proxy
branch
from
cfb084e to
1b1dddb
Compare
|
📋 Pre-commit Output LogGenerated on Tue Jul 15 08:01:16 UTC 2025 |
|
Tip ✅ All Terraform module locks are up to dateNo module changes detected - everything is in sync! 📋 Pre-commit Output LogGenerated on Tue Jul 15 08:01:18 UTC 2025 |
📖 Terraform Plan (src/common/dev) - successShow PlanNo changes detected. |
📖 Terraform Plan ('src/common/prod') - successTerraform Planmodule.apim_itn.data.azurerm_linux_web_app.cgn_pe_backend_app_01: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [10s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.ipatente_practices_app_itn: Still reading... [10s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.ipatente_vehicles_app_itn: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.session_manager_03: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.ipatente_payments_app_itn: Still reading... [10s elapsed]
data.azurerm_linux_function_app.com_citizen_func: Still reading... [10s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [10s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.ipatente_licences_app_itn: Still reading... [10s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.appservice_continua: Still reading... [10s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.ipatente_practices_app_itn: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.session_manager_03: Still reading... [20s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.ipatente_vehicles_app_itn: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.ipatente_payments_app_itn: Still reading... [20s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.cms_backoffice_app_itn: Still reading... [20s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.ipatente_licences_app_itn: Still reading... [20s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.appservice_continua: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_continua: Still reading... [10s elapsed]
data.azurerm_linux_web_app.firmaconio_selfcare_web_app: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.ipatente_vehicles_app_itn: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.ipatente_licences_app_itn: Still reading... [10s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.session_manager_03: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.ipatente_practices_app_itn: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.fims_op_app: Still reading... [10s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.appservice_devportal_be: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_devportal_be: Still reading... [10s elapsed]
data.azurerm_linux_web_app.firmaconio_selfcare_web_app: Still reading... [20s elapsed]
data.azurerm_linux_function_app.eucovidcert: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.ipatente_vehicles_app_itn: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.ipatente_licences_app_itn: Still reading... [20s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.session_manager_03: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.ipatente_practices_app_itn: Still reading... [20s elapsed]
data.azurerm_linux_function_app.lollipop_function: Still reading... [10s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.fims_op_app: Still reading... [21s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.appservice_devportal_be: Still reading... [20s elapsed]
module.application_gateway_weu.data.azurerm_linux_web_app.appservice_devportal_be: Still reading... [20s elapsed]
data.azurerm_linux_function_app.eucovidcert: Still reading... [20s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.ipatente_payments_app_itn: Still reading... [10s elapsed]
data.azurerm_linux_function_app.services_app_backend_function_app: Still reading... [10s elapsed]
data.azurerm_linux_function_app.io_fims_user: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_assets_cdn: Still reading... [10s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.fims_op_app: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_profile: Still reading... [10s elapsed]
data.azurerm_linux_function_app.wallet_user_uat: Still reading... [10s elapsed]
data.azurerm_linux_function_app.io_sign_user: Still reading... [10s elapsed]
data.azurerm_linux_function_app.wallet_user: Still reading... [10s elapsed]
data.azurerm_linux_function_app.function_assets_cdn: Still reading... [20s elapsed]
module.application_gateway_itn.data.azurerm_linux_web_app.fims_op_app: Still reading... [20s elapsed]
data.azurerm_linux_function_app.function_profile: Still reading... [20s elapsed]
data.azurerm_linux_function_app.wallet_user_uat: Still reading... [20s elapsed]
data.azurerm_linux_function_app.io_sign_user: Still reading... [20s elapsed]
data.azurerm_linux_function_app.wallet_user: Still reading... [20s elapsed]
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
<= read (data resources)
Terraform will perform the following actions:
# module.application_gateway_itn.azurerm_web_application_firewall_policy.agw will be updated in-place
~ resource "azurerm_web_application_firewall_policy" "agw" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/applicationGatewayWebApplicationFirewallPolicies/io-p-itn-agw-waf-01"
name = "io-p-itn-agw-waf-01"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (4 unchanged attributes hidden)
~ policy_settings {
~ request_body_enforcement = false -> true
~ request_body_inspect_limit_in_kb = 0 -> 128
# (7 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
# module.application_gateway_itn.azurerm_web_application_firewall_policy.app will be updated in-place
~ resource "azurerm_web_application_firewall_policy" "app" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/applicationGatewayWebApplicationFirewallPolicies/io-p-itn-agw-api-app-waf-01"
name = "io-p-itn-agw-api-app-waf-01"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (4 unchanged attributes hidden)
~ policy_settings {
~ request_body_enforcement = false -> true
~ request_body_inspect_limit_in_kb = 0 -> 128
# (7 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
# module.application_gateway_weu.azurerm_web_application_firewall_policy.api_app will be updated in-place
~ resource "azurerm_web_application_firewall_policy" "api_app" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-external/providers/Microsoft.Network/applicationGatewayWebApplicationFirewallPolicies/io-p-waf-appgateway-api-app-policy"
name = "io-p-waf-appgateway-api-app-policy"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (4 unchanged attributes hidden)
~ policy_settings {
~ request_body_enforcement = false -> true
~ request_body_inspect_limit_in_kb = 0 -> 128
# (7 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
# module.app_backend_weu["1"].module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
~ resource "azurerm_linux_web_app" "this" {
~ app_settings = {
+ "API_BASE_PATH_PROXY" = "/api/platform/v1"
+ "CGN_API_BASE_PATH_PROXY" = "/api/cgn/v1/cgn"
+ "CGN_OPERATOR_SEARCH_API_BASE_PATH_PROXY" = "/api/cgn/v1/cgn/operator-search"
- "EUCOVIDCERT_API_BASE_PATH" = "/api/v1/eucovidcert" -> null
+ "IO_FIMS_API_BASE_PATH_PROXY" = "/api/fims/v1/fims"
+ "IO_SIGN_API_BASE_PATH_PROXY" = "/api/sign/v1/sign"
+ "IO_WALLET_API_BASE_PATH_PROXY" = "/api/wallet/v1/wallet"
+ "IO_WALLET_UAT_API_BASE_PATH_PROXY" = "/api/wallet/v1/wallet/uat"
~ "LOLLIPOP_API_BASE_PATH" = "/api/v1" -> "/first-lollipop"
+ "LOLLIPOP_API_BASE_PATH_PROXY" = "/api/first-lollipop/v1"
+ "TRIAL_SYSTEM_APIM_BASE_PATH_PROXY" = "/manage/api/v1"
+ "TRIAL_SYSTEM_API_BASE_PATH_PROXY" = "/api/trial-system/v1"
# (116 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl1"
name = "io-p-app-appbackendl1"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (25 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.app_backend_weu["1"].module.appservice_app_backend_slot_staging.azurerm_linux_web_app_slot.this will be updated in-place
~ resource "azurerm_linux_web_app_slot" "this" {
~ app_settings = {
+ "API_BASE_PATH_PROXY" = "/api/platform/v1"
+ "CGN_API_BASE_PATH_PROXY" = "/api/cgn/v1/cgn"
+ "CGN_OPERATOR_SEARCH_API_BASE_PATH_PROXY" = "/api/cgn/v1/cgn/operator-search"
- "EUCOVIDCERT_API_BASE_PATH" = "/api/v1/eucovidcert" -> null
+ "IO_FIMS_API_BASE_PATH_PROXY" = "/api/fims/v1/fims"
+ "IO_SIGN_API_BASE_PATH_PROXY" = "/api/sign/v1/sign"
+ "IO_WALLET_API_BASE_PATH_PROXY" = "/api/wallet/v1/wallet"
+ "IO_WALLET_UAT_API_BASE_PATH_PROXY" = "/api/wallet/v1/wallet/uat"
~ "LOLLIPOP_API_BASE_PATH" = "/api/v1" -> "/first-lollipop"
+ "LOLLIPOP_API_BASE_PATH_PROXY" = "/api/first-lollipop/v1"
+ "TRIAL_SYSTEM_APIM_BASE_PATH_PROXY" = "/manage/api/v1"
+ "TRIAL_SYSTEM_API_BASE_PATH_PROXY" = "/api/trial-system/v1"
# (116 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl1/slots/staging"
name = "staging"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (25 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.app_backend_weu["2"].module.appservice_app_backend.azurerm_linux_web_app.this will be updated in-place
~ resource "azurerm_linux_web_app" "this" {
~ app_settings = {
+ "API_BASE_PATH_PROXY" = "/api/platform/v1"
+ "CGN_API_BASE_PATH_PROXY" = "/api/cgn/v1/cgn"
+ "CGN_OPERATOR_SEARCH_API_BASE_PATH_PROXY" = "/api/cgn/v1/cgn/operator-search"
- "EUCOVIDCERT_API_BASE_PATH" = "/api/v1/eucovidcert" -> null
+ "IO_FIMS_API_BASE_PATH_PROXY" = "/api/fims/v1/fims"
+ "IO_SIGN_API_BASE_PATH_PROXY" = "/api/sign/v1/sign"
+ "IO_WALLET_API_BASE_PATH_PROXY" = "/api/wallet/v1/wallet"
+ "IO_WALLET_UAT_API_BASE_PATH_PROXY" = "/api/wallet/v1/wallet/uat"
~ "LOLLIPOP_API_BASE_PATH" = "/api/v1" -> "/first-lollipop"
+ "LOLLIPOP_API_BASE_PATH_PROXY" = "/api/first-lollipop/v1"
+ "TRIAL_SYSTEM_APIM_BASE_PATH_PROXY" = "/manage/api/v1"
+ "TRIAL_SYSTEM_API_BASE_PATH_PROXY" = "/api/trial-system/v1"
# (116 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl2"
name = "io-p-app-appbackendl2"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (25 unchanged attributes hidden)
# (3 unchanged blocks hidden)
}
# module.app_backend_weu["2"].module.appservice_app_backend_slot_staging.azurerm_linux_web_app_slot.this will be updated in-place
~ resource "azurerm_linux_web_app_slot" "this" {
~ app_settings = {
+ "API_BASE_PATH_PROXY" = "/api/platform/v1"
+ "CGN_API_BASE_PATH_PROXY" = "/api/cgn/v1/cgn"
+ "CGN_OPERATOR_SEARCH_API_BASE_PATH_PROXY" = "/api/cgn/v1/cgn/operator-search"
- "EUCOVIDCERT_API_BASE_PATH" = "/api/v1/eucovidcert" -> null
+ "IO_FIMS_API_BASE_PATH_PROXY" = "/api/fims/v1/fims"
+ "IO_SIGN_API_BASE_PATH_PROXY" = "/api/sign/v1/sign"
+ "IO_WALLET_API_BASE_PATH_PROXY" = "/api/wallet/v1/wallet"
+ "IO_WALLET_UAT_API_BASE_PATH_PROXY" = "/api/wallet/v1/wallet/uat"
~ "LOLLIPOP_API_BASE_PATH" = "/api/v1" -> "/first-lollipop"
+ "LOLLIPOP_API_BASE_PATH_PROXY" = "/api/first-lollipop/v1"
+ "TRIAL_SYSTEM_APIM_BASE_PATH_PROXY" = "/manage/api/v1"
+ "TRIAL_SYSTEM_API_BASE_PATH_PROXY" = "/api/trial-system/v1"
# (116 unchanged elements hidden)
}
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-rg-linux/providers/Microsoft.Web/sites/io-p-app-appbackendl2/slots/staging"
name = "staging"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (25 unchanged attributes hidden)
# (2 unchanged blocks hidden)
}
# module.github_runner_itn.module.container_app_github_runner.azurerm_container_app_job.github_runner will be updated in-place
~ resource "azurerm_container_app_job" "github_runner" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-github-runner-rg-01/providers/Microsoft.App/jobs/io-p-itn-io-infra-caj-01"
name = "io-p-itn-io-infra-caj-01"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"ModuleName" = "github_selfhosted_runner_on_container_app_jobs"
"ModuleSource" = "DX"
"ModuleVersion" = "1.1.0"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (8 unchanged attributes hidden)
~ template {
~ container {
name = "github-runner"
# (6 unchanged attributes hidden)
~ env {
name = "GITHUB_PAT"
- secret_name = "github-runner-pat" -> null
+ value = "github-runner-pat"
}
# (2 unchanged blocks hidden)
}
}
# (3 unchanged blocks hidden)
}
# module.platform_api_gateway_apim_itn.module.platform_api_gateway.azurerm_api_management.this will be updated in-place
~ resource "azurerm_api_management" "this" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.ApiManagement/service/io-p-itn-platform-api-gateway-apim-01"
name = "io-p-itn-platform-api-gateway-apim-01"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"ModuleName" = "azure_api_management"
"ModuleSource" = "DX"
"ModuleVersion" = "1.2.2"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (21 unchanged attributes hidden)
~ hostname_configuration {
~ proxy {
~ default_ssl_binding = true -> false
# (12 unchanged attributes hidden)
}
# (1 unchanged block hidden)
}
# (8 unchanged blocks hidden)
}
# module.platform_service_bus_namespace_itn.module.platform_service_bus_namespace.data.azurerm_private_dns_zone.this[0] will be read during apply
# (depends on a resource or a module with changes pending)
<= data "azurerm_private_dns_zone" "this" {
+ id = (known after apply)
+ max_number_of_record_sets = (known after apply)
+ max_number_of_virtual_network_links = (known after apply)
+ max_number_of_virtual_network_links_with_registration = (known after apply)
+ name = "privatelink.servicebus.windows.net"
+ number_of_record_sets = (known after apply)
+ resource_group_name = "io-p-evt-rg"
}
# module.platform_service_bus_namespace_itn.module.platform_service_bus_namespace.azurerm_private_endpoint.service_bus_pep[0] will be updated in-place
~ resource "azurerm_private_endpoint" "service_bus_pep" {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/privateEndpoints/io-p-itn-platform-sbns-pep-01"
name = "io-p-itn-platform-sbns-pep-01"
tags = {
"BusinessUnit" = "App IO"
"CostCenter" = "TS000 - Tecnologia e Servizi"
"CreatedBy" = "Terraform"
"Environment" = "Prod"
"ManagementTeam" = "IO Platform"
"ModuleName" = "azure_service_bus_namespace"
"ModuleSource" = "DX"
"ModuleVersion" = "0.0.4"
"Source" = "https://github.com/pagopa/io-infra/blob/main/src/common/prod"
}
# (7 unchanged attributes hidden)
~ private_dns_zone_group {
id = "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-itn-common-rg-01/providers/Microsoft.Network/privateEndpoints/io-p-itn-platform-sbns-pep-01/privateDnsZoneGroups/private-dns-zone-group"
name = "private-dns-zone-group"
~ private_dns_zone_ids = [
- "/subscriptions/ec285037-c673-4f58-b594-d7c480da4e8b/resourceGroups/io-p-evt-rg/providers/Microsoft.Network/privateDnsZones/privatelink.servicebus.windows.net",
] -> (known after apply)
}
# (1 unchanged block hidden)
}
Plan: 0 to add, 10 to change, 0 to destroy.
Warning: Argument is deprecated
with module.apim_itn.module.apim.azurerm_api_management.this,
on .terraform/modules/apim_itn.apim/main.tf line 18, in resource "azurerm_api_management" "this":
18: resource "azurerm_api_management" "this" {
`key_vault_id` has been deprecated in favour of `key_vault_certificate_id`
and will be removed in v5.0 of the AzureRM provider
(and 23 more similar warnings elsewhere)
─────────────────────────────────────────────────────────────────────────────
Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
Duplication of all endpoints following option 2 from RFC 1156
Motivation and Context
These changes enable us to seamlessly update the client to the new routes without service interruptions by having both new and legacy endpoints available at the same time
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: