[#IOPLT-1210]create resource for function elt in itn region #1672

StefanoDoc · 2025-10-09T10:21:27Z

No description provided.

BurnedMarshal

cc. @Krusty93
The current fn-elt in weu have multiple storage account linked, the itn migration for the storages was completed or it was interrupted ongoing?

BurnedMarshal · 2025-10-15T10:14:39Z

src/common/prod/italynorth.tf

+  source                          = "../_modules/function_elt"
+  prefix                          = local.prefix
+  env_short                       = local.env_short
+  project                         = local.project_weu_legacy


Any references to old weu resources should be explicit inside the module.

Suggested change

project = local.project_weu_legacy

project_weu_legacy = local.project_weu_legacy

BurnedMarshal · 2025-10-15T10:31:28Z

src/common/_modules/function_elt/storage_account_elt.tf

+  tags = var.tags
+}
+
+module "storage_account_itn_elt_02" {


⚠️ This storage it's not used in this PR. But on the as is configuration it's the one really used, see BLOB_COMMAND_STORAGE env

BurnedMarshal · 2025-10-15T10:37:45Z

src/common/_modules/function_elt/locals.tf

+      ERROR_STORAGE_TABLE_NOTIFICATION_STATUS = data.azurerm_storage_table.fnelterrors_notification_status.name
+
+      COMMAND_STORAGE                = module.storage_account_itn_elt.primary_connection_string
+      BLOB_COMMAND_STORAGE           = module.storage_account_itn_elt.primary_connection_string


ditto, in production is used 02 and not 01

BurnedMarshal · 2025-10-15T10:38:57Z

src/common/_modules/function_elt/locals.tf

+      ERROR_STORAGE_TABLE_MESSAGE_STATUS      = data.azurerm_storage_table.fnelterrors_message_status.name
+      ERROR_STORAGE_TABLE_NOTIFICATION_STATUS = data.azurerm_storage_table.fnelterrors_notification_status.name
+
+      COMMAND_STORAGE                = module.storage_account_itn_elt.primary_connection_string


This storage connection string in production it's configured with the internal fn storage

BurnedMarshal · 2025-10-15T10:42:26Z

src/common/_modules/function_elt/locals.tf

+
+
+      ERROR_STORAGE_ACCOUNT                   = module.storage_account_itn_elt.name
+      ERROR_STORAGE_KEY                       = module.storage_account_itn_elt.primary_connection_string


in production the storage used for this ENV it's iopfneltsdt

BurnedMarshal · 2025-10-15T10:47:53Z

src/common/_modules/function_elt/main.tf

+  # FIXME : do we need this ?
+  # app_service_plan_info = {
+  #   kind                         = "elastic"
+  #   sku_tier                     = "ElasticPremium"
+  #   sku_size                     = "EP2"
+  #   maximum_elastic_worker_count = 5
+  #   worker_count                 = null
+  #   zone_balancing_enabled       = null
+  # }


This is used for elastic function configuration. If we use the dx module maybe this type of function it's not available. We should find an equivalente configuration for sku and autoscaler.

@Krusty93 can we replicate this with a module ?

BurnedMarshal · 2025-10-15T10:50:59Z

src/common/_modules/function_elt/main.tf

+  #   zone_balancing_enabled       = null
+  # }
+
+  app_settings = merge(


Be careful that this module will create a slot, in production slot isn't present. We need a double check on triggers to avoid that slot will execute some code.

i can add slot_app_setting as a copy of app_setting and disable every function is that ok ?

sonarqubecloud · 2025-10-16T08:28:21Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-10-16T08:28:50Z

Tip

✅ All Terraform module locks are up to date

No module changes detected - everything is in sync!

📋 Pre-commit Output Log

[INFO] Initializing environment for https://github.com/pagopa/dx.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..........................................Passed

_{Generated on Thu Oct 16 08:28:48 UTC 2025
Run lock_modules on folder: src/common/dev/}

github-actions · 2025-10-16T08:29:35Z

📖 Terraform Plan (src/common/dev) - success

Show Plan

No changes detected.

github-actions · 2025-10-16T08:31:20Z

Tip

✅ All Terraform module locks are up to date

No module changes detected - everything is in sync!

📋 Pre-commit Output Log

[INFO] Initializing environment for https://github.com/pagopa/dx.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Terraform Providers Lock (on staged .terraform.lock.hcl files).......................Passed
- hook id: terraform_providers_lock_staged
- duration: 0.03s

No .terraform.lock.hcl files to process.

Lock Terraform Registry modules......................................................Passed
Terraform validate with tflint.......................................................Passed
Terraform fmt........................................................................Passed
terraform_docs on resources..........................................................Passed
Terraform validate...................................................................Passed
Terraform validate with trivy........................................................Passed

_{Generated on Thu Oct 16 08:31:18 UTC 2025
Run all checks on modified files}

github-actions · 2025-10-16T08:35:02Z

Tip

✅ All Terraform module locks are up to date

No module changes detected - everything is in sync!

📋 Pre-commit Output Log

[INFO] Initializing environment for https://github.com/pagopa/dx.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules..........................................Passed

_{Generated on Thu Oct 16 08:35:00 UTC 2025
Run lock_modules on folder: src/common/prod/}

github-actions · 2025-10-16T08:41:40Z

📖 Terraform Plan (src/common/prod) - success

Show Plan

Plan: 2 to import, 72 to add, 12 to change, 1 to destroy.

Full plan output was too long and was omitted. Check the workflow logs for full details.

create resource for elt in itn region

4194cbf

StefanoDoc temporarily deployed to dev-ci October 9, 2025 10:22 — with GitHub Actions Inactive

StefanoDoc temporarily deployed to prod-ci October 9, 2025 10:22 — with GitHub Actions Inactive

add data for tables and container

f677b86

StefanoDoc temporarily deployed to dev-ci October 9, 2025 14:11 — with GitHub Actions Inactive

StefanoDoc temporarily deployed to prod-ci October 9, 2025 14:11 — with GitHub Actions Inactive

remove unused var and data and add function_elt module to itn

a1403f0

StefanoDoc temporarily deployed to dev-ci October 14, 2025 08:32 — with GitHub Actions Inactive

StefanoDoc temporarily deployed to prod-ci October 14, 2025 08:32 — with GitHub Actions Inactive

Merge branch 'main' into IOPLT-1210-elt-itn-migration

8437973

StefanoDoc temporarily deployed to dev-ci October 14, 2025 12:24 — with GitHub Actions Inactive

StefanoDoc temporarily deployed to prod-ci October 14, 2025 12:25 — with GitHub Actions Inactive

StefanoDoc changed the title ~~WIP[#IOPLT-1210]create resource for function elt in itn region~~ [#IOPLT-1210]create resource for function elt in itn region Oct 14, 2025

StefanoDoc marked this pull request as ready for review October 14, 2025 13:30

StefanoDoc requested review from a team as code owners October 14, 2025 13:30

StefanoDoc temporarily deployed to dev-ci October 14, 2025 13:31 — with GitHub Actions Inactive

StefanoDoc temporarily deployed to prod-ci October 14, 2025 13:31 — with GitHub Actions Inactive

add second storage and import for both

811fb4a

StefanoDoc temporarily deployed to dev-ci October 14, 2025 15:16 — with GitHub Actions Inactive

StefanoDoc temporarily deployed to prod-ci October 14, 2025 15:16 — with GitHub Actions Inactive

comment

0b6aab4

StefanoDoc temporarily deployed to dev-ci October 15, 2025 08:16 — with GitHub Actions Inactive

StefanoDoc temporarily deployed to prod-ci October 15, 2025 08:16 — with GitHub Actions Inactive

BurnedMarshal requested changes Oct 15, 2025

View reviewed changes

change local config

f0eec55

StefanoDoc had a problem deploying to prod-ci October 15, 2025 13:02 — with GitHub Actions Failure

StefanoDoc temporarily deployed to dev-ci October 15, 2025 13:02 — with GitHub Actions Inactive

use data to reference function storage account

adf2d7c

StefanoDoc temporarily deployed to dev-ci October 15, 2025 14:42 — with GitHub Actions Inactive

StefanoDoc had a problem deploying to prod-ci October 15, 2025 14:42 — with GitHub Actions Failure

comment

78583b8

StefanoDoc temporarily deployed to prod-ci October 15, 2025 15:23 — with GitHub Actions Inactive

StefanoDoc temporarily deployed to dev-ci October 15, 2025 15:24 — with GitHub Actions Inactive

StefanoDoc requested a review from BurnedMarshal October 15, 2025 15:30

change project to project_weu_legacy

e2e2662

StefanoDoc temporarily deployed to dev-ci October 15, 2025 15:35 — with GitHub Actions Inactive

StefanoDoc temporarily deployed to prod-ci October 15, 2025 15:35 — with GitHub Actions Inactive

Merge branch 'main' into IOPLT-1210-elt-itn-migration

98e661b

StefanoDoc temporarily deployed to dev-ci October 16, 2025 08:28 — with GitHub Actions Inactive

StefanoDoc had a problem deploying to prod-ci October 16, 2025 08:29 — with GitHub Actions Error

StefanoDoc temporarily deployed to prod-ci October 16, 2025 08:35 — with GitHub Actions Inactive

	project = local.project_weu_legacy
	project_weu_legacy = local.project_weu_legacy



		ERROR_STORAGE_ACCOUNT = module.storage_account_itn_elt.name
		ERROR_STORAGE_KEY = module.storage_account_itn_elt.primary_connection_string

[#IOPLT-1210]create resource for function elt in itn region #1672

Are you sure you want to change the base?

[#IOPLT-1210]create resource for function elt in itn region #1672

Conversation

StefanoDoc commented Oct 9, 2025

Uh oh!

BurnedMarshal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BurnedMarshal Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Oct 16, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Oct 16, 2025

✅ All Terraform module locks are up to date

Uh oh!

github-actions bot commented Oct 16, 2025

📖 Terraform Plan (src/common/dev) - success

Uh oh!

github-actions bot commented Oct 16, 2025

✅ All Terraform module locks are up to date

Uh oh!

github-actions bot commented Oct 16, 2025

✅ All Terraform module locks are up to date

Uh oh!

github-actions bot commented Oct 16, 2025

📖 Terraform Plan (src/common/prod) - success

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

BurnedMarshal Oct 15, 2025 •

edited

Loading