Skip to content

fix: android deprecations #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix: android deprecations #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions android/src/main/java/com/ioreactnativecieid/IoReactNativeCieidModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ class IoReactNativeCieidModule(reactContext: ReactApplicationContext) :
// Extension function to handle API compatibility for getting signatures
private fun PackageInfo.getSignaturesCompat(): Array<Signature> {
return if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.P) {
signingInfo.apkContentsSigners
signingInfo?.apkContentsSigners ?: emptyArray()
} else {
@Suppress("DEPRECATION")
signatures
signatures ?: emptyArray()
}
}

Expand Down Expand Up @@ -85,7 +85,7 @@ class IoReactNativeCieidModule(reactContext: ReactApplicationContext) :
url: String,
resultCallback: Callback
) {
currentActivity?.let { activity ->
getReactApplicationContext().getCurrentActivity()?.let { activity ->
val intent = Intent().apply {
setClassName(packageName, className)
data = Uri.parse(url)
Expand Down Expand Up @@ -118,7 +118,7 @@ class IoReactNativeCieidModule(reactContext: ReactApplicationContext) :
}

override fun onActivityResult(
activity: Activity?,
activity: Activity,
requestCode: Int,
resultCode: Int,
data: Intent?
Expand Down Expand Up @@ -155,7 +155,7 @@ class IoReactNativeCieidModule(reactContext: ReactApplicationContext) :
onActivityResultCallback = null
}

override fun onNewIntent(intent: Intent?) {
override fun onNewIntent(intent: Intent) {
// We do not expect add any data handling here,
// but we add a log in case we need to debug some edge cases.
Log.d(name, "onNewIntent has been called")
Expand Down