[IOPAE-2127] activation functions implementation #1342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 51287eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
leopoldo94
force-pushed
the
IOPAE-2127-upser-and-get-activation-implementation
branch
from
38b4fc1 to
563ca25
Compare
Coverage Report for App Backend (./apps/app-backend)
File CoverageNo changed files found. |
Coverage Report for Backoffice Frontend (./apps/backoffice)
File CoverageNo changed files found. |
Coverage Report for Backoffice Backend (./apps/backoffice)
File CoverageNo changed files found. |
Coverage Report for Webapp (./apps/io-services-cms-webapp)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Coverage Report for External Clients (./packages/external-clients)
File CoverageNo changed files found. |
Coverage Report for Models (./packages/io-services-cms-models)
File CoverageNo changed files found. |
|
rodoviti
reviewed
Sep 22, 2025
Comment on lines
+10
to
+24
| const SPECIAL_CATEGORY: ServiceLifecycle.definitions.Service["data"]["metadata"]["category"] = | ||
| "SPECIAL"; | ||
|
|
||
| // Authorization check: only services of SPECIAL_CATEGORY can proceed | ||
| export const authorizedForSpecialServicesTask = ( | ||
| category: ServiceLifecycle.definitions.Service["data"]["metadata"]["category"], | ||
| ): TE.TaskEither< | ||
| IResponseErrorForbiddenNotAuthorized, | ||
| ServiceLifecycle.definitions.Service["data"]["metadata"]["category"] | ||
| > => | ||
| pipe( | ||
| O.fromNullable(category), | ||
| O.filter((cat) => cat === SPECIAL_CATEGORY), | ||
| TE.fromOption(() => ResponseErrorForbiddenNotAuthorized), | ||
| ); |
There was a problem hiding this comment.
suggestion(non-blocking): we can refactor it into a more understandable form
Suggested change
| const SPECIAL_CATEGORY: ServiceLifecycle.definitions.Service["data"]["metadata"]["category"] = | |
| "SPECIAL"; | |
| // Authorization check: only services of SPECIAL_CATEGORY can proceed | |
| export const authorizedForSpecialServicesTask = ( | |
| category: ServiceLifecycle.definitions.Service["data"]["metadata"]["category"], | |
| ): TE.TaskEither< | |
| IResponseErrorForbiddenNotAuthorized, | |
| ServiceLifecycle.definitions.Service["data"]["metadata"]["category"] | |
| > => | |
| pipe( | |
| O.fromNullable(category), | |
| O.filter((cat) => cat === SPECIAL_CATEGORY), | |
| TE.fromOption(() => ResponseErrorForbiddenNotAuthorized), | |
| ); | |
| // Authorization check: only services of SPECIAL_CATEGORY can proceed | |
| export const authorizedForSpecialServicesTask = ( | |
| category: ServiceLifecycle.definitions.Service["data"]["metadata"]["category"], | |
| ): TE.TaskEither<IResponseErrorForbiddenNotAuthorized, "SPECIAL"> => | |
| pipe( | |
| O.fromNullable(category), | |
| O.filter((cat) => cat === "SPECIAL"), | |
| TE.fromOption(() => ResponseErrorForbiddenNotAuthorized), | |
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
openapi spec for activations api
fix open api to integrate headers from apim and and fix the activatio…
add json for upsert and get activation api
rename variables to distinguish between two storage account
add implementation for upsert and get activation api
add events for tracking
add utils for managing special servicesrename variable to distinguish between storage accounts
add unit test for the new api
fix unit test after refactoring
Motivation and Context
The necessity to move the Upsert and Get activation API from common to IO Enti&Servizi domain
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: