Skip to content

Conversation

carlo-bussi
Copy link
Contributor

@carlo-bussi carlo-bussi commented Jun 6, 2024

List of Changes

Fixed the two lines status chips and service name

Motivation and Context

QA ticket

How Has This Been Tested?

Local dev mode with msw mocks

Screenshots (if appropriate):

image

reaize.services.mp4

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@carlo-bussi carlo-bussi requested a review from a team as a code owner June 6, 2024 15:41
Copy link

changeset-bot bot commented Jun 6, 2024

🦋 Changeset detected

Latest commit: a2d98af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
io-services-cms-backoffice Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@giamma1295
Copy link
Contributor

Please add a changeset in order to candidate this change for future release

Copy link
Contributor

@giuseppedipinto giuseppedipinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen the changes and I notice that to avoid wrapping text you have set fixed dimensions in pixels.
While I wait to do some tests myself, how does the table behave at different resolutions?
Can you share screenshots at various resolutions or alternatively a video that starts from very small width resolutions (e.g. 600/800 pixels) up to very large screens?

@carlo-bussi
Copy link
Contributor Author

carlo-bussi commented Jun 7, 2024

I have seen the changes and I notice that to avoid wrapping text you have set fixed dimensions in pixels. While I wait to do some tests myself, how does the table behave at different resolutions? Can you share screenshots at various resolutions or alternatively a video that starts from very small width resolutions (e.g. 600/800 pixels) up to very large screens?

@giuseppedipinto The question could be diveded in 2 topics:

First keep the service name on one line (with the noWrap)makes the colum lose the resize feature, so under a certain window size the table starts a horizontal scroll behaviour.

Second the fixed size is to make the ellipsis appear. with an auto width or in percentual the ellipsis doesn't appear. it needs to be wrapped in a fixed size component or with a size expressed in vw for example.

reaize.services.mp4

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants