Skip to content

Fix minor syntax errors#245

Open
nardil wants to merge 2 commits intopagopa:mainfrom
nardil:patch-1
Open

Fix minor syntax errors#245
nardil wants to merge 2 commits intopagopa:mainfrom
nardil:patch-1

Conversation

@nardil
Copy link

@nardil nardil commented Dec 29, 2023

exclusiveMaximum specifies the exclusive maximum value accepted, requiring an integer value. If exclusiveMaximum is present, maximum becomes redundant.

minLength is not applicable in array definition; minItems is the appropriate one.

The version has been incremented from 1.2.1 to 1.2.2.

exclusiveMaximum specifies the exclusive maximum value accepted, requiring an integer value. If exclusiveMaximum is present, maximum becomes redundant.

minLength is not applicable in array definition; minItems is the appropriate one.

The version has been incremented from 1.2.1 to 1.2.2.
@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2023

⚠️ No Changeset found

Latest commit: 5bc539f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

According to user manual the title length must be less then 75 chars: https://docs.pagopa.it/manuale-operativo-di-firma-con-io/creare-il-dossier
@nardil
Copy link
Author

nardil commented Dec 29, 2023

Added missing maxLength to DossierTitle: according to user manual the title length must be less then 75 chars

minimum: 100
maximum: 600
exclusiveMaximum: true
exclusiveMaximum: 600
Copy link
Member

@lucacavallaro lucacavallaro Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nardil according to OpenAPI 3.0.x documentation, exclusiveMaximum requires a boolean value (ref: https://swagger.io/docs/specification/data-models/data-types/#range). I noticed that according to the latest JSON Schema specification the behaviour of this field has changed, but OpenAPI uses a different version of JSON Schema (see https://json-schema.org/understanding-json-schema/reference/numeric#range).

So for now we can't accept this change. If it's a problem for your integration, feel free to reach us at firmaconio-tech@pagopa.it and we will figure out a better solution for your needs.

Copy link
Author

@nardil nardil Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right: I got distracted by the new Swagger editor, which actually flags it as an error (https://editor-next.swagger.io/).

DossierTitle:
type: string
minLength: 3
maxLength: 75
Copy link
Member

@lucacavallaro lucacavallaro Jan 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this edit! Good catch!

To approve it, however, we need to refactor the code, in order to introduce runtime validation and a specific error on the API. We have scheduled this development for next week, you will be credited as contributor.

@lucacavallaro
Copy link
Member

Hi @nardil thank you for your contribution 🎉 I left some comments to your changes, feel free to reply directly to those threads.

@StefanoDoc StefanoDoc requested review from a team as code owners January 29, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants