Conversation
exclusiveMaximum specifies the exclusive maximum value accepted, requiring an integer value. If exclusiveMaximum is present, maximum becomes redundant. minLength is not applicable in array definition; minItems is the appropriate one. The version has been incremented from 1.2.1 to 1.2.2.
|
According to user manual the title length must be less then 75 chars: https://docs.pagopa.it/manuale-operativo-di-firma-con-io/creare-il-dossier
|
Added missing |
| minimum: 100 | ||
| maximum: 600 | ||
| exclusiveMaximum: true | ||
| exclusiveMaximum: 600 |
There was a problem hiding this comment.
@nardil according to OpenAPI 3.0.x documentation, exclusiveMaximum requires a boolean value (ref: https://swagger.io/docs/specification/data-models/data-types/#range). I noticed that according to the latest JSON Schema specification the behaviour of this field has changed, but OpenAPI uses a different version of JSON Schema (see https://json-schema.org/understanding-json-schema/reference/numeric#range).
So for now we can't accept this change. If it's a problem for your integration, feel free to reach us at firmaconio-tech@pagopa.it and we will figure out a better solution for your needs.
There was a problem hiding this comment.
You're right: I got distracted by the new Swagger editor, which actually flags it as an error (https://editor-next.swagger.io/).
| DossierTitle: | ||
| type: string | ||
| minLength: 3 | ||
| maxLength: 75 |
There was a problem hiding this comment.
Thanks for this edit! Good catch!
To approve it, however, we need to refactor the code, in order to introduce runtime validation and a specific error on the API. We have scheduled this development for next week, you will be credited as contributor.
|
Hi @nardil thank you for your contribution 🎉 I left some comments to your changes, feel free to reply directly to those threads. |
exclusiveMaximum specifies the exclusive maximum value accepted, requiring an integer value. If exclusiveMaximum is present, maximum becomes redundant.
minLength is not applicable in array definition; minItems is the appropriate one.
The version has been incremented from 1.2.1 to 1.2.2.