chore: [SIW-3425] refactor MobileAttestationService class#678
Merged
chore: [SIW-3425] refactor MobileAttestationService class#678
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the MobileAttestationService flow by moving platform-specific decoding/parsing responsibilities and simplifying the iOS/Android validation pipeline.
Changes:
- Moved iOS CBOR decoding and assertion base64 parsing out of the iOS module and into
MobileAttestationService. - Refactored Android attestation validation to accept a pre-parsed
X509Certificate[]chain and Android assertion validation to accept parsed Google credentials. - Replaced parallel/aggregated multi-validation logic with sequential fallbacks (iOS → Android) and introduced shared parsing helpers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/io-wallet-user-func/src/infra/mobile-attestation-service/ios/index.ts | iOS validators now take already-decoded attestation/assertion structures. |
| apps/io-wallet-user-func/src/infra/mobile-attestation-service/index.ts | Centralized parsing (CBOR/X509/base64/credentials) and refactored fallback orchestration. |
| apps/io-wallet-user-func/src/infra/mobile-attestation-service/android/index.ts | Android validators now accept pre-parsed inputs (X509 chain, Google creds) and removed internal parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/io-wallet-user-func/src/infra/mobile-attestation-service/index.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/io-wallet-user-func/src/infra/mobile-attestation-service/index.ts
Outdated
Show resolved
Hide resolved
apps/io-wallet-user-func/src/infra/mobile-attestation-service/index.ts
Outdated
Show resolved
Hide resolved
silvicir
requested review from
LazyAfternoons,
ale-mazz and
grausof
and removed request for
a team
grausof
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.