Skip to content

chore: removed unused app settings#682

Merged
silvicir merged 3 commits intomasterfrom
remove-unused-app-settings
Jan 30, 2026
Merged

chore: removed unused app settings#682
silvicir merged 3 commits intomasterfrom
remove-unused-app-settings

Conversation

@silvicir
Copy link
Contributor

No description provided.

@silvicir silvicir requested review from a team as code owners January 30, 2026 13:18
@silvicir silvicir requested review from grausof and mastro993 and removed request for a team January 30, 2026 13:18
@silvicir silvicir merged commit 36b21c3 into master Jan 30, 2026
7 checks passed
@silvicir silvicir deleted the remove-unused-app-settings branch January 30, 2026 13:22
@github-actions
Copy link
Contributor

📋 Pre-commit Output Log
[INFO] Initializing environment for https://github.com/pagopa/dx.
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
Lock Terraform Registry modules......................(no files to check)Skipped

Generated on Fri Jan 30 13:23:34 UTC 2026
Run lock_modules on folder: infra/resources/psn/prod/

@silvicir silvicir temporarily deployed to infra-psn-prod-ci January 30, 2026 13:23 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

📖 Terraform Plan (infra/resources/psn/prod) - success

Show Plan
  # module.apim.azurerm_api_management.this will be updated in-place
  ~ resource "azurerm_api_management" "this" {
        id                            = "/subscriptions/725dede2-879b-45c5-82fa-eb816875b10c/resourceGroups/iw-p-itn-wallet-rg-01/providers/Microsoft.ApiManagement/service/iw-p-itn-apps-apim-01"
        name                          = "iw-p-itn-apps-apim-01"
      ~ tags                          = {
            "BusinessUnit"  = "IT-Wallet"
            "CostCenter"    = "TS000 - Tecnologia e Servizi"
            "CreatedBy"     = "Terraform"
            "Environment"   = "PROD"
            "ModuleName"    = "azure_api_management"
            "ModuleSource"  = "DX"
          ~ "ModuleVersion" = "2.1.0" -> "2.1.1"
            "Source"        = "https://github.com/pagopa/io-wallet/blob/main/infra/resources/psn/prod"
        }
        # (21 unchanged attributes hidden)

        # (9 unchanged blocks hidden)
    }

  # module.apim.azurerm_monitor_autoscale_setting.this[0] will be updated in-place
  ~ resource "azurerm_monitor_autoscale_setting" "this" {
        id                  = "/subscriptions/725dede2-879b-45c5-82fa-eb816875b10c/resourceGroups/iw-p-itn-wallet-rg-01/providers/Microsoft.Insights/autoScaleSettings/iw-p-itn-apps-apim-as-01"
        name                = "iw-p-itn-apps-apim-as-01"
        tags                = {}
        # (4 unchanged attributes hidden)

      ~ profile {
            name = "default"

          ~ rule {
              ~ metric_trigger {
                  ~ threshold                = 60 -> 40
                    # (9 unchanged attributes hidden)
                }

                # (1 unchanged block hidden)
            }

            # (2 unchanged blocks hidden)
        }
    }

  # module.apim.azurerm_network_security_group.nsg_apim will be updated in-place
  ~ resource "azurerm_network_security_group" "nsg_apim" {
        id                  = "/subscriptions/725dede2-879b-45c5-82fa-eb816875b10c/resourceGroups/pagopa-Prod-ITWallet-rg-spoke-italynorth/providers/Microsoft.Network/networkSecurityGroups/iw-p-itn-apps-apim-nsg-01"
        name                = "iw-p-itn-apps-apim-nsg-01"
      ~ tags                = {
            "BusinessUnit"  = "IT-Wallet"
            "CostCenter"    = "TS000 - Tecnologia e Servizi"
            "CreatedBy"     = "Terraform"
            "Environment"   = "PROD"
            "ModuleName"    = "azure_api_management"
            "ModuleSource"  = "DX"
          ~ "ModuleVersion" = "2.1.0" -> "2.1.1"
            "Source"        = "https://github.com/pagopa/io-wallet/blob/main/infra/resources/psn/prod"
        }
        # (3 unchanged attributes hidden)
    }

  # module.cosmos.azurerm_cosmosdb_sql_container.containers["leases-revoke-wallet-instance"] will be destroyed
  # (because key ["leases-revoke-wallet-instance"] is not in for_each map)
  - resource "azurerm_cosmosdb_sql_container" "containers" {
      - account_name        = "iw-p-itn-apps-cosno-01" -> null
      - database_name       = "db" -> null
      - id                  = "/subscriptions/725dede2-879b-45c5-82fa-eb816875b10c/resourceGroups/iw-p-itn-wallet-rg-01/providers/Microsoft.DocumentDB/databaseAccounts/iw-p-itn-apps-cosno-01/sqlDatabases/db/containers/leases-revoke-wallet-instance" -> null
      - name                = "leases-revoke-wallet-instance" -> null
      - partition_key_kind  = "Hash" -> null
      - partition_key_paths = [
          - "/id",
        ] -> null
      - resource_group_name = "iw-p-itn-wallet-rg-01" -> null
      - throughput          = 3000 -> null

      - autoscale_settings {
          - max_throughput = 4000 -> null
        }

      - conflict_resolution_policy {
          - conflict_resolution_path      = "/_ts" -> null
          - mode                          = "LastWriterWins" -> null
            # (1 unchanged attribute hidden)
        }

      - indexing_policy {
          - indexing_mode = "consistent" -> null

          - included_path {
              - path = "/*" -> null
            }
        }
    }

  # module.function_apps.module.function_app_user.azurerm_linux_function_app.this will be updated in-place
  ~ resource "azurerm_linux_function_app" "this" {
      ~ app_settings                                   = {
          - "SlackStatusChannelWebhook"                                                                        = "@Microsoft.KeyVault(VaultName=iw-p-itn-apps-kv-01;SecretName=SlackStatusChannelWebhook)" -> null
          - "TrialSystemApiKey"                                                                                = "[REDACTED]" -> null
            # (77 unchanged elements hidden)
        }
        id                                             = "/subscriptions/725dede2-879b-45c5-82fa-eb816875b10c/resourceGroups/iw-p-itn-wallet-rg-01/providers/Microsoft.Web/sites/iw-p-itn-user-func-01"
        name                                           = "iw-p-itn-user-func-01"
        tags                                           = {
            "BusinessUnit"  = "IT-Wallet"
            "CostCenter"    = "TS000 - Tecnologia e Servizi"
            "CreatedBy"     = "Terraform"
            "Environment"   = "PROD"
            "ModuleName"    = "azure_function_app"
            "ModuleSource"  = "DX"
            "ModuleVersion" = "4.2.0"
            "Source"        = "https://github.com/pagopa/io-wallet/blob/main/infra/resources/psn/prod"
        }
        # (33 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

  # module.function_apps.module.function_app_user.azurerm_linux_function_app_slot.this[0] will be updated in-place
  ~ resource "azurerm_linux_function_app_slot" "this" {
      ~ app_settings                                   = {
          - "SlackStatusChannelWebhook"                                                                        = "@Microsoft.KeyVault(VaultName=iw-p-itn-apps-kv-01;SecretName=SlackStatusChannelWebhook)" -> null
          - "TrialSystemApiKey"                                                                                = "[REDACTED]" -> null
            # (77 unchanged elements hidden)
        }
        id                                             = "/subscriptions/725dede2-879b-45c5-82fa-eb816875b10c/resourceGroups/iw-p-itn-wallet-rg-01/providers/Microsoft.Web/sites/iw-p-itn-user-func-01/slots/staging"
        name                                           = "staging"
        tags                                           = {
            "BusinessUnit"  = "IT-Wallet"
            "CostCenter"    = "TS000 - Tecnologia e Servizi"
            "CreatedBy"     = "Terraform"
            "Environment"   = "PROD"
            "ModuleName"    = "azure_function_app"
            "ModuleSource"  = "DX"
            "ModuleVersion" = "4.2.0"
            "Source"        = "https://github.com/pagopa/io-wallet/blob/main/infra/resources/psn/prod"
        }
        # (31 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

  # module.function_apps.module.function_app_user_uat.azurerm_linux_function_app.this will be updated in-place
  ~ resource "azurerm_linux_function_app" "this" {
      ~ app_settings                                   = {
          - "SlackStatusChannelWebhook"                                                                        = "foo" -> null
          - "TrialSystemApiKey"                                                                                = "foo" -> null
            # (77 unchanged elements hidden)
        }
        id                                             = "/subscriptions/725dede2-879b-45c5-82fa-eb816875b10c/resourceGroups/iw-p-itn-wallet-rg-01/providers/Microsoft.Web/sites/iw-u-itn-user-func-01"
        name                                           = "iw-u-itn-user-func-01"
        tags                                           = {
            "BusinessUnit"                           = "IT-Wallet"
            "CostCenter"                             = "TS000 - Tecnologia e Servizi"
            "CreatedBy"                              = "Terraform"
            "Environment"                            = "PROD"
            "ModuleName"                             = "azure_function_app"
            "ModuleSource"                           = "DX"
            "ModuleVersion"                          = "4.2.0"
            "Source"                                 = "https://github.com/pagopa/io-wallet/blob/main/infra/resources/psn/prod"
            "hidden-link: /app-insights-resource-id" = "[REDACTED]"
        }
        # (33 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

  # module.function_apps.module.function_app_user_uat.azurerm_linux_function_app_slot.this[0] will be updated in-place
  ~ resource "azurerm_linux_function_app_slot" "this" {
      ~ app_settings                                   = {
          - "SlackStatusChannelWebhook"                                                                        = "foo" -> null
          - "TrialSystemApiKey"                                                                                = "foo" -> null
            # (77 unchanged elements hidden)
        }
        id                                             = "/subscriptions/725dede2-879b-45c5-82fa-eb816875b10c/resourceGroups/iw-p-itn-wallet-rg-01/providers/Microsoft.Web/sites/iw-u-itn-user-func-01/slots/staging"
        name                                           = "staging"
        tags                                           = {
            "BusinessUnit"                           = "IT-Wallet"
            "CostCenter"                             = "TS000 - Tecnologia e Servizi"
            "CreatedBy"                              = "Terraform"
            "Environment"                            = "PROD"
            "ModuleName"                             = "azure_function_app"
            "ModuleSource"                           = "DX"
            "ModuleVersion"                          = "4.2.0"
            "Source"                                 = "https://github.com/pagopa/io-wallet/blob/main/infra/resources/psn/prod"
            "hidden-link: /app-insights-resource-id" = "[REDACTED]"
        }
        # (31 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 7 to change, 1 to destroy.

Warning: Argument is deprecated

  with module.apim.azurerm_api_management.this,
  on .terraform/modules/apim/main.tf line 18, in resource "azurerm_api_management" "this":
  18: resource "azurerm_api_management" "this" {

`key_vault_id` has been deprecated in favour of `key_vault_certificate_id`
and will be removed in v5.0 of the AzureRM provider

(and 5 more similar warnings elsewhere)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant