feat: P4ADEV-3775 centralized DebtPositionType taxonomyCode (and Transfer category) validation in p4pa-debt-positions #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion TaxonomyCodeConstraint in DebtPositionType, for validating taxonomyCode through TaxonomyCodeConstraintValidator.
…yCodeConstraintValidatorTest
…myCode-validation-for-DebtPositionType
…category/taxonomyCode validation; added custom exception for invalid category.
…ace CategoryValidatorService
…om exception, refactored CategoryValidatorService.isCategoryValid: it doesn't throw an exception anymore; ValidateDebtPositionServiceImpl.checkTaxonomyCategory throws InvalidValueException("[P4PA_INVALID_TAXONOMY_CATEGORY] ...") if category check fails
…goryValidatorService to TaxonomyValidatorService (and renamed its method isCategoryValid to isTaxonomyCategoryValid)
…myCode test in TaxonomyValidatorServiceImplTest
…myCode-validation-for-DebtPositionType
…or invalid taxonomyCategory in ValidateDebtPositionServiceImplTest
…ases (removed unuseful: taxonomyValidatorService.isTaxonomyCategoryValid doesn't throw exception anymore)
|
LeonardoPierangeliniNttData
requested review from
a team,
Benedetta-fabbri,
ElisKina-dev,
Giuseppe-LaManna,
MScarsella,
RiccardoGiuliani,
antocalo,
dan-ntt and
pelliccm
as code owners
antonioT90
approved these changes
Oct 2, 2025
LeonardoPierangeliniNttData
deleted the
P4ADEV-3775-taxonomyCode-validation-for-DebtPositionType
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
List of Changes
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: