Skip to content

Conversation

serdimic
Copy link
Collaborator

@serdimic serdimic commented Feb 6, 2025

Description

implement persistence for receipt

List of Changes

implement persistence for receipt

Motivation and Context

support creation of receipt

How Has This Been Tested?

  • Pre-Deploy Test
    • Unit
    • Integration (Narrow)
  • Post-Deploy Test
    • Isolated Microservice
    • Broader Integration
    • Acceptance
    • Performance & Load

Types of changes

  • PATCH - Bug fix (backwards compatible bug fixes)
  • MINOR - New feature (add functionality in a backwards compatible manner)
  • MAJOR - Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CHORE - Minor Change (fix or feature that don't impact the functionality e.g. Documentation or lint configuration)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@serdimic serdimic marked this pull request as ready for review February 6, 2025 15:38
Copy link
Contributor

@antonioT90 antonioT90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not implementing the whole logic described in:
https://pagopa.atlassian.net/browse/P4ADEV-1778

Here you are just storing the receipt.
Can you create a new JIRA task to handle:

se esiste cambiare lo stato dell’installment a PAID

se esistono ulteriori payment option:

se il broker necessita di sincronizzazione setta a TO_SYNC gli installment ad essi associati e sync_status_to = INVALID e sync_status_from = lo stato attuale (prima di TO_SYNC)

avvia l’API di workflow hub in base al tipo di integrazione del broker

allineare stati debt position (service DebtPositionHierarchyStatusAlignerServices)

pubblicazione su coda evento RT_RECEIVED

Or create a subtask just for receipt save and change PR name using the new id

@serdimic serdimic changed the title feat: P4ADEV-1778 add create receipt implementation feat: P4ADEV-1947 implement persistence for receipt Feb 7, 2025
@serdimic
Copy link
Collaborator Author

serdimic commented Feb 7, 2025

This is not implementing the whole logic described in: https://pagopa.atlassian.net/browse/P4ADEV-1778

Here you are just storing the receipt. Can you create a new JIRA task to handle:

se esiste cambiare lo stato dell’installment a PAID
se esistono ulteriori payment option:
se il broker necessita di sincronizzazione setta a TO_SYNC gli installment ad essi associati e sync_status_to = INVALID e sync_status_from = lo stato attuale (prima di TO_SYNC)
avvia l’API di workflow hub in base al tipo di integrazione del broker
allineare stati debt position (service DebtPositionHierarchyStatusAlignerServices)
pubblicazione su coda evento RT_RECEIVED

Or create a subtask just for receipt save and change PR name using the new id

created subtask P4ADEV-1947

Copy link

sonarqubecloud bot commented Feb 7, 2025

@serdimic serdimic merged commit 7afcbde into develop Feb 7, 2025
16 of 17 checks passed
@serdimic serdimic deleted the P4ADEV-1778-add_createReceipt_implementation branch February 7, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants