Skip to content

feat: P4ADEV-4441-removing-DebtPositionTypeOrg-xsdDefinitionRef #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
macacia wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

feat: P4ADEV-4441-removing-DebtPositionTypeOrg-xsdDefinitionRef #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,124 changes: 559 additions & 565 deletions openapi/generated.openapi.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions openapi/p4pa-debt-position.openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2639,8 +2639,6 @@ components:
type: string
orgSector:
type: string
xsdDefinitionRef:
type: string
amountCents:
type: integer
format: int64
Expand Down
6 changes: 3 additions & 3 deletions postman/p4pa-debt-positions-E2E.postman_collection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@
"header": [],
"body": {
"mode": "raw",
"raw": "{\r\n \"debtPositionTypeOrg\":{\r\n \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n \"organizationId\": {{organizationId}},\r\n \"balance\": \"\",\r\n \"code\": \"CODE003\",\r\n \"description\": \"Test for Save Debt Position Type Org\",\r\n \"iban\": \"IT60X0542811101000000123456\",\r\n \"postalIban\": \"IT60X0542811101000000123457\",\r\n \"postalAccountCode\": \"1234567890\",\r\n \"holderPostalCc\": \"Holder Postal CC\",\r\n \"orgSector\": \"Public Sector\",\r\n \"xsdDefinitionRef\": \"definitionRef123\",\r\n \"amountCents\": 10000,\r\n \"externalPaymentUrl\": \"https://example.com/payment\",\r\n \"flagAnonymousFiscalCode\": false,\r\n \"flagMandatoryDueDate\": false,\r\n \"flagSpontaneous\": false,\r\n \"flagNotifyIo\": true,\r\n \"ioTemplateMessage\": \"Test IO Message Template\",\r\n \"flagActive\": true,\r\n \"flagNotifyOutcomePush\": false,\r\n \"flagAmountActualization\": false,\r\n \"flagExternal\": false\r\n },\r\n \"enabledOperators\":[\r\n \"testOperator2\",\r\n \"testOperator\",\r\n \"testOperator3\"\r\n ],\r\n \"disabledOperators\":[],\r\n \"removeEnabledOperators\": false\r\n}",
"raw": "{\r\n \"debtPositionTypeOrg\":{\r\n \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n \"organizationId\": {{organizationId}},\r\n \"balance\": \"\",\r\n \"code\": \"CODE003\",\r\n \"description\": \"Test for Save Debt Position Type Org\",\r\n \"iban\": \"IT60X0542811101000000123456\",\r\n \"postalIban\": \"IT60X0542811101000000123457\",\r\n \"postalAccountCode\": \"1234567890\",\r\n \"holderPostalCc\": \"Holder Postal CC\",\r\n \"orgSector\": \"Public Sector\",\r\n \"amountCents\": 10000,\r\n \"externalPaymentUrl\": \"https://example.com/payment\",\r\n \"flagAnonymousFiscalCode\": false,\r\n \"flagMandatoryDueDate\": false,\r\n \"flagSpontaneous\": false,\r\n \"flagNotifyIo\": true,\r\n \"ioTemplateMessage\": \"Test IO Message Template\",\r\n \"flagActive\": true,\r\n \"flagNotifyOutcomePush\": false,\r\n \"flagAmountActualization\": false,\r\n \"flagExternal\": false\r\n },\r\n \"enabledOperators\":[\r\n \"testOperator2\",\r\n \"testOperator\",\r\n \"testOperator3\"\r\n ],\r\n \"disabledOperators\":[],\r\n \"removeEnabledOperators\": false\r\n}",
"options": {
"raw": {
"language": "json"
Expand Down Expand Up @@ -732,7 +732,7 @@
"header": [],
"body": {
"mode": "raw",
"raw": "{\r\n \"debtPositionTypeOrg\":{\r\n \"debtPositionTypeOrgId\": {{createdDebtPositionTypeOrgId}},\r\n \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n \"organizationId\": {{organizationId}},\r\n \"balance\": \"\",\r\n \"code\": \"CODE003\",\r\n \"description\": \"Test for Save Debt Position Type Org\",\r\n \"iban\": \"IT60X0542811101000000123456\",\r\n \"postalIban\": \"IT60X0542811101000000123457\",\r\n \"postalAccountCode\": \"1234567890\",\r\n \"holderPostalCc\": \"Holder Postal CC\",\r\n \"orgSector\": \"Public Sector\",\r\n \"xsdDefinitionRef\": \"definitionRef123\",\r\n \"amountCents\": 10000,\r\n \"externalPaymentUrl\": \"https://example.com/payment\",\r\n \"flagAnonymousFiscalCode\": false,\r\n \"flagMandatoryDueDate\": false,\r\n \"flagSpontaneous\": false,\r\n \"flagNotifyIo\": true,\r\n \"ioTemplateMessage\": \"Test IO Message Template\",\r\n \"flagActive\": true,\r\n \"flagNotifyOutcomePush\": false,\r\n \"flagAmountActualization\": false,\r\n \"flagExternal\": false\r\n },\r\n \"enabledOperators\":[\r\n \"testOperator2\",\r\n \"testOperator3\",\r\n \"testOperator4\"\r\n ],\r\n \"disabledOperators\":[\r\n \"testOperator\",\r\n \"testOperator2\"\r\n ],\r\n \"removeEnabledOperators\": false\r\n}",
"raw": "{\r\n \"debtPositionTypeOrg\":{\r\n \"debtPositionTypeOrgId\": {{createdDebtPositionTypeOrgId}},\r\n \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n \"organizationId\": {{organizationId}},\r\n \"balance\": \"\",\r\n \"code\": \"CODE003\",\r\n \"description\": \"Test for Save Debt Position Type Org\",\r\n \"iban\": \"IT60X0542811101000000123456\",\r\n \"postalIban\": \"IT60X0542811101000000123457\",\r\n \"postalAccountCode\": \"1234567890\",\r\n \"holderPostalCc\": \"Holder Postal CC\",\r\n \"orgSector\": \"Public Sector\",\r\n \"amountCents\": 10000,\r\n \"externalPaymentUrl\": \"https://example.com/payment\",\r\n \"flagAnonymousFiscalCode\": false,\r\n \"flagMandatoryDueDate\": false,\r\n \"flagSpontaneous\": false,\r\n \"flagNotifyIo\": true,\r\n \"ioTemplateMessage\": \"Test IO Message Template\",\r\n \"flagActive\": true,\r\n \"flagNotifyOutcomePush\": false,\r\n \"flagAmountActualization\": false,\r\n \"flagExternal\": false\r\n },\r\n \"enabledOperators\":[\r\n \"testOperator2\",\r\n \"testOperator3\",\r\n \"testOperator4\"\r\n ],\r\n \"disabledOperators\":[\r\n \"testOperator\",\r\n \"testOperator2\"\r\n ],\r\n \"removeEnabledOperators\": false\r\n}",
"options": {
"raw": {
"language": "json"
Expand Down Expand Up @@ -795,7 +795,7 @@
"header": [],
"body": {
"mode": "raw",
"raw": "{\r\n \"debtPositionTypeOrg\":{\r\n \"debtPositionTypeOrgId\": {{createdDebtPositionTypeOrgId}},\r\n \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n \"organizationId\": {{organizationId}},\r\n \"balance\": \"\",\r\n \"code\": \"CODE003\",\r\n \"description\": \"Test for Save Debt Position Type Org\",\r\n \"iban\": \"IT60X0542811101000000123456\",\r\n \"postalIban\": \"IT60X0542811101000000123457\",\r\n \"postalAccountCode\": \"1234567890\",\r\n \"holderPostalCc\": \"Holder Postal CC\",\r\n \"orgSector\": \"Public Sector\",\r\n \"xsdDefinitionRef\": \"definitionRef123\",\r\n \"amountCents\": 10000,\r\n \"externalPaymentUrl\": \"https://example.com/payment\",\r\n \"flagAnonymousFiscalCode\": false,\r\n \"flagMandatoryDueDate\": false,\r\n \"flagSpontaneous\": false,\r\n \"flagNotifyIo\": true,\r\n \"ioTemplateMessage\": \"Test IO Message Template\",\r\n \"flagActive\": true,\r\n \"flagNotifyOutcomePush\": false,\r\n \"flagAmountActualization\": false,\r\n \"flagExternal\": false\r\n },\r\n \"enabledOperators\":[\r\n ],\r\n \"disabledOperators\":[\r\n ],\r\n \"removeEnabledOperators\": true\r\n}",
"raw": "{\r\n \"debtPositionTypeOrg\":{\r\n \"debtPositionTypeOrgId\": {{createdDebtPositionTypeOrgId}},\r\n \"debtPositionTypeId\": {{debtPositionTypeId}},\r\n \"organizationId\": {{organizationId}},\r\n \"balance\": \"\",\r\n \"code\": \"CODE003\",\r\n \"description\": \"Test for Save Debt Position Type Org\",\r\n \"iban\": \"IT60X0542811101000000123456\",\r\n \"postalIban\": \"IT60X0542811101000000123457\",\r\n \"postalAccountCode\": \"1234567890\",\r\n \"holderPostalCc\": \"Holder Postal CC\",\r\n \"orgSector\": \"Public Sector\",\r\n \"amountCents\": 10000,\r\n \"externalPaymentUrl\": \"https://example.com/payment\",\r\n \"flagAnonymousFiscalCode\": false,\r\n \"flagMandatoryDueDate\": false,\r\n \"flagSpontaneous\": false,\r\n \"flagNotifyIo\": true,\r\n \"ioTemplateMessage\": \"Test IO Message Template\",\r\n \"flagActive\": true,\r\n \"flagNotifyOutcomePush\": false,\r\n \"flagAmountActualization\": false,\r\n \"flagExternal\": false\r\n },\r\n \"enabledOperators\":[\r\n ],\r\n \"disabledOperators\":[\r\n ],\r\n \"removeEnabledOperators\": true\r\n}",
"options": {
"raw": {
"language": "json"
Expand Down
1 change: 0 additions & 1 deletion src/main/java/it/gov/pagopa/pu/debtpositions/mapper/DebtPositionTypeOrgMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public DebtPositionTypeOrg mapFromDebtPositionType(DebtPositionType debtPosition
.postalAccountCode(null)
.holderPostalCc(null)
.orgSector(null)
.xsdDefinitionRef(null)
.amountCents(null)
.externalPaymentUrl(null)
.flagAnonymousFiscalCode(debtPositionType.isFlagAnonymousFiscalCode())
Expand Down
1 change: 0 additions & 1 deletion src/main/java/it/gov/pagopa/pu/debtpositions/model/DebtPositionTypeOrg.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public class DebtPositionTypeOrg extends BaseEntity implements Serializable {
private String postalAccountCode;
private String holderPostalCc;
private String orgSector;
private String xsdDefinitionRef;
private Long amountCents;
private String externalPaymentUrl;
private boolean flagAnonymousFiscalCode;
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/it/gov/pagopa/pu/debtpositions/mapper/DebtPositionTypeOrgMapperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ void testMapFromDebtPositionType() {
//verify
Assertions.assertNotNull(response);
TestUtils.checkNotNullFields(response, "debtPositionTypeOrgId", "balance", "iban", "postalIban",
"postalAccountCode", "holderPostalCc", "orgSector", "xsdDefinitionRef", "amountCents", "externalPaymentUrl",
"postalAccountCode", "holderPostalCc", "orgSector", "amountCents", "externalPaymentUrl",
"notifyOutcomePushOrgSilServiceId", "amountActualizationOrgSilServiceId", "serviceId", "ioTemplateSubject",
"creationDate", "updateDate", "updateOperatorExternalId", "updateTraceId", "spontaneousFormId", "allowedEntityType");
}
Expand Down
1 change: 0 additions & 1 deletion src/test/java/it/gov/pagopa/pu/debtpositions/service/DebtPositionTypeOrgServiceImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ private static DebtPositionTypeOrg buildUpdatedDebtPositionTypeOrg(DebtPositionT
.postalIban(debtPositionTypeOrg.getPostalIban()+1)
.postalAccountCode(debtPositionTypeOrg.getPostalAccountCode()+1)
.holderPostalCc(debtPositionTypeOrg.getHolderPostalCc()+1)
.xsdDefinitionRef(debtPositionTypeOrg.getXsdDefinitionRef()+1)
.amountCents(debtPositionTypeOrg.getAmountCents()+1)
.externalPaymentUrl(debtPositionTypeOrg.getExternalPaymentUrl()+1)
.flagSpontaneous(!debtPositionTypeOrg.isFlagSpontaneous())
Expand Down
2 changes: 0 additions & 2 deletions src/test/java/it/gov/pagopa/pu/debtpositions/util/faker/DebtPositionTypeOrgFaker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public static DebtPositionTypeOrg buildDebtPositionTypeOrg() {
debtPositionTypeOrg.setPostalAccountCode("12345678");
debtPositionTypeOrg.setHolderPostalCc("Test Holder");
debtPositionTypeOrg.setOrgSector("Finance");
debtPositionTypeOrg.setXsdDefinitionRef("definition.xsd");
debtPositionTypeOrg.setAmountCents(100L);
debtPositionTypeOrg.setExternalPaymentUrl("https://payment.example.com");
debtPositionTypeOrg.setFlagAnonymousFiscalCode(true);
Expand Down Expand Up @@ -48,7 +47,6 @@ public static DebtPositionTypeOrgDTO buildDebtPositionTypeOrgDTO() {
debtPositionTypeOrg.setPostalAccountCode("12345678");
debtPositionTypeOrg.setHolderPostalCc("Test Holder");
debtPositionTypeOrg.setOrgSector("Finance");
debtPositionTypeOrg.setXsdDefinitionRef("definition.xsd");
debtPositionTypeOrg.setAmountCents(100L);
debtPositionTypeOrg.setExternalPaymentUrl("https://payment.example.com");
debtPositionTypeOrg.setFlagAnonymousFiscalCode(true);
Expand Down