Skip to content

chore: Improved cache generation on getVersion request #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 5, 2025
Merged

chore: Improved cache generation on getVersion request #102

merged 9 commits into from
Sep 5, 2025

Conversation

aomegax
Copy link
Contributor

@aomegax aomegax commented Sep 4, 2025

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@aomegax aomegax marked this pull request as ready for review September 4, 2025 16:22
@aomegax aomegax requested a review from a team as a code owner September 4, 2025 16:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2025

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
63.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

andrea-deri
andrea-deri approved these changes Sep 5, 2025
View reviewed changes
Copy link
Contributor

@andrea-deri andrea-deri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🔝

@aomegax aomegax merged commit e18b2b2 into main Sep 5, 2025
14 of 15 checks passed
@aomegax aomegax deleted the cache-id branch September 5, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrea-deri andrea-deri andrea-deri approved these changes

Assignees

@aomegax aomegax

Labels

size/large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aomegax @andrea-deri @pagopa-github-bot