Skip to content

Conversation

aomegax
Copy link
Contributor

@aomegax aomegax commented Jun 5, 2025

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link

github-actions bot commented Jun 5, 2025

This pull request does not contain a valid label. Please add one of the following labels: [patch, ignore-for-release]

Copy link

github-actions bot commented Jun 5, 2025

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@github-actions github-actions bot added the patch label Jun 5, 2025
Copy link

github-actions bot commented Jun 5, 2025

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@aomegax aomegax marked this pull request as ready for review June 6, 2025 11:11
@aomegax aomegax requested a review from a team as a code owner June 6, 2025 11:11

resource "azurerm_api_management_api_version_set" "api_version_set_oracle" {
count = local.count
count = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove them if count is 0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure there will never be a need again :)
I will remove it after it is accepted in SIT env

Copy link
Contributor

@andrea-deri andrea-deri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 🚀
I've just added a comment about the exclusion of comments in files.

Copy link

github-actions bot commented Jun 9, 2025

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link

github-actions bot commented Jun 9, 2025

Comment this PR with update_code to format the code. Consider to use pre-commit to format the code.

@aomegax aomegax requested a review from andrea-deri June 9, 2025 13:17
Copy link

sonarqubecloud bot commented Jun 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@andrea-deri andrea-deri merged commit 2c2a5fd into main Jun 20, 2025
6 of 9 checks passed
@andrea-deri andrea-deri deleted the PAGOPA-2289-massive branch June 20, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants