Skip to content

Conversation

dylantangredi-jakala
Copy link
Collaborator

@dylantangredi-jakala dylantangredi-jakala commented Jan 22, 2025

List of Changes

  • removed codiceIpa and idSellerBank fields from the csv model class
  • updated example and test csv files to reflect the deprecated fields removal

Note: there were no changes required to the entity classes or the database tables as both Iban.java and IbanMaster.java entity classes do not contain reference to the removed fields/columns

Motivation and Context

The mentioned fields have been marked as deprecated on the IBAN massive upload documentation from dev portal

How Has This Been Tested?

  • Tested by manually uploading csv files with insert, update, delete operation types and checking the postgres dev db

Integration Tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Dylan Tangredi added 2 commits January 23, 2025 18:04
Copy link

@FedericoRuzzier FedericoRuzzier added patch enhancement New feature or request and removed minor labels Jan 24, 2025
@dylantangredi-jakala dylantangredi-jakala marked this pull request as ready for review January 24, 2025 10:49
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@jacopocarlini chk this pr too, pls

@jacopocarlini jacopocarlini added breaking-change This PR introduce breaking change in the release and removed patch labels Jan 24, 2025
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is ok, but the integration tests are failed

@jacopocarlini jacopocarlini added patch and removed breaking-change This PR introduce breaking change in the release labels Jan 24, 2025
@dylantangredi-jakala
Copy link
Collaborator Author

The PR is ok, but the integration tests are failed

Hello, good point and after analyzing the issue I noticed that those specific tests have been failing for quite some time
https://github.com/pagopa/pagopa-api-config/actions/workflows/integration_test.yml
Those should probably be addressed in the near future.

@dylantangredi-jakala dylantangredi-jakala merged commit 3cf0002 into main Jan 24, 2025
7 of 8 checks passed
@dylantangredi-jakala dylantangredi-jakala deleted the PIDM-65-remove-deprecated-iban-upload-fields branch January 24, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants