-
Notifications
You must be signed in to change notification settings - Fork 3
[PIDM-65] feat(massive-iban-csv-upload): remove deprecated iban upload fields #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PIDM-65] feat(massive-iban-csv-upload): remove deprecated iban upload fields #328
Conversation
… to reflect deprecated fields removal
…pload-fields' into PIDM-65-remove-deprecated-iban-upload-fields
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@jacopocarlini chk this pr too, pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is ok, but the integration tests are failed
Hello, good point and after analyzing the issue I noticed that those specific tests have been failing for quite some time |
List of Changes
Note: there were no changes required to the entity classes or the database tables as both Iban.java and IbanMaster.java entity classes do not contain reference to the removed fields/columns
Motivation and Context
The mentioned fields have been marked as deprecated on the IBAN massive upload documentation from dev portal
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: