Skip to content

[PIDM-65] feat(massive-iban-csv-upload): remove deprecated iban upload fields #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 24, 2025
Merged

[PIDM-65] feat(massive-iban-csv-upload): remove deprecated iban upload fields #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e49248
[PIDM-65] fix(massive-iban-csv-upload): remove deprecated fields from…
Jan 22, 2025
8fb2323
[PIDM-65] fix(massive-iban-csv-upload): update test/example csv files…
Jan 22, 2025
ecc271d
Merge branch 'main' into PIDM-65-remove-deprecated-iban-upload-fields
Jan 23, 2025
d501751
[PIDM-65] fix(massive-iban-csv-upload): change example csv iban valid…
Jan 23, 2025
9bf5fc6
Merge remote-tracking branch 'origin/PIDM-65-remove-deprecated-iban-u…
Jan 23, 2025
a4acfbf
Bump to version 0.59.24-1-PIDM-65-remove-deprecated-iban-upload-field…
pagopa-github-bot Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: core
description: APIs to manage configuration for CI and PSP of pagoPA
type: application
version: 0.180.0
appVersion: 0.59.24
version: 0.181.0
appVersion: 0.59.24-1-PIDM-65-remove-deprecated-iban-upload-fields
dependencies:
- name: microservice-chart
version: 2.8.0
Expand Down
2 changes: 1 addition & 1 deletion helm/values-dev.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ microservice-chart: &microservice-chart
envSecret: {}
image:
repository: ghcr.io/pagopa/pagopa-api-config
tag: "0.59.24"
tag: "0.59.24-1-PIDM-65-remove-deprecated-iban-upload-fields"
pullPolicy: Always
livenessProbe:
httpGet:
Expand Down
2 changes: 1 addition & 1 deletion helm/values-prod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ microservice-chart: &microservice-chart
envSecret: {}
image:
repository: ghcr.io/pagopa/pagopa-api-config
tag: "0.59.24"
tag: "0.59.24-1-PIDM-65-remove-deprecated-iban-upload-fields"
pullPolicy: Always
livenessProbe:
httpGet:
Expand Down
2 changes: 1 addition & 1 deletion helm/values-uat.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ microservice-chart: &microservice-chart
envSecret: {}
image:
repository: ghcr.io/pagopa/pagopa-api-config
tag: "0.59.24"
tag: "0.59.24-1-PIDM-65-remove-deprecated-iban-upload-fields"
pullPolicy: Always
livenessProbe:
httpGet:
Expand Down
6 changes: 3 additions & 3 deletions integration-test/src/step_definitions/support/resources/BAD_delete.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT60X0542811101000000123456,,2024-12-01,I
12345678904,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT60X0542811101000000123456,,2024-12-01,D
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
11911191002,C.PISACANE SAPRI,desc xxx,IT60X0542811101000000123456,2024-12-01,I
12345678904,C.PISACANE SAPRI,desc xxx,IT60X0542811101000000123456,2024-12-01,D
2 changes: 1 addition & 1 deletion integration-test/src/step_definitions/support/resources/BAD_format.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
ragionesociale,descrizione,iban,dataattivazioneiban,operazione
,,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2024-12-01,I
11911191002,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT84H0706676470000000822789,,2024-12-15,I
4 changes: 2 additions & 2 deletions integration-test/src/step_definitions/support/resources/BAD_iban.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT12A1234512345123456789012,,2024-12-01,I
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
11911191002,C.PISACANE SAPRI,desc xxx,IT12A1234512345123456789012,2024-12-01,I
6 changes: 3 additions & 3 deletions integration-test/src/step_definitions/support/resources/BAD_insert.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2024-12-01,I
11911191002,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT84H0706676470000000822789,,2024-12-15,I
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
11911191002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2024-12-01,I
11911191002,CPIA 2 - ITALO CALVINO,desc yyy,IT84H0706676470000000822789,2024-12-15,I
6 changes: 3 additions & 3 deletions integration-test/src/step_definitions/support/resources/BAD_insert_postal_iban.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT04Q0760102800000003072720,,2024-12-01,I
12345678904,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT04Q0760102800000003072720,,2024-12-01,I
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
11911191002,C.PISACANE SAPRI,desc xxx,IT04Q0760102800000003072720,2024-12-01,I
12345678904,CPIA 2 - ITALO CALVINO,desc yyy,IT04Q0760102800000003072720,2024-12-01,I
6 changes: 3 additions & 3 deletions integration-test/src/step_definitions/support/resources/BAD_update.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT60X0542811101000000123456,,2024-12-01,I
12345678904,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT60X0542811101000000123456,,2024-12-01,U
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
11911191002,C.PISACANE SAPRI,desc xxx,IT60X0542811101000000123456,2024-12-01,I
12345678904,C.PISACANE SAPRI,desc xxx,IT60X0542811101000000123456,2024-12-01,U
6 changes: 3 additions & 3 deletions integration-test/src/step_definitions/support/resources/delete.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2024-12-01,D
12345678904,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,2024-12-01,D
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
11911191002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2024-12-01,D
12345678904,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,2024-12-01,D
6 changes: 3 additions & 3 deletions integration-test/src/step_definitions/support/resources/insert.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2024-12-01,I
12345678904,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,2024-12-01,I
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
11911191002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2024-12-01,I
12345678904,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,2024-12-01,I
12 changes: 6 additions & 6 deletions integration-test/src/step_definitions/support/resources/mix.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2024-12-01,I
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx upd,IT84H0706676470000000822789,,2024-12-25,U
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx upd,IT84H0706676470000000822789,,2024-12-25,D
12345678904,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,2024-12-01,I
12345678904,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,2024-12-01,D
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
11911191002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2024-12-01,I
11911191002,C.PISACANE SAPRI,desc xxx upd,IT84H0706676470000000822789,2024-12-25,U
11911191002,C.PISACANE SAPRI,desc xxx upd,IT84H0706676470000000822789,2024-12-25,D
12345678904,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,2024-12-01,I
12345678904,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,2024-12-01,D
6 changes: 3 additions & 3 deletions integration-test/src/step_definitions/support/resources/update.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
11911191002,istsc_sais011002,C.PISACANE SAPRI,desc xxx upd,IT84H0706676470000000822789,,2024-12-01,U
12345678904,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy upd,IT74L0306905020100000046450,,2024-12-01,U
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
11911191002,C.PISACANE SAPRI,desc xxx upd,IT84H0706676470000000822789,2024-12-01,U
12345678904,CPIA 2 - ITALO CALVINO,desc yyy upd,IT74L0306905020100000046450,2024-12-01,U
2 changes: 1 addition & 1 deletion openapi/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"title": "core",
"description": "Spring application exposes APIs to manage configuration for CI/PSP on the Nodo dei Pagamenti",
"termsOfService": "https://www.pagopa.gov.it/",
"version": "0.59.24"
"version": "0.59.24-1-PIDM-65-remove-deprecated-iban-upload-fields"
},
"servers": [
{
Expand Down
2 changes: 1 addition & 1 deletion openapi/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Spring application exposes APIs to manage configuration for CI/PSP on the Nodo dei Pagamenti",
"termsOfService": "https://www.pagopa.gov.it/",
"title": "core",
"version": "0.59.24"
"version": "0.59.24-1-PIDM-65-remove-deprecated-iban-upload-fields"
},
"host": "localhost:8080",
"basePath": "/",
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<groupId>it.gov.pagopa.apiconfig</groupId>
<artifactId>core</artifactId>
<version>0.59.24</version>
<version>0.59.24-1-PIDM-65-remove-deprecated-iban-upload-fields</version>
<description>Spring application exposes APIs to manage configuration for CI/PSP on the Nodo dei Pagamenti</description>

<properties>
Expand Down
6 changes: 0 additions & 6 deletions src/main/java/it/gov/pagopa/apiconfig/core/model/massiveloading/IbanMassLoadCsv.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ public class IbanMassLoadCsv {
@CsvBindByName(required = true, column = "iddominio")
private String creditorInstitutionCode;

@CsvBindByName(required = true, column = "codiceipa")
private String codiceIpa;

@CsvBindByName(required = true, column = "ragionesociale")
private String ragioneSociale;

Expand All @@ -27,9 +24,6 @@ public class IbanMassLoadCsv {
@CsvBindByName(required = true, column = "iban")
private String iban;

@CsvBindByName(required = false, column = "idsellerbank")
private String idSellerBank;

@CsvBindByName(required = true, column = "dataattivazioneiban")
private String ibanActiveDate;

Expand Down
6 changes: 3 additions & 3 deletions src/test/resources/file/massiveIbansInvalid_NotRequiredValue.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
00168480242,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2024-12-01,I
11100011111,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,,I
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
00168480242,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2024-12-01,I
11100011111,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,I
6 changes: 3 additions & 3 deletions src/test/resources/file/massiveIbansInvalid_NotWellFormed.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2024-12-01,I
ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,2024-12-01,I
ragionesociale,descrizione,iban,dataattivazioneiban,operazione
C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2024-12-01,I
CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,2024-12-01,I
6 changes: 3 additions & 3 deletions src/test/resources/file/massiveIbansValid_Bad.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
00168480242,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2014-12-01,I
11100011111,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,2014-12-01,I
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
00168480242,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2014-12-01,I
11100011111,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,2014-12-01,I
6 changes: 3 additions & 3 deletions src/test/resources/file/massiveIbansValid_BadOperationValue.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
00168480242,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2024-12-01,X
11100011111,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,2024-12-01,X
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
00168480242,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2024-12-01,X
11100011111,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,2024-12-01,X
6 changes: 3 additions & 3 deletions src/test/resources/file/massiveIbansValid_Insert.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
00168480242,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2025-12-01,I
11100011111,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,2025-12-01,I
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
00168480242,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2025-12-01,I
11100011111,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,2025-12-01,I
6 changes: 3 additions & 3 deletions src/test/resources/file/massiveIbansValid_Update_Delete.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
00168480242,istsc_sais011002,C.PISACANE SAPRI,desc xxx upd,IT84H0706676470000000822789,,2025-12-01,U
11100011111,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,,2025-12-01,D
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
00168480242,C.PISACANE SAPRI,desc xxx upd,IT84H0706676470000000822789,2025-12-01,U
11100011111,CPIA 2 - ITALO CALVINO,desc yyy,IT74L0306905020100000046450,2025-12-01,D
6 changes: 3 additions & 3 deletions src/test/resources/file/massiveIbansValid_existingIban_Insert.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
iddominio,codiceipa,ragionesociale,descrizione,iban,idsellerbank,dataattivazioneiban,operazione
00168480242,istsc_sais011002,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,,2025-12-01,I
11100011111,ccplia3,CPIA 2 - ITALO CALVINO,desc yyy,IT84H0706676470000000822789,,2025-12-01,I
iddominio,ragionesociale,descrizione,iban,dataattivazioneiban,operazione
00168480242,C.PISACANE SAPRI,desc xxx,IT84H0706676470000000822789,2025-12-01,I
11100011111,CPIA 2 - ITALO CALVINO,desc yyy,IT84H0706676470000000822789,2025-12-01,I
Loading