fix: fixing date formatter PIDM-1100 #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not contain a valid label. Please add one of the following labels: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } catch (DateTimeParseException e2) { | ||
| throw new IllegalArgumentException("Date format not supported: " + dateStr); | ||
| } | ||
| try { |
There was a problem hiding this comment.
[google-java-format] reported by reviewdog 🐶
Suggested change
| try { | |
| try { | |
| return LocalDateTime.parse(dateStr + "T00:00:00", DATE_TIME_FORMATTER); | |
| } catch (DateTimeParseException e2) { | |
| try { |
Comment on lines
+65
to
+71
| return LocalDateTime.parse(dateStr + "T00:00:00", DATE_TIME_FORMATTER); | ||
| } catch (DateTimeParseException e2) { | ||
| try { | ||
| return LocalDateTime.parse(dateStr.substring(0, 10) + "T00:00:00", DATE_TIME_FORMATTER); | ||
| } catch (DateTimeParseException e3) { | ||
| throw new IllegalArgumentException("Date format not supported: " + dateStr); | ||
| } |
There was a problem hiding this comment.
[google-java-format] reported by reviewdog 🐶
Suggested change
| return LocalDateTime.parse(dateStr + "T00:00:00", DATE_TIME_FORMATTER); | |
| } catch (DateTimeParseException e2) { | |
| try { | |
| return LocalDateTime.parse(dateStr.substring(0, 10) + "T00:00:00", DATE_TIME_FORMATTER); | |
| } catch (DateTimeParseException e3) { | |
| throw new IllegalArgumentException("Date format not supported: " + dateStr); | |
| } | |
| return LocalDateTime.parse(dateStr.substring(0, 10) + "T00:00:00", DATE_TIME_FORMATTER); | |
| } catch (DateTimeParseException e3) { | |
| throw new IllegalArgumentException("Date format not supported: " + dateStr); |
| throw new IllegalArgumentException("Date format not supported: " + dateStr); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
[google-java-format] reported by reviewdog 🐶
Suggested change
| } | |
| } | |
| } |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
YYYY-MM-DD+00:00formatMotivation and Context
Needed to adapt to some psp who put the wrong input
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist: