Skip to content

Conversation

andrea-deri
Copy link
Contributor

@andrea-deri andrea-deri commented Apr 8, 2025

This PR contains several changes made in order to correctly generate historicized flows that can be analyzed by FdR1 application. In order to do so, the regulationDate is changed in order to be defined as yyyy-MM-dd and all the monetary amounts are always saved with double-digits decimal values.
This fix is made as low footprint change that does not change structures and interfaces used by PSPs. A more invasive fix on those public interfaces is made with this PR and will be merged soon.

List of Changes

  • Forcing regulation date to be handled in historicization process in format yyyy-MM-dd
  • Forcing monetary amounts to be handled in historicization process as double-digits in decimal section
  • Fixing fdr_history_schema_v1 file, setting monetary amounts from Integer to Double
  • Upgraded monetary amount's columns on PostgreSQL database from float4 to float8

Motivation and Context

These changes are required in order to permits the correct handling of BLOB files for FdR1 application.

How Has This Been Tested?

  • Tested in local environment
  • Tested in DEV environment
  • Tested in UAT environment

Screenshots (if appropriate):

JSON content historicized, with amounts and regulation date in needed format
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@andrea-deri andrea-deri requested a review from a team as a code owner April 8, 2025 08:32
Copy link
Contributor

github-actions bot commented Apr 8, 2025

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@github-actions github-actions bot added the patch label Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link
Contributor

github-actions bot commented Apr 8, 2025

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

@aomegax
Copy link
Contributor

aomegax commented Apr 8, 2025

@andrea-deri could you generate the openapi updated too?

@andrea-deri
Copy link
Contributor Author

@aomegax interface updates can be found at PR: #121

Copy link

sonarqubecloud bot commented Apr 9, 2025

@pasqualespica pasqualespica requested a review from aomegax April 9, 2025 10:46
@pasqualespica pasqualespica merged commit e35b739 into main Apr 9, 2025
26 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-2978 branch April 9, 2025 10:50
Copy link
Contributor

github-actions bot commented Apr 9, 2025

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants