feat: [PIDM-590] Introducing RE event persistence #136

andrea-deri · 2025-07-31T10:53:30Z

This PR contains the inclusion of RE event save strategy on FdR-Fase3 app. This strategy permits to store RE events in MongoDB container in order to track FdR flow lifecycle handled by this application. The container used is the same where FdR-Fase1 application is storing its events.
The RE event storing process is optional and can be disabled by setting the excluded operation in a specific parameter.

List of Changes

Including storage operation for RE events
Including strategy for dynamically excluding endpoints from RE store
Upgrading inclusion of required information on MDC context
Using sanitised strings on logs

Motivation and Context

These changes are required in order to activate RE event storage for FdR3 context

How Has This Been Tested?

Tested in local environment
Tested in DEV environment
Tested in UAT environment

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as
expected)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.

github-actions · 2025-07-31T10:53:40Z

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

github-actions · 2025-07-31T10:53:40Z

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

github-actions · 2025-07-31T10:53:40Z

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

src/main/java/it/gov/pagopa/fdr/controller/middleware/filter/ResponseFilter.java

src/main/java/it/gov/pagopa/fdr/service/FlowService.java

+            args.getPublishedGt(),
+            args.getFlowDate(),
+            (int) pageNumber,
+            (int) pageSize);


To fix the problem, we need to ensure that before casting pageSize and pageNumber from long to int, their values are validated to be within the valid range for an int (i.e., between Integer.MIN_VALUE and Integer.MAX_VALUE). If the values are out of range, the method should throw an exception (e.g., IllegalArgumentException or a custom application exception) to prevent truncation and potential misuse. The best place to add this check is immediately before the cast in FlowService.getPaginatedPublishedFlowsForCI (and similarly in getPaginatedPublishedFlowsForPSP if it also casts user-controlled values). This preserves existing functionality and ensures safety.

No new imports are needed, as Integer.MIN_VALUE and Integer.MAX_VALUE are part of the standard library.

src/main/java/it/gov/pagopa/fdr/controller/middleware/filter/RequestFilter.java

src/main/java/it/gov/pagopa/fdr/controller/middleware/filter/ResponseFilter.java

src/main/java/it/gov/pagopa/fdr/controller/middleware/filter/RequestFilter.java

src/main/java/it/gov/pagopa/fdr/controller/middleware/filter/ResponseFilter.java

sonarqubecloud · 2025-08-01T09:33:47Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

…or RE

github-actions · 2025-08-01T12:53:10Z

This PR exceeds the recommended size of 400 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

aomegax

👍

pasqualespica

great work 🚀

andrea-deri added 3 commits July 31, 2025 12:50

[PIDM-590] feat: Including RE event storing for FdR3

42e73de

[PIDM-590] feat: Removing RE logging on internal APIs

8b668c1

[PIDM-590] feat: Including connection strings on Helm's env secrets

5eaa756

andrea-deri self-assigned this Jul 31, 2025

andrea-deri requested a review from a team as a code owner July 31, 2025 10:53

github-actions bot added patch size/large labels Jul 31, 2025

Bump to version 1.1.50-1-PIDM-590 [skip ci]

b86bb5e

github-advanced-security bot found potential problems Jul 31, 2025

View reviewed changes

andrea-deri and others added 2 commits July 31, 2025 13:53

[PIDM-590] feat: Including connection strings on Helm's env secret

8b96fa5

Bump to version 1.1.50-2-PIDM-590 [skip ci]

2e3cd86

andrea-deri temporarily deployed to dev July 31, 2025 12:42 — with GitHub Actions Inactive

andrea-deri temporarily deployed to dev July 31, 2025 13:27 — with GitHub Actions Inactive

andrea-deri added 2 commits August 1, 2025 11:03

[PIDM-590] fix: resolved various bugs on RE storage

64ee7fd

[PIDM-590] fix: resolving issues told by GH Copilot

bc7e5d6

github-advanced-security bot found potential problems Aug 1, 2025

View reviewed changes

[PIDM-590] fix: resolving issues told by GH Copilot

20a0bc1

github-advanced-security bot found potential problems Aug 1, 2025

View reviewed changes

src/main/java/it/gov/pagopa/fdr/controller/middleware/filter/RequestFilter.java Dismissed Show dismissed Hide dismissed

src/main/java/it/gov/pagopa/fdr/controller/middleware/filter/RequestFilter.java Dismissed Show dismissed Hide dismissed

[PIDM-590] fix: resolving issues told by GH Copilot

d064227

github-advanced-security bot found potential problems Aug 1, 2025

View reviewed changes

src/main/java/it/gov/pagopa/fdr/controller/middleware/filter/ResponseFilter.java Dismissed Show dismissed Hide dismissed

src/main/java/it/gov/pagopa/fdr/controller/middleware/filter/ResponseFilter.java Dismissed Show dismissed Hide dismissed

andrea-deri and others added 2 commits August 1, 2025 11:23

[PIDM-590] fix: resolving issues told by GH Copilot

3c5b2aa

Bump to version 1.1.50-3-PIDM-590 [skip ci]

351acd9

andrea-deri temporarily deployed to dev August 1, 2025 09:46 — with GitHub Actions Inactive

andrea-deri temporarily deployed to dev August 1, 2025 10:27 — with GitHub Actions Inactive

andrea-deri added 2 commits August 1, 2025 13:06

[PIDM-590] feat: including explicit exclusion of registered actions f…

61d3929

…or RE

[PIDM-590] feat: registering actions to be excluded from RE save

c9afbfd

pagopa-github-bot and others added 2 commits August 1, 2025 11:08

Bump to version 1.1.50-4-PIDM-590 [skip ci]

ffeaf75

[PIDM-590] fix: resolving partial exclusion of RE registration

b221823

Bump to version 1.1.50-5-PIDM-590 [skip ci]

581faa7

aomegax approved these changes Aug 4, 2025

View reviewed changes

pasqualespica approved these changes Aug 4, 2025

View reviewed changes

andrea-deri merged commit 22d3d99 into main Aug 4, 2025
5 of 6 checks passed

andrea-deri deleted the PIDM-590 branch August 4, 2025 13:00

@@ -75,2 +75,10 @@
+                // Validate that pageNumber and pageSize are within int range
+                if (pageNumber < Integer.MIN_VALUE || pageNumber > Integer.MAX_VALUE) {
+                  throw new IllegalArgumentException("pageNumber is out of int range: " + pageNumber);
+                }
+                if (pageSize < Integer.MIN_VALUE || pageSize > Integer.MAX_VALUE) {
+                  throw new IllegalArgumentException("pageSize is out of int range: " + pageSize);
+                }
                 log.debugf(
@@ -108,2 +116,10 @@
+                // Validate that pageNumber and pageSize are within int range
+                if (pageNumber < Integer.MIN_VALUE || pageNumber > Integer.MAX_VALUE) {
+                  throw new IllegalArgumentException("pageNumber is out of int range: " + pageNumber);
+                }
+                if (pageSize < Integer.MIN_VALUE || pageSize > Integer.MAX_VALUE) {
+                  throw new IllegalArgumentException("pageSize is out of int range: " + pageSize);
+                }
                 log.debugf(

feat: [PIDM-590] Introducing RE event persistence #136

feat: [PIDM-590] Introducing RE event persistence #136

Uh oh!

Conversation

andrea-deri commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Uh oh!

Copilot Autofix

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 1, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Aug 1, 2025

Uh oh!

aomegax left a comment

Choose a reason for hiding this comment

Uh oh!

pasqualespica left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

andrea-deri commented Jul 31, 2025 •

edited

Loading