Skip to content

feat: add organizationId as query param #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 2, 2025
Merged

feat: add organizationId as query param #138

merged 5 commits into from
Sep 2, 2025

Conversation

jacopocarlini
Copy link
Contributor

@jacopocarlini jacopocarlini commented Aug 18, 2025 •
edited
Loading

List of Changes

This PR add the organizationId as query param as a new filter

Motivation and Context

Jira issue

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link
Contributor

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@github-actions github-actions bot added the patch label Aug 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@github-actions GitHub Actions
Copy link
Contributor

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

@jacopocarlini jacopocarlini marked this pull request as ready for review August 19, 2025 08:11
@jacopocarlini jacopocarlini requested a review from a team as a code owner August 19, 2025 08:11
cap-ang
cap-ang requested changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I think the openapi update is missing

FedericoRuzzier
FedericoRuzzier reviewed Aug 28, 2025
View reviewed changes
pom.xml
<maven.compiler.release>17</maven.compiler.release>
<org.mapstruct.version>1.5.3.Final</org.mapstruct.version>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the changes to the maven compiler version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk, I suppose for IDE quirks. @jacopocarlini can tell us.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cap-ang cap-ang self-requested a review August 29, 2025 14:59
cap-ang
cap-ang approved these changes Aug 29, 2025
View reviewed changes
Copy link
Contributor

@cap-ang cap-ang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the change has been tested in UAT environment.

@jacopocarlini jacopocarlini merged commit 61f01e0 into main Sep 2, 2025
6 checks passed
@jacopocarlini jacopocarlini deleted the PAGOPA-3220-aca-sviluppo-caricamento-massivo branch September 2, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FedericoRuzzier FedericoRuzzier FedericoRuzzier left review comments

@cap-ang cap-ang cap-ang approved these changes

Assignees

@jacopocarlini jacopocarlini

Labels

patch size/small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jacopocarlini @FedericoRuzzier @cap-ang @pagopa-github-bot