-
Notifications
You must be signed in to change notification settings - Fork 1
[PAGOPA-2800] chore: Configure OTEL metrics exporter #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAGOPA-2800] chore: Configure OTEL metrics exporter #139
Conversation
The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually. |
This pull request does not contain a valid label. Please add one of the following labels: |
The default action is to increase the |
@jacopocarlini why rollback the change on log level? |
…800-fd-r-sampling-dei-log-su-ai-e-elk # Conflicts: # helm/Chart.yaml # helm/values-dev.yaml # helm/values-prod.yaml # helm/values-uat.yaml # openapi/openapi.json # pom.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but just a request. Could you provide a more detailed explanation in the PR description about why this PR is made? Also, could you provide a description about what OTEL_TRACES_SAMPLER
and OTEL_TRACES_SAMPLER_ARG
are and why they are set to "traceidratio"
and "0.5"
? These can save us time in the future if we need to trace past changes.
|
List of Changes
Motivation and Context
PAGOPA-2800
Enabled otel agent metrics exporter to improve monitoring via ELK stack.
Enabled sampling on traces to reduce load on ELK stack as requested by team infra.
OTEL_TRACES_SAMPLER
-> Defines the sampler to use for tracingOTEL_TRACES_SAMPLER_ARG
-> Defines the percentage of traces to be sampledhttps://quarkus.io/guides/opentelemetry-tracing#sampler
https://opentelemetry.io/docs/specs/otel/trace/sdk/#built-in-samplers
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
expected)
Checklist: