Skip to content

Conversation

jacopocarlini
Copy link
Contributor

@jacopocarlini jacopocarlini commented Aug 19, 2025

List of Changes

  • enabled OTEL metrics exporter

Motivation and Context

PAGOPA-2800
Enabled otel agent metrics exporter to improve monitoring via ELK stack.
Enabled sampling on traces to reduce load on ELK stack as requested by team infra.
OTEL_TRACES_SAMPLER -> Defines the sampler to use for tracing
OTEL_TRACES_SAMPLER_ARG -> Defines the percentage of traces to be sampled
https://quarkus.io/guides/opentelemetry-tracing#sampler
https://opentelemetry.io/docs/specs/otel/trace/sdk/#built-in-samplers

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jacopocarlini jacopocarlini requested a review from a team as a code owner August 19, 2025 15:05
Copy link
Contributor

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

Copy link
Contributor

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

Copy link
Contributor

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@gioelemella
Copy link
Collaborator

@jacopocarlini why rollback the change on log level?

@gioelemella gioelemella changed the title chore: set ERROR as log level [PAGOPA-2800] chore: set ERROR as log level Sep 2, 2025
@gioelemella gioelemella changed the title [PAGOPA-2800] chore: set ERROR as log level [PAGOPA-2800] chore: Configure OTEL metrics exporter Sep 4, 2025
@gioelemella gioelemella requested a review from aomegax September 4, 2025 13:07
gioelemella and others added 2 commits September 4, 2025 16:22
…800-fd-r-sampling-dei-log-su-ai-e-elk

# Conflicts:
#	helm/Chart.yaml
#	helm/values-dev.yaml
#	helm/values-prod.yaml
#	helm/values-uat.yaml
#	openapi/openapi.json
#	pom.xml
Copy link
Contributor

@andrea-deri andrea-deri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but just a request. Could you provide a more detailed explanation in the PR description about why this PR is made? Also, could you provide a description about what OTEL_TRACES_SAMPLER and OTEL_TRACES_SAMPLER_ARG are and why they are set to "traceidratio" and "0.5"? These can save us time in the future if we need to trace past changes.

@andrea-deri andrea-deri merged commit c89af95 into main Sep 15, 2025
12 checks passed
@andrea-deri andrea-deri deleted the PAGOPA-2800-fd-r-sampling-dei-log-su-ai-e-elk branch September 15, 2025 07:17
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants