chore: Add limit for pagination and flowDate #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually. |
|
The default action is to increase the |
|
This pull request does not contain a valid label. Please add one of the following labels: |
gioelemella
reviewed
Oct 6, 2025
src/main/java/it/gov/pagopa/fdr/controller/interfaces/controller/IOrganizationsController.java
Outdated
Show resolved
Hide resolved
src/main/java/it/gov/pagopa/fdr/controller/interfaces/controller/IOrganizationsController.java
Outdated
Show resolved
Hide resolved
…ery param and added constraint to publishedGt
…ery param and added constraint to publishedGt and updated openapi
…7-limit # Conflicts: # src/test/java/it/gov/pagopa/fdr/controller/organizations/OrganizationsControllerTest.java # src/test/java/it/gov/pagopa/fdr/test/util/TestUtil.java
Comment on lines
41
to
44
| Instant now = Instant.now(); | ||
| ZonedDateTime nowUtc = now.atZone(ZoneOffset.UTC); | ||
| ZonedDateTime limitZoned = nowUtc.minusMonths(1); | ||
| Instant defaultDate = limitZoned.toInstant(); |
There was a problem hiding this comment.
Can these 4 lines be compacted?
Comment on lines
29
to
30
| Instant now = Instant.now(); | ||
| ZonedDateTime nowUtc = now.atZone(ZoneOffset.UTC); |
Comment on lines
32
to
33
| ZonedDateTime limitZoned = nowUtc.minus(relativeValue, relativeUnit); | ||
| Instant limitDate = limitZoned.toInstant(); |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
flowDateandpublishedGtrequest params have now max 1 monthflowDateandpublishedGtrequest params default to previous month if not providedMotivation and Context
Added contraint to
GET /organizations/{organizationId}/fdrsAPI to avoid performance issueHow Has This Been Tested?
Screenshots (if appropriate):
Types of changes
expected)
Checklist: