Skip to content

fix: [PIDM-1032] Adding date check on new flows related to the latest revision #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 8, 2025
Merged

fix: [PIDM-1032] Adding date check on new flows related to the latest revision #146

merged 7 commits into from
Oct 8, 2025

Conversation

FedericoRuzzier
Copy link
Contributor

List of Changes

  • check that new date in request comes after last revision date

Motivation and Context

Needed in order to prevent psps to create new revision of same flow with same flowDate

How Has This Been Tested?

Through unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@FedericoRuzzier FedericoRuzzier requested a review from a team as a code owner October 7, 2025 10:13
@FedericoRuzzier FedericoRuzzier added bug Something isn't working patch labels Oct 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

The default action is to increase the PATCH number of SEMVER. Set IGNORE-FOR-RELEASE if you want to skip SEMVER bump. BREAKING-CHANGE and NEW-RELEASE must be run from GH Actions section manually.

@andrea-deri andrea-deri changed the base branch from main to next-release October 7, 2025 14:39
@andrea-deri andrea-deri changed the title fix: add date check with last revision PIDM-1032 fix [PIDM-1032]: Adding date check on new flows related to the latest revision Oct 8, 2025
@andrea-deri andrea-deri changed the title fix [PIDM-1032]: Adding date check on new flows related to the latest revision fix: [PIDM-1032] Adding date check on new flows related to the latest revision Oct 8, 2025
@andrea-deri andrea-deri mentioned this pull request Oct 8, 2025
Merged
5 tasks
andrea-deri
andrea-deri approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@andrea-deri andrea-deri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!
For JUnit tests fix, we provide another PR that resolve the issue.

@andrea-deri andrea-deri merged commit f13ece3 into next-release Oct 8, 2025
1 of 2 checks passed
@andrea-deri andrea-deri deleted the PIDM-1032 branch October 8, 2025 09:05
andrea-deri added a commit that referenced this pull request Oct 8, 2025
@andrea-deri @dylantangredi-jakala
@pagopa-github-bot @FedericoRuzzier
fix: Adding date checks on flow creation and deployment improvements (#…
b2cd2a5 
…148)

 - #145 
 - #146
 - #147

Co-authored-by: Dylan Tangredi <[email protected]>
Co-authored-by: pagopa-github-bot <[email protected]>
Co-authored-by: Federico Ruzzier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrea-deri andrea-deri andrea-deri approved these changes

Assignees

@FedericoRuzzier FedericoRuzzier

Labels

bug Something isn't working patch size/small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FedericoRuzzier @andrea-deri @pagopa-github-bot