Skip to content

[CHK-4708] feat: service settings add get api invocation#853

Merged
pietro-tota merged 10 commits intoCHK-4708-service-settings-add-api-invocationfrom
CHK-4708-service-settings-add-GET-api-invocation
Feb 10, 2026
Merged

[CHK-4708] feat: service settings add get api invocation#853
pietro-tota merged 10 commits intoCHK-4708-service-settings-add-api-invocationfrom
CHK-4708-service-settings-add-GET-api-invocation

Conversation

@CianoDanilo
Copy link
Contributor

@CianoDanilo CianoDanilo commented Feb 5, 2026 •
edited
Loading

This PR implements the frontend logic to manage service consents (specifically for RTP) for Creditor Institutions. It connects the UI to the backend endpoints to fetch the current status of services.

List of Changes

API Integration:
Integrated GET to fetch the list of services and their current consent status.

UI/UX Improvements:

  • Added Loading State (isLoadingList) with a CircularProgress spinner to prevent empty/flickering UI during data fetch.
  • Implemented Auto-refresh: The service list automatically refreshes after a successful update without reloading the page.
  • Added Error Handling: integrated Toast notifications for success and error scenarios.

Motivation and Context

How Has This Been Tested?

  • Login as an Admin for a Creditor Institution.
  • Navigate to the Services / Settings page.
  • Verify Loading: Observe the spinner while the data is being fetched.
  • After successfully saved a consent, refresh the page to check if the list of consents status fetched from the API is coherent.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@CianoDanilo CianoDanilo requested review from a team, gioelemella and svariant as code owners February 5, 2026 09:53
@CianoDanilo
Merge branch 'CHK-4708-service-settings-add-api-invocation' into CHK-…
426c47b 
…4708-service-settings-add-GET-api-invocation
@CianoDanilo
Merge branch 'CHK-4708-service-settings-add-api-invocation' into CHK-…
839e2c3 
…4708-service-settings-add-GET-api-invocation

# Conflicts:
#	src/pages/settings/SettingsPage.tsx
@CianoDanilo
Merge branch 'CHK-4708-service-settings-add-api-invocation' into CHK-…
80b15e2 
…4708-service-settings-add-GET-api-invocation

# Conflicts:
#	src/api/BackofficeClient.ts
pietro-tota
pietro-tota reviewed Feb 5, 2026
View reviewed changes
pietro-tota
pietro-tota reviewed Feb 5, 2026
View reviewed changes
pietro-tota and others added 3 commits February 6, 2026 09:22
@pietro-tota
Merge branch 'CHK-4708-service-settings-add-api-invocation' into CHK-…
31f0389 
…4708-service-settings-add-GET-api-invocation
@pietro-tota
Merge branch 'CHK-4708-service-settings-add-api-invocation' into CHK-…
a94eb74 
…4708-service-settings-add-GET-api-invocation
@pietro-tota @CianoDanilo
Chk 4708 unit tests (#855)
3a2b259 
* feat(wip): test

* chore: restore components

* chore: add missing import + early return

* chore: add error message

* feat: wip tests

* feat: test + page refactoring to help in test

* fix: tests

* chore: remove comment

* chore: lint

* fix: key stiles

* trigger CR pipeline

* chore: update can i use browser list

* chore: add test for errors

* [CHK-4708] feat(integration-test): add service settings page integration tests (#857)

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): refactor code

* feat(integration-test): refactor code

* feat: additional permission check to show components (#856)

* feat: additional permission check to show components

* chore: restore dummy value

* chore: enable service modification keys only for admins

* chore: code refactoring

* chore: fix test

* fix: test import

* feat: add tests

* trigger CR pipeline

* feat: add tests for institution service

* chore: remove unused import

* chore: add tests for coverage

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>
@pietro-tota pietro-tota merged commit 40ef126 into CHK-4708-service-settings-add-api-invocation Feb 10, 2026
5 checks passed
@github-actions github-actions bot deleted the CHK-4708-service-settings-add-GET-api-invocation branch February 10, 2026 10:30
pietro-tota added a commit that referenced this pull request Feb 10, 2026
@CianoDanilo @pietro-tota
[CHK-4708] feat: service settings add PUT consent api invocation (#852)
9677d38 
* feat(consent-api): add save consent API invocation on button click

* revert local env file

* feat(consent-api): fix ConsentEnum and Date usage

* feat(consent-api): lint

* feat(consent-api): update error title and description

* chore: merge modification + code refactoring

* [CHK-4708] feat: service settings add get api invocation (#853)

* feat(consent-api): add GET service consents API invocation

* feat(consent-api): update error title and description

* Chk 4708 unit tests (#855)

* feat(wip): test

* chore: restore components

* chore: add missing import + early return

* chore: add error message

* feat: wip tests

* feat: test + page refactoring to help in test

* fix: tests

* chore: remove comment

* chore: lint

* fix: key stiles

* trigger CR pipeline

* chore: update can i use browser list

* chore: add test for errors

* [CHK-4708] feat(integration-test): add service settings page integration tests (#857)

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): refactor code

* feat(integration-test): refactor code

* feat: additional permission check to show components (#856)

* feat: additional permission check to show components

* chore: restore dummy value

* chore: enable service modification keys only for admins

* chore: code refactoring

* chore: fix test

* fix: test import

* feat: add tests

* trigger CR pipeline

* feat: add tests for institution service

* chore: remove unused import

* chore: add tests for coverage

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>

---------

Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com>

---------

Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com>
Co-authored-by: pietro.tota <pietro.tota@pagopa.it>
pietro-tota added a commit that referenced this pull request Feb 10, 2026
@pietro-tota @CianoDanilo
feat: status chip calculation (#851)
265e2fe 
* feat: status chip calculation

* chore: code refactoring

* chore: code review

* chore: service enabling data

* chore: remove edit contacts button

* chore: activation date calculation

* fix: env variable name

* chore: code optimization

reduce to one modal instead of duplicating the same one
make use of react component instead of function invocation

* [CHK-4708] feat: service settings add PUT consent api invocation (#852)

* feat(consent-api): add save consent API invocation on button click

* revert local env file

* feat(consent-api): fix ConsentEnum and Date usage

* feat(consent-api): lint

* feat(consent-api): update error title and description

* chore: merge modification + code refactoring

* [CHK-4708] feat: service settings add get api invocation (#853)

* feat(consent-api): add GET service consents API invocation

* feat(consent-api): update error title and description

* Chk 4708 unit tests (#855)

* feat(wip): test

* chore: restore components

* chore: add missing import + early return

* chore: add error message

* feat: wip tests

* feat: test + page refactoring to help in test

* fix: tests

* chore: remove comment

* chore: lint

* fix: key stiles

* trigger CR pipeline

* chore: update can i use browser list

* chore: add test for errors

* [CHK-4708] feat(integration-test): add service settings page integration tests (#857)

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): refactor code

* feat(integration-test): refactor code

* feat: additional permission check to show components (#856)

* feat: additional permission check to show components

* chore: restore dummy value

* chore: enable service modification keys only for admins

* chore: code refactoring

* chore: fix test

* fix: test import

* feat: add tests

* trigger CR pipeline

* feat: add tests for institution service

* chore: remove unused import

* chore: add tests for coverage

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>

---------

Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com>

---------

Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com>
Co-authored-by: pietro.tota <pietro.tota@pagopa.it>

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>
pietro-tota added a commit that referenced this pull request Feb 10, 2026
@pietro-tota @CianoDanilo
feat: popup messages (#850)
6c22912 
* empty

* feat: add popup + use trans for links

* feat: popup menus

* chore: dummy jwt token

* feat: add info alert

* chore: add translations

* feat: add loader

* chore: add TODO message

* feat: add state changer + mock update action

* feat: status chip calculation (#851)

* feat: status chip calculation

* chore: code refactoring

* chore: code review

* chore: service enabling data

* chore: remove edit contacts button

* chore: activation date calculation

* fix: env variable name

* chore: code optimization

reduce to one modal instead of duplicating the same one
make use of react component instead of function invocation

* [CHK-4708] feat: service settings add PUT consent api invocation (#852)

* feat(consent-api): add save consent API invocation on button click

* revert local env file

* feat(consent-api): fix ConsentEnum and Date usage

* feat(consent-api): lint

* feat(consent-api): update error title and description

* chore: merge modification + code refactoring

* [CHK-4708] feat: service settings add get api invocation (#853)

* feat(consent-api): add GET service consents API invocation

* feat(consent-api): update error title and description

* Chk 4708 unit tests (#855)

* feat(wip): test

* chore: restore components

* chore: add missing import + early return

* chore: add error message

* feat: wip tests

* feat: test + page refactoring to help in test

* fix: tests

* chore: remove comment

* chore: lint

* fix: key stiles

* trigger CR pipeline

* chore: update can i use browser list

* chore: add test for errors

* [CHK-4708] feat(integration-test): add service settings page integration tests (#857)

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): refactor code

* feat(integration-test): refactor code

* feat: additional permission check to show components (#856)

* feat: additional permission check to show components

* chore: restore dummy value

* chore: enable service modification keys only for admins

* chore: code refactoring

* chore: fix test

* fix: test import

* feat: add tests

* trigger CR pipeline

* feat: add tests for institution service

* chore: remove unused import

* chore: add tests for coverage

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>

---------

Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com>

---------

Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com>
Co-authored-by: pietro.tota <pietro.tota@pagopa.it>

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-853.westeurope.5.azurestaticapps.net

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 10, 2026

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

pietro-tota added a commit that referenced this pull request Feb 11, 2026
@pietro-tota @CianoDanilo @pagopa-github-bot
feat: add settings menu (#849)
0836f94 
* feat: add settings menu

* wip: setting page

* wip: settings page

* chore: revert perm

* fix: text

* Add alert title and description

* wip

* chore: restore condition

* wip: setting menu

* chore: add ff

* feat: add ff

* chore: use link component + eslint

* chore: refactoring

* chore: remove log

* feat: popup messages (#850)

* empty

* feat: add popup + use trans for links

* feat: popup menus

* chore: dummy jwt token

* feat: add info alert

* chore: add translations

* feat: add loader

* chore: add TODO message

* feat: add state changer + mock update action

* feat: status chip calculation (#851)

* feat: status chip calculation

* chore: code refactoring

* chore: code review

* chore: service enabling data

* chore: remove edit contacts button

* chore: activation date calculation

* fix: env variable name

* chore: code optimization

reduce to one modal instead of duplicating the same one
make use of react component instead of function invocation

* [CHK-4708] feat: service settings add PUT consent api invocation (#852)

* feat(consent-api): add save consent API invocation on button click

* revert local env file

* feat(consent-api): fix ConsentEnum and Date usage

* feat(consent-api): lint

* feat(consent-api): update error title and description

* chore: merge modification + code refactoring

* [CHK-4708] feat: service settings add get api invocation (#853)

* feat(consent-api): add GET service consents API invocation

* feat(consent-api): update error title and description

* Chk 4708 unit tests (#855)

* feat(wip): test

* chore: restore components

* chore: add missing import + early return

* chore: add error message

* feat: wip tests

* feat: test + page refactoring to help in test

* fix: tests

* chore: remove comment

* chore: lint

* fix: key stiles

* trigger CR pipeline

* chore: update can i use browser list

* chore: add test for errors

* [CHK-4708] feat(integration-test): add service settings page integration tests (#857)

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): add service settings page integration tests

* feat(integration-test): remove only

* feat(integration-test): refactor code

* feat(integration-test): refactor code

* feat: additional permission check to show components (#856)

* feat: additional permission check to show components

* chore: restore dummy value

* chore: enable service modification keys only for admins

* chore: code refactoring

* chore: fix test

* fix: test import

* feat: add tests

* trigger CR pipeline

* feat: add tests for institution service

* chore: remove unused import

* chore: add tests for coverage

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>

---------

Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com>

---------

Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com>
Co-authored-by: pietro.tota <pietro.tota@pagopa.it>

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>

---------

Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>

* Bump to version 1.46.0-1-CHK-4708-service-settings-section [skip ci]

* fix: add org is ec and broker to check

---------

Co-authored-by: danilo.ciano <danilo.ciano@pagopa.it>
Co-authored-by: pagopa-github-bot <github-bot@pagopa.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pietro-tota pietro-tota pietro-tota approved these changes

@svariant svariant Awaiting requested review from svariant

@gioelemella gioelemella Awaiting requested review from gioelemella

Assignees

@CianoDanilo CianoDanilo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CianoDanilo @pietro-tota