Chk 4708 unit tests#855
Merged
pietro-tota merged 17 commits intoCHK-4708-service-settings-add-GET-api-invocationfrom Feb 10, 2026
Merged
Chk 4708 unit tests#855pietro-tota merged 17 commits intoCHK-4708-service-settings-add-GET-api-invocationfrom
pietro-tota merged 17 commits intoCHK-4708-service-settings-add-GET-api-invocationfrom
Conversation
pietro-tota
requested review from
a team,
gioelemella and
svariant
as code owners
…CHK-4708-unit-tests
…T-api-invocation' into CHK-4708-unit-tests # Conflicts: # src/pages/settings/components/ServiceSettingsCard.tsx
5 tasks
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-855.westeurope.5.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-855.westeurope.5.azurestaticapps.net |
CianoDanilo
approved these changes
Feb 10, 2026
…ion tests (#857) * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): refactor code * feat(integration-test): refactor code
* feat: additional permission check to show components * chore: restore dummy value * chore: enable service modification keys only for admins * chore: code refactoring * chore: fix test * fix: test import * feat: add tests * trigger CR pipeline * feat: add tests for institution service * chore: remove unused import * chore: add tests for coverage
pietro-tota
merged commit 3a2b259
into
CHK-4708-service-settings-add-GET-api-invocation
5 checks passed
pietro-tota
added a commit
that referenced
this pull request
Feb 10, 2026
* feat(consent-api): add GET service consents API invocation * feat(consent-api): update error title and description * Chk 4708 unit tests (#855) * feat(wip): test * chore: restore components * chore: add missing import + early return * chore: add error message * feat: wip tests * feat: test + page refactoring to help in test * fix: tests * chore: remove comment * chore: lint * fix: key stiles * trigger CR pipeline * chore: update can i use browser list * chore: add test for errors * [CHK-4708] feat(integration-test): add service settings page integration tests (#857) * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): refactor code * feat(integration-test): refactor code * feat: additional permission check to show components (#856) * feat: additional permission check to show components * chore: restore dummy value * chore: enable service modification keys only for admins * chore: code refactoring * chore: fix test * fix: test import * feat: add tests * trigger CR pipeline * feat: add tests for institution service * chore: remove unused import * chore: add tests for coverage --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it> --------- Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com>
pietro-tota
added a commit
that referenced
this pull request
Feb 10, 2026
* feat(consent-api): add save consent API invocation on button click * revert local env file * feat(consent-api): fix ConsentEnum and Date usage * feat(consent-api): lint * feat(consent-api): update error title and description * chore: merge modification + code refactoring * [CHK-4708] feat: service settings add get api invocation (#853) * feat(consent-api): add GET service consents API invocation * feat(consent-api): update error title and description * Chk 4708 unit tests (#855) * feat(wip): test * chore: restore components * chore: add missing import + early return * chore: add error message * feat: wip tests * feat: test + page refactoring to help in test * fix: tests * chore: remove comment * chore: lint * fix: key stiles * trigger CR pipeline * chore: update can i use browser list * chore: add test for errors * [CHK-4708] feat(integration-test): add service settings page integration tests (#857) * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): refactor code * feat(integration-test): refactor code * feat: additional permission check to show components (#856) * feat: additional permission check to show components * chore: restore dummy value * chore: enable service modification keys only for admins * chore: code refactoring * chore: fix test * fix: test import * feat: add tests * trigger CR pipeline * feat: add tests for institution service * chore: remove unused import * chore: add tests for coverage --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it> --------- Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com> --------- Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com> Co-authored-by: pietro.tota <pietro.tota@pagopa.it>
pietro-tota
added a commit
that referenced
this pull request
Feb 10, 2026
* feat: status chip calculation * chore: code refactoring * chore: code review * chore: service enabling data * chore: remove edit contacts button * chore: activation date calculation * fix: env variable name * chore: code optimization reduce to one modal instead of duplicating the same one make use of react component instead of function invocation * [CHK-4708] feat: service settings add PUT consent api invocation (#852) * feat(consent-api): add save consent API invocation on button click * revert local env file * feat(consent-api): fix ConsentEnum and Date usage * feat(consent-api): lint * feat(consent-api): update error title and description * chore: merge modification + code refactoring * [CHK-4708] feat: service settings add get api invocation (#853) * feat(consent-api): add GET service consents API invocation * feat(consent-api): update error title and description * Chk 4708 unit tests (#855) * feat(wip): test * chore: restore components * chore: add missing import + early return * chore: add error message * feat: wip tests * feat: test + page refactoring to help in test * fix: tests * chore: remove comment * chore: lint * fix: key stiles * trigger CR pipeline * chore: update can i use browser list * chore: add test for errors * [CHK-4708] feat(integration-test): add service settings page integration tests (#857) * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): refactor code * feat(integration-test): refactor code * feat: additional permission check to show components (#856) * feat: additional permission check to show components * chore: restore dummy value * chore: enable service modification keys only for admins * chore: code refactoring * chore: fix test * fix: test import * feat: add tests * trigger CR pipeline * feat: add tests for institution service * chore: remove unused import * chore: add tests for coverage --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it> --------- Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com> --------- Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com> Co-authored-by: pietro.tota <pietro.tota@pagopa.it> --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>
pietro-tota
added a commit
that referenced
this pull request
Feb 10, 2026
* empty * feat: add popup + use trans for links * feat: popup menus * chore: dummy jwt token * feat: add info alert * chore: add translations * feat: add loader * chore: add TODO message * feat: add state changer + mock update action * feat: status chip calculation (#851) * feat: status chip calculation * chore: code refactoring * chore: code review * chore: service enabling data * chore: remove edit contacts button * chore: activation date calculation * fix: env variable name * chore: code optimization reduce to one modal instead of duplicating the same one make use of react component instead of function invocation * [CHK-4708] feat: service settings add PUT consent api invocation (#852) * feat(consent-api): add save consent API invocation on button click * revert local env file * feat(consent-api): fix ConsentEnum and Date usage * feat(consent-api): lint * feat(consent-api): update error title and description * chore: merge modification + code refactoring * [CHK-4708] feat: service settings add get api invocation (#853) * feat(consent-api): add GET service consents API invocation * feat(consent-api): update error title and description * Chk 4708 unit tests (#855) * feat(wip): test * chore: restore components * chore: add missing import + early return * chore: add error message * feat: wip tests * feat: test + page refactoring to help in test * fix: tests * chore: remove comment * chore: lint * fix: key stiles * trigger CR pipeline * chore: update can i use browser list * chore: add test for errors * [CHK-4708] feat(integration-test): add service settings page integration tests (#857) * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): refactor code * feat(integration-test): refactor code * feat: additional permission check to show components (#856) * feat: additional permission check to show components * chore: restore dummy value * chore: enable service modification keys only for admins * chore: code refactoring * chore: fix test * fix: test import * feat: add tests * trigger CR pipeline * feat: add tests for institution service * chore: remove unused import * chore: add tests for coverage --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it> --------- Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com> --------- Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com> Co-authored-by: pietro.tota <pietro.tota@pagopa.it> --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it> --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it>
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-island-050778e03-855.westeurope.5.azurestaticapps.net |
|
pietro-tota
added a commit
that referenced
this pull request
Feb 11, 2026
* feat: add settings menu * wip: setting page * wip: settings page * chore: revert perm * fix: text * Add alert title and description * wip * chore: restore condition * wip: setting menu * chore: add ff * feat: add ff * chore: use link component + eslint * chore: refactoring * chore: remove log * feat: popup messages (#850) * empty * feat: add popup + use trans for links * feat: popup menus * chore: dummy jwt token * feat: add info alert * chore: add translations * feat: add loader * chore: add TODO message * feat: add state changer + mock update action * feat: status chip calculation (#851) * feat: status chip calculation * chore: code refactoring * chore: code review * chore: service enabling data * chore: remove edit contacts button * chore: activation date calculation * fix: env variable name * chore: code optimization reduce to one modal instead of duplicating the same one make use of react component instead of function invocation * [CHK-4708] feat: service settings add PUT consent api invocation (#852) * feat(consent-api): add save consent API invocation on button click * revert local env file * feat(consent-api): fix ConsentEnum and Date usage * feat(consent-api): lint * feat(consent-api): update error title and description * chore: merge modification + code refactoring * [CHK-4708] feat: service settings add get api invocation (#853) * feat(consent-api): add GET service consents API invocation * feat(consent-api): update error title and description * Chk 4708 unit tests (#855) * feat(wip): test * chore: restore components * chore: add missing import + early return * chore: add error message * feat: wip tests * feat: test + page refactoring to help in test * fix: tests * chore: remove comment * chore: lint * fix: key stiles * trigger CR pipeline * chore: update can i use browser list * chore: add test for errors * [CHK-4708] feat(integration-test): add service settings page integration tests (#857) * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): add service settings page integration tests * feat(integration-test): remove only * feat(integration-test): refactor code * feat(integration-test): refactor code * feat: additional permission check to show components (#856) * feat: additional permission check to show components * chore: restore dummy value * chore: enable service modification keys only for admins * chore: code refactoring * chore: fix test * fix: test import * feat: add tests * trigger CR pipeline * feat: add tests for institution service * chore: remove unused import * chore: add tests for coverage --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it> --------- Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com> --------- Co-authored-by: Pietro Tota <115724836+pietro-tota@users.noreply.github.com> Co-authored-by: pietro.tota <pietro.tota@pagopa.it> --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it> --------- Co-authored-by: CianoDanilo <danilo.ciano@pagopa.it> * Bump to version 1.46.0-1-CHK-4708-service-settings-section [skip ci] * fix: add org is ec and broker to check --------- Co-authored-by: danilo.ciano <danilo.ciano@pagopa.it> Co-authored-by: pagopa-github-bot <github-bot@pagopa.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of Changes
Add junit tests
Motivation and Context
Add tests to check all parts rendering and gain code coverage
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
expected)
Checklist: