Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: pagopa-selfcare-ms-backoffice
description: Microservice that manage api keys for pagopa product from selfcare
type: application
version: 0.511.0
appVersion: "2.43.1"
version: 0.512.0
appVersion: "2.43.1-1-PIDM-1487-fix-empty-cbill"
dependencies:
- name: microservice-chart
version: 7.5.0
Expand Down
2 changes: 1 addition & 1 deletion helm/values-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ microservice-chart:
fullnameOverride: ""
image:
repository: ghcr.io/pagopa/pagopa-selfcare-ms-backoffice-backend
tag: "2.43.1"
tag: "2.43.1-1-PIDM-1487-fix-empty-cbill"
pullPolicy: Always
livenessProbe:
httpGet:
Expand Down
2 changes: 1 addition & 1 deletion helm/values-prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ microservice-chart:
fullnameOverride: ""
image:
repository: ghcr.io/pagopa/pagopa-selfcare-ms-backoffice-backend
tag: "2.43.1" #improve
tag: "2.43.1-1-PIDM-1487-fix-empty-cbill" #improve
pullPolicy: Always
livenessProbe:
httpGet:
Expand Down
2 changes: 1 addition & 1 deletion helm/values-uat.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ microservice-chart:
fullnameOverride: ""
image:
repository: ghcr.io/pagopa/pagopa-selfcare-ms-backoffice-backend
tag: "2.43.1" #improve
tag: "2.43.1-1-PIDM-1487-fix-empty-cbill" #improve
pullPolicy: Always
livenessProbe:
httpGet:
Expand Down
2 changes: 1 addition & 1 deletion openapi/openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Microservice to manage PagoPA Backoffice",
"termsOfService": "https://www.pagopa.gov.it/",
"title": "SelfCare Backoffice",
"version": "2.43.1"
"version": "2.43.1-1-PIDM-1487-fix-empty-cbill"
},
"servers": [
{
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<version>2.7.10</version>
</parent>
<artifactId>pagopa-selfcare-ms-backoffice</artifactId>
<version>2.43.1</version>
<version>2.43.1-1-PIDM-1487-fix-empty-cbill</version>
<name>SelfCare Backoffice</name>
<description>Microservice to manage PagoPA Backoffice</description>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ public CreditorInstitutionDetails fromDto(UpdateCreditorInstitutionDto dto) {
creditorInstitutionDetails.setCreditorInstitutionCode(dto.getCreditorInstitutionCode());
creditorInstitutionDetails.setEnabled(dto.getEnabled());
creditorInstitutionDetails.setBusinessName(dto.getBusinessName());
creditorInstitutionDetails.setCbillCode(dto.getCbillCode());
creditorInstitutionDetails.setAddress(fromDto(dto.getAddress()));
creditorInstitutionDetails.setPspPayment(dto.getPspPayment());
creditorInstitutionDetails.setReportingFtp(dto.getReportingFtp());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,20 @@ void updateCreditorInstitution_ok() throws IOException {
assertNotNull(result);
}

@Test
void updateCreditorInstitution_shouldPreserveCbillCode() throws IOException {
when(apiConfigClient.updateCreditorInstitutionDetails(anyString(), any(CreditorInstitutionDetails.class)))
.thenAnswer(invocation -> invocation.getArgument(1));

UpdateCreditorInstitutionDto dto = TestUtil.fileToObject("request/post_creditor_institution.json", UpdateCreditorInstitutionDto.class);
assertEquals("COXYZ", dto.getCbillCode(), "Test fixture should have cbillCode");

CreditorInstitutionDetailsResource result = service.updateCreditorInstitutionDetails(CI_TAX_CODE, dto);

assertNotNull(result);
assertEquals("COXYZ", result.getCbillCode(), "cbillCode must be preserved through the update mapper");
}

@Test
void updateCreditorInstitution_ko() throws IOException {
FeignException feignException = mock(FeignException.InternalServerError.class);
Expand Down