Skip to content

feature/PIN-8817: add chance to choose how many element user can see within list #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
borgesis95 merged 11 commits into from
Feb 4, 2026
Merged

feature/PIN-8817: add chance to choose how many element user can see within list #1609

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7706a9a
feat: add items for pages
antofo Jan 5, 2026
188214c
feat(pin-8817): merge develop
antofo Jan 12, 2026
a40fdff
feat(pin-8817): fix elements for page behaviour
antofo Jan 13, 2026
34a0115
Merge branch 'dev' into feature/pin-8817-elements-per-page
antofo Jan 27, 2026
960dcb7
feat(pin-8817): minor fix
antofo Jan 27, 2026
96301d2
feat(pin-8817): get the rowPerPageOptions from usePagination
antofo Jan 28, 2026
8f9e819
Merge branch 'dev' into feature/pin-8817-elements-per-page
antofo Feb 2, 2026
ed39d05
feat(pin-8817): add limitOptions to usePagination
antofo Feb 2, 2026
84f3e2d
chore: update interop-fe-common
borgesis95 Feb 2, 2026
f7fc747
feat(pin-8817): remove limit change from documentation drawer
antofo Feb 2, 2026
b6e1485
chore: fix problem raised
borgesis95 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@mui/material": "^5.16.14",
"@mui/system": "^5.14.9",
"@mui/x-date-pickers": "^6.13.0",
"@pagopa/interop-fe-commons": "^1.4.6",
"@pagopa/interop-fe-commons": "^1.5.0",
"@pagopa/mui-italia": "^1.8.0",
"@tanstack/react-query": "^5.51.4",
"@tanstack/react-query-devtools": "^5.51.4",
Expand Down
6 changes: 5 additions & 1 deletion src/components/shared/ClientTable/ClientTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ type ClientTableProps = {

export const ClientTable: React.FC<ClientTableProps> = ({ clientKind }) => {
const { t } = useTranslation('client', { keyPrefix: 'list.filters' })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()
const { filtersParams, ...handlers } = useFilters([
{ name: 'q', type: 'freetext', label: t('nameField.label') },
])
Expand All @@ -36,6 +36,10 @@ export const ClientTable: React.FC<ClientTableProps> = ({ clientKind }) => {
</Suspense>
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={getTotalPageCount(clients?.pagination.totalCount)}
/>
</>
Expand Down
5 changes: 5 additions & 0 deletions src/components/shared/EserviceTemplate/EServiceTemplateUpdateDocumentationDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@ export const EServiceTemplateUpdateDocumentationDrawer: React.FC<
})}
<Pagination
{...paginationProps}
rowPerPageOptions={{
options: [3, 6, 9],
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={getTotalPageCount(docs.length)}
justifyContent="center"
alignItems="flex-end"
Expand Down
6 changes: 5 additions & 1 deletion src/components/shared/KeychainsTable/KeychainsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { AuthHooks } from '@/api/auth'

export const KeychainsTable: React.FC = () => {
const { t } = useTranslation('keychain', { keyPrefix: 'list.filters' })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()
const { jwt } = AuthHooks.useJwt()

const producerId = jwt?.organizationId as string
Expand Down Expand Up @@ -37,6 +37,10 @@ export const KeychainsTable: React.FC = () => {
</Suspense>
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={getTotalPageCount(keychains?.pagination.totalCount)}
/>
</>
Expand Down
6 changes: 5 additions & 1 deletion ...eTemplate/PurposeTemplateLinkedEServiceTab/ConsumerPurposeTemplateLinkedEServiceTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const ConsumerPurposeTemplateLinkedEServiceTable: React.FC<
})),
})

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()

const { filtersParams, ...filtersHandlers } = useFilters<
Omit<GetPurposeTemplateEServicesParams, 'limit' | 'offset' | 'purposeTemplateId'>
Expand Down Expand Up @@ -94,6 +94,10 @@ export const ConsumerPurposeTemplateLinkedEServiceTable: React.FC<
</Table>
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={getTotalPageCount(
eserviceDescriptorsPurposeTemplateList!.pagination.totalCount
)}
Expand Down
6 changes: 5 additions & 1 deletion src/pages/ConsumerAgreementsListPage/ConsumerAgreementsList.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const ConsumerAgreementsListPage: React.FC = () => {
})),
})

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()
const { filtersParams, ...filtersHandlers } = useFilters<
Omit<GetConsumerAgreementsParams, 'limit' | 'offset'>
>([
Expand Down Expand Up @@ -103,6 +103,10 @@ const ConsumerAgreementsListPage: React.FC = () => {
<ConsumerAgreementsTableWrapper params={params} />
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={getTotalPageCount(data?.pagination.totalCount)}
/>
</PageContainer>
Expand Down
11 changes: 9 additions & 2 deletions src/pages/ConsumerClientManagePage/components/ClientPublicKeys/ClientPublicKeys.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const ClientPublicKeys: React.FC<ClientPublicKeysProps> = ({ clientId })
},
])

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()

const queryParams = {
...filtersParams,
Expand All @@ -59,7 +59,14 @@ export const ClientPublicKeys: React.FC<ClientPublicKeysProps> = ({ clientId })
<Filters {...filtersHandlers} />
<React.Suspense fallback={<ClientPublicKeysTableSkeleton />}>
<ClientPublicKeysWrapper params={queryParams} />
<Pagination {...paginationProps} totalPages={totalPageCount} />
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={totalPageCount}
/>
</React.Suspense>
</>
)
Expand Down
11 changes: 9 additions & 2 deletions ...ge/components/ConsumerLinkedPurposeTemplatesTab.tsx/ConsumerLinkedPurposeTemplatesTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const ConsumerLinkedPurposeTemplatesTab: React.FC = () => {
},
])

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()

// Ensure eserviceId is always present in query params
const queryParams: GetCatalogPurposeTemplatesParams = {
Expand Down Expand Up @@ -92,7 +92,14 @@ const ConsumerLinkedPurposeTemplatesTab: React.FC = () => {
>
<Filters {...filtersHandlers} />
<ConsumerLinkedPurposeTemplatesTableWrapper params={queryParams} />
<Pagination {...paginationProps} totalPages={totalPageCount} />
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={totalPageCount}
/>
</SectionContainer>
</>
)
Expand Down
6 changes: 5 additions & 1 deletion src/pages/ConsumerPurposeTemplateListPage/ConsumerPurposeTemplateList.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ const ConsumerPurposeTemplateListPage: React.FC = () => {
},
])

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()
const queryParams = { ...paginationParams, ...filtersParams }

const { data } = useQuery({
Expand All @@ -147,6 +147,10 @@ const ConsumerPurposeTemplateListPage: React.FC = () => {
<PurposeTemplateTableWrapper data={data} />
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={getTotalPageCount(data?.pagination.totalCount)}
/>
</PageContainer>
Expand Down
11 changes: 9 additions & 2 deletions src/pages/ConsumerPurposesListPage/ConsumerPurposesList.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const ConsumerPurposesListPage: React.FC = () => {
})),
})

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()
const { filtersParams, ...filtersHandlers } = useFilters<
Omit<GetConsumerPurposesParams, 'limit' | 'offset'>
>([
Expand Down Expand Up @@ -137,7 +137,14 @@ const ConsumerPurposesListPage: React.FC = () => {
>
<Filters {...filtersHandlers} />
<PurposesTableWrapper params={params} />
<Pagination {...paginationProps} totalPages={totalPages} />
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={totalPages}
/>
</PageContainer>
)
}
Expand Down
11 changes: 9 additions & 2 deletions src/pages/DelegationsPage/DelegationsGrantedTab/DelegationsGrantedTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const DelegationsGrantedTab: React.FC = () => {
const { isAdmin, jwt } = AuthHooks.useJwt()
const currentUserOrganizationId = jwt?.organizationId

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()

const defaultParams: Pick<GetDelegationsParams, 'delegatorIds'> = {
delegatorIds: [currentUserOrganizationId as string],
Expand Down Expand Up @@ -53,7 +53,14 @@ export const DelegationsGrantedTab: React.FC = () => {
<React.Suspense fallback={<DelegationsTableSkeleton delegationType="DELEGATION_GRANTED" />}>
<DelegationsTable delegationType="DELEGATION_GRANTED" params={queryParams} />
</React.Suspense>
<Pagination {...paginationProps} totalPages={totalPageCount} />
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={totalPageCount}
/>
</>
)
}
11 changes: 9 additions & 2 deletions src/pages/DelegationsPage/components/DelegationsReceivedTab/DelegationsReceivedTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { DelegationQueries } from '@/api/delegation'

export const DelegationsReceivedTab: React.FC = () => {
const { jwt } = AuthHooks.useJwt()
const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()

const params: GetDelegationsParams = {
...paginationParams,
Expand All @@ -32,7 +32,14 @@ export const DelegationsReceivedTab: React.FC = () => {
>
<DelegationsTable params={params} delegationType={'DELEGATION_RECEIVED'} />
</React.Suspense>
<Pagination {...paginationProps} totalPages={totalPageCount} />
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={totalPageCount}
/>
</>
)
}
11 changes: 9 additions & 2 deletions src/pages/NotificationsPage/Notifications.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ const NotificationsPage: React.FC = () => {
},
])

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()
const queryParams = { ...paginationParams, ...filtersParams }

const { data: totalPageCount = 0, isLoading } = useQuery({
Expand Down Expand Up @@ -96,7 +96,14 @@ const NotificationsPage: React.FC = () => {
<>
<Filters {...filtersHandlers} />
<NotificationsTableWrapper params={params} />
<Pagination {...paginationProps} totalPages={totalPageCount} />
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={totalPageCount}
/>
</>
))
.with({ isLoading: false, hasData: false }, () => (
Expand Down
6 changes: 5 additions & 1 deletion src/pages/ProviderAgreementsListPage/ProviderAgreementsList.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const ProviderAgreementsListPage: React.FC = () => {
})),
})

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()
const { filtersParams, ...filtersHandlers } = useFilters<
Omit<GetProducerAgreementsParams, 'limit' | 'offset'>
>([
Expand Down Expand Up @@ -97,6 +97,10 @@ const ProviderAgreementsListPage: React.FC = () => {
<ProviderAgreementsTableWrapper params={params} />
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={getTotalPageCount(data?.pagination.totalCount)}
/>
</PageContainer>
Expand Down
5 changes: 5 additions & 0 deletions ...ilsTab/ProviderEServiceTechnicalInfoSection/ProviderEServiceUpdateDocumentationDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,11 @@ export const ProviderEServiceUpdateDocumentationDrawer: React.FC<
})}
<Pagination
{...paginationProps}
rowPerPageOptions={{
options: [3, 6, 9],
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={getTotalPageCount(docs.length)}
justifyContent="center"
alignItems="flex-end"
Expand Down
6 changes: 5 additions & 1 deletion ...iceDetailsPage/components/ProviderEServiceKeychainsTab/ProviderEServiceKeychainsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ type ProviderEServiceKeychainsTableProps = {
export const ProviderEServiceKeychainsTable: React.FC<ProviderEServiceKeychainsTableProps> = ({
eserviceId,
}) => {
const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()

const params: GetProducerKeychainsParams = {
eserviceId: eserviceId,
Expand All @@ -35,6 +35,10 @@ export const ProviderEServiceKeychainsTable: React.FC<ProviderEServiceKeychainsT
</React.Suspense>
<Pagination
{...paginationProps}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={getTotalPageCount(associatedKeychainsTotalCount)}
/>
</>
Expand Down
13 changes: 11 additions & 2 deletions src/pages/ProviderEServiceListPage/ProviderEServiceList.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ const ProviderEServiceListPage: React.FC = () => {
})),
})

const { paginationParams, paginationProps, getTotalPageCount } = usePagination({ limit: 10 })
const { paginationParams, paginationProps, getTotalPageCount } = usePagination()

const { filtersParams, ...filtersHandlers } = useFilters<
Omit<GetProducerEServicesParams, 'limit' | 'offset'>
>([
Expand Down Expand Up @@ -85,7 +86,15 @@ const ProviderEServiceListPage: React.FC = () => {
>
<Filters {...filtersHandlers} />
<EServiceTableWrapper params={queryParams} />
<Pagination {...paginationProps} totalPages={totalPageCount} />
<Pagination
pageNum={paginationProps.pageNum}
onPageChange={paginationProps.onPageChange}
rowPerPageOptions={{
onLimitChange: paginationProps.onLimitChange,
limit: paginationParams.limit,
}}
totalPages={totalPageCount}
/>
<ProviderEServiceImportVersionDrawer isOpen={isOpen} onClose={closeDrawer} />
</PageContainer>
)
Expand Down
Loading
Loading