hotfix: resolve bug multiple agreements management in eservice page (PIN-7381)#1641
Merged
borgesis95 merged 36 commits intodevfrom Feb 6, 2026
Conversation
alten-dturus
requested review from
Alepazz,
Carminepo2,
borgesis95 and
ruggerocastagnola
as code owners
Alepazz
requested changes
Jan 29, 2026
Collaborator
Alepazz
left a comment
Alepazz
left a comment
There was a problem hiding this comment.
Could you please add a brief description and the Jira ticket reference to the PR description?
Regarding the fix, I found three small issues
...mponents/dialogs/DialogSelectAgreementConsumer/DialogSelectAgreementConsumerAutocomplete.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/DialogSelectAgreementConsumer/DialogSelectAgreementConsumer.tsx
Show resolved
Hide resolved
...mponents/dialogs/DialogSelectAgreementConsumer/DialogSelectAgreementConsumerAutocomplete.tsx
Outdated
Show resolved
Hide resolved
Alepazz
approved these changes
Feb 2, 2026
…ts-management-in-eservice-page
…check on create draft button
borgesis95
reviewed
Feb 4, 2026
src/components/dialogs/DialogCreateAgreementDraft/DialogCreateAgreementDraft.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/DialogCreateAgreementDraft/DialogCreateAgreementDraft.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/DialogCreateAgreementDraft/DialogCreateAgreementDraft.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/DialogCreateAgreementDraft/DialogCreateAgreementDraftAutocomplete.tsx
Outdated
Show resolved
Hide resolved
src/components/dialogs/DialogSelectAgreementConsumer/DialogSelectAgreementConsumer.tsx
Outdated
Show resolved
Hide resolved
and removed DialogCreateAgreementDraft and its component
borgesis95
reviewed
Feb 6, 2026
src/components/dialogs/DialogSelectAgreementConsumer/DialogSelectAgreementConsumer.tsx
Outdated
Show resolved
Hide resolved
|
borgesis95
approved these changes
Feb 6, 2026
borgesis95
deleted the
hotfix/PIN-7381_resolve-bug-multiple-agreements-management-in-eservice-page
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Contesto / Perché
The hook that return the actions for the eservice details page had no way to return multiple actions and did not take into account the possibility of multiple agreement (created via delegations). Now it can manage all the cases where there are multiple agreements in different states