PIN-9106 adjust new eservice step one#1653
Open
antofo wants to merge 4 commits intofeature/PIN-8882_soglie_differenziatefrom
Open
PIN-9106 adjust new eservice step one#1653antofo wants to merge 4 commits intofeature/PIN-8882_soglie_differenziatefrom
antofo wants to merge 4 commits intofeature/PIN-8882_soglie_differenziatefrom
Conversation
Collaborator
antofo
commented
Feb 6, 2026
antofo
commented
- Add required fields UI indicator
- Adjust step sections
antofo
requested review from
Alepazz,
Carminepo2,
borgesis95 and
ruggerocastagnola
as code owners
borgesis95
reviewed
Feb 6, 2026
Contributor
borgesis95
left a comment
borgesis95
left a comment
There was a problem hiding this comment.
Can i ask to add test for EServiceCreateStepGeneral.tsx and ProviderEserviceCreate.page.tsx?
I know that are component that was already there, but should be a good idea add tests for this component in order to make our code more resilient.
For example, for EServiceCreateStepGeneral.tsx i would like to test (this is just an idea):
- what happen if is e-service come from e-service template
- navigation to correct route if everything goes fine and other
- what happen if personalData is
undefined
etc...
borgesis95
changed the base branch from
feature/soglie-differenziate
to
feature/PIN-8882_soglie_differenziate
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.