[PN-18163] Add additionalDetails in ErrorDetails#231
Open
DacunzoMa wants to merge 6 commits intofeature/PN-15211from
Open
[PN-18163] Add additionalDetails in ErrorDetails#231DacunzoMa wants to merge 6 commits intofeature/PN-15211from
DacunzoMa wants to merge 6 commits intofeature/PN-15211from
Conversation
…nto feature/PN-18163
There was a problem hiding this comment.
Pull request overview
Adds structured additionalDetails to ErrorDetails and propagates it across sequence validation, OCR handling, and other error-producing flows to improve error diagnostics.
Changes:
- Introduces
additionalDetailsfield inErrorDetailswith a DynamoDB converter and updates error mapper signature. - Enriches several validation errors with
ErrorCauseand structuredadditionalDetailspayloads. - Updates and adds tests/ITs to reflect the new error structure and causes.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingStateTest.java | Sets statusDateTime in test event to support new additionalDetails usage. |
| src/test/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckOcrResponseIT.java | Adds integration test exercising OCR handler flow. |
| src/test/java/it/pagopa/pn/papertracker/service/handler_step/_890/SequenceValidator890Test.java | Sets statusDateTime in context event to support new additionalDetails usage. |
| src/test/java/it/pagopa/pn/papertracker/service/handler_step/_890/HandlerFactory890IT.java | Updates assertion to expect new ErrorCause. |
| src/test/java/it/pagopa/pn/papertracker/service/handler_step/TestUtils.java | Updates generic error assertions to require non-null cause. |
| src/test/java/it/pagopa/pn/papertracker/service/handler_step/AR/TestSequenceAREnum.java | Adds a new AR test sequence variant to validate error cause behavior. |
| src/test/java/it/pagopa/pn/papertracker/service/handler_step/AR/HandlerFactoryArIT.java | Adds scenario-specific mutation of test input and validates new error category/cause. |
| src/test/java/it/pagopa/pn/papertracker/exception/PaperTrackerExceptionHandlerTest.java | Updates tests for new mapper signature and new category/cause usage. |
| src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/PcRetryService.java | Supplies additionalDetails arg (null) in error creation to match mapper signature. |
| src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/NotRetryableErrorInserting.java | Supplies additionalDetails arg (null) in error creation to match mapper signature. |
| src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/GenericSequenceValidator.java | Enriches sequence validation errors with ErrorCause + additionalDetails and refactors helper signature. |
| src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/DuplicatedEventFiltering.java | Adds additionalDetails to duplicated-event warning. |
| src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingState.java | Adds ErrorCause and additionalDetails for invalid-state warnings. |
| src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckOcrResponse.java | Adds additionalDetails (OCR payload) to OCR validation errors. |
| src/main/java/it/pagopa/pn/papertracker/service/handler_step/_890/SequenceValidator890.java | Adds additionalDetails to stock-890 state validation errors. |
| src/main/java/it/pagopa/pn/papertracker/service/handler_step/AR/FinalEventBuilderAr.java | Adds timestamps into additionalDetails for GIACENZA date error. |
| src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/entity/ErrorDetails.java | Adds additionalDetails field and DynamoDB conversion annotation. |
| src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/entity/ErrorCause.java | Introduces new error causes used by enriched validations. |
| src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/entity/ErrorCategory.java | Deprecates (by comment) STATUS_CODE_ERROR in favor of new approach. |
| src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/AdditionalDetailsConverter.java | Adds DynamoDB attribute converter for additionalDetails. |
| src/main/java/it/pagopa/pn/papertracker/mapper/PaperTrackingsErrorsMapper.java | Extends mapper to accept and store additionalDetails. |
| src/main/java/it/pagopa/pn/papertracker/exception/PaperTrackerExceptionHandler.java | Changes “status code error” detection to use ErrorCause.VALUES_NOT_FOUND. |
| docs/openapi/api-internal-v1.yaml | Documents additionalDetails in API schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/AdditionalDetailsConverter.java
Show resolved
Hide resolved
src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/AdditionalDetailsConverter.java
Show resolved
Hide resolved
src/test/java/it/pagopa/pn/papertracker/service/handler_step/AR/HandlerFactoryArIT.java
Show resolved
Hide resolved
src/test/java/it/pagopa/pn/papertracker/exception/PaperTrackerExceptionHandlerTest.java
Show resolved
Hide resolved
src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingState.java
Show resolved
Hide resolved
...in/java/it/pagopa/pn/papertracker/service/handler_step/generic/DuplicatedEventFiltering.java
Show resolved
Hide resolved
src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckOcrResponse.java
Outdated
Show resolved
Hide resolved
src/test/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckOcrResponseIT.java
Show resolved
Hide resolved
...in/java/it/pagopa/pn/papertracker/service/handler_step/generic/GenericSequenceValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/entity/ErrorCategory.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.