[PN-18166] add handler to check mismatch between payload and paperTracking product by DacunzoMa · Pull Request #240 · pagopa/pn-paper-tracker

DacunzoMa · 2026-02-13T14:51:35Z

No description provided.

…ing product

Copilot

Pull request overview

This PR introduces a new handler step that validates product-type consistency between the persisted tracking (PaperTrackings) and the incoming event payload/statusCode mapping, and wires it into the main handler pipelines.

Changes:

Added CheckTrackingProduct handler step to validate product-type mismatch and raise a validation exception.
Injected/executed the new step in AbstractHandlersFactory pipelines and updated concrete factories accordingly.
Added/updated unit tests and extended ErrorCause with new entries.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingProduct.java	New validation step for product-type consistency
src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/AbstractHandlersFactory.java	Inserts the new step into standard handler chains
src/main/java/it/pagopa/pn/papertracker/service/handler_step/AR/HandlersFactoryAr.java	Updates constructor wiring for new dependency
src/main/java/it/pagopa/pn/papertracker/service/handler_step/RIR/HandlersFactoryRir.java	Updates constructor wiring for new dependency
src/main/java/it/pagopa/pn/papertracker/service/handler_step/RIS/HandlersFactoryRis.java	Updates constructor wiring for new dependency
src/main/java/it/pagopa/pn/papertracker/service/handler_step/RS/HandlersFactoryRs.java	Updates constructor wiring for new dependency
src/main/java/it/pagopa/pn/papertracker/service/handler_step/_890/HandlersFactory890.java	Updates constructor wiring; some overridden pipelines may still bypass the new step
src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/entity/ErrorCause.java	Adds new error causes used by validation flows
src/test/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingProductTest.java	New unit tests for the validation step
src/test/java/it/pagopa/pn/papertracker/service/handler_step/AR/HandlersFactoryArTest.java	Updates handler-chain tests to include the new step
src/test/java/it/pagopa/pn/papertracker/service/handler_step/RIR/HandlersFactoryRirTest.java	Updates handler-chain tests with new stubs; some assertions still don’t verify the new step
src/test/java/it/pagopa/pn/papertracker/service/handler_step/_890/HandlersFactory890Test.java	Updates factory construction to include the new dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T14:57:39Z

src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingProduct.java

+            return Mono.empty();
+        }
+
+        String errorMsg = String.format("Product type mismatch for trackingId %s: expected %s, but got %s", context.getTrackingId(), paperTrackingProduct, productType);


The error message reports productType (derived from statusCode) as the "got" value, but this step also validates payloadProduct. If the failure is due to payload mismatch (e.g., statusCode maps to ALL), the message will be misleading. Consider including both payload product and statusCode-expected product (or at least use payloadProduct as the actual value).

Suggested change

String errorMsg = String.format("Product type mismatch for trackingId %s: expected %s, but got %s", context.getTrackingId(), paperTrackingProduct, productType);

String errorMsg = String.format(

"Product type mismatch for trackingId %s: expected tracking product %s and statusCode-derived product %s, but got payload product %s",

context.getTrackingId(),

paperTrackingProduct,

productType,

payloadProduct

);

Copilot · 2026-02-13T14:57:40Z

src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/entity/ErrorCause.java

-    STOCK_890_REFINEMENT_ERROR("Errore nel perfezionamento della spedizione 890"),;
+    STOCK_890_REFINEMENT_ERROR("Errore nel perfezionamento della spedizione 890"),
+    VALUE_AFTER_REFINEMENT("Evento arrivato dopo la conclusione della spedizione o mentre si stava aspettando l’OCR (DONE o AWAITING_OCR)"),
+    VALUES_NOT_MATCHING("Errore nella validazione degli allegati della sequenza: mancano degli allegati"),


VALUES_NOT_MATCHING’s description mentions missing sequence attachments, but it’s now used for product-type mismatch in CheckTrackingProduct. This will surface an inaccurate cause description downstream; update the description (or introduce a more appropriate ErrorCause) so it matches the new validation.

Suggested change

VALUES_NOT_MATCHING("Errore nella validazione degli allegati della sequenza: mancano degli allegati"),

VALUES_NOT_MATCHING("Errore nella validazione: i valori acquisiti non corrispondono a quelli attesi (es. tipo prodotto)"),

src/main/java/it/pagopa/pn/papertracker/middleware/dao/dynamo/entity/ErrorCause.java

Copilot · 2026-02-13T14:57:40Z

...st/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingProductTest.java

+
+        StepVerifier.create(checkTrackingProduct.execute(context))
+                .expectErrorMatches(throwable -> throwable instanceof PnPaperTrackerValidationException &&
+                        throwable.getMessage().contains("Product type mismatch for trackingId null: expected AR, but got ALL"))


This assertion expects the error message to say "got ALL", but in this scenario the actual mismatch is between tracking product (AR) and payload product (RIR) while the statusCode productType is ALL. Once the production error message is fixed to report the real mismatching value(s), update this test accordingly.

Suggested change

throwable.getMessage().contains("Product type mismatch for trackingId null: expected AR, but got ALL"))

throwable.getMessage().contains("Product type mismatch for trackingId null: expected AR, but got RIR"))

...st/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingProductTest.java

src/test/java/it/pagopa/pn/papertracker/service/handler_step/RIR/HandlersFactoryRirTest.java

Copilot · 2026-02-13T14:57:41Z

src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingProduct.java

+        String paperTrackingProduct = context.getPaperTrackings().getProductType();
+        String payloadProduct = context.getPaperProgressStatusEvent().getProductType();
+        String statusCode = context.getPaperProgressStatusEvent().getStatusCode();
+        String productType = EventStatusCodeEnum.fromKey(statusCode).getProductType().getValue();


EventStatusCodeEnum.fromKey(statusCode) can return null (see fromKey implementation), so calling .getProductType() here can throw a NullPointerException for unknown/unsupported status codes. Handle the null case explicitly (e.g., return a validation error with a clear message/cause) before dereferencing.

Suggested change

String productType = EventStatusCodeEnum.fromKey(statusCode).getProductType().getValue();

EventStatusCodeEnum eventStatus = EventStatusCodeEnum.fromKey(statusCode);

if (eventStatus == null) {

String errorMsg = String.format("Unsupported statusCode %s for trackingId %s", statusCode, context.getTrackingId());

Map<String, Object> additionalDetails = Map.of("statusCode", statusCode,

"statusTimestamp", Objects.toString(context.getPaperProgressStatusEvent().getStatusDateTime(), null)

);

//TODO: aggiornare dopo il merge del branch 18163

return Mono.error(new PnPaperTrackerValidationException(

errorMsg,

PaperTrackingsErrorsMapper.buildPaperTrackingsError(

context.getPaperTrackings(),

context.getPaperProgressStatusEvent().getStatusCode(),

ErrorCategory.INCONSISTENT_STATE,

ErrorCause.VALUES_NOT_MATCHING,

errorMsg,

FlowThrow.SEQUENCE_VALIDATION,

ErrorType.ERROR,

context.getEventId()

)));

}

String productType = eventStatus.getProductType().getValue();

src/main/java/it/pagopa/pn/papertracker/service/handler_step/generic/CheckTrackingProduct.java

Copilot · 2026-02-13T14:57:42Z

src/main/java/it/pagopa/pn/papertracker/service/handler_step/_890/HandlersFactory890.java

    public HandlersFactory890(
            MetadataUpserter metadataUpserter,
+            CheckTrackingProduct checkTrackingProduct,
            DeliveryPushSender deliveryPushSender,
            FinalEventBuilder890 finalEventBuilder,


HandlersFactory890 overrides some handlers (buildStockIntermediateEventHandler, buildRecag012EventHandler) and those pipelines currently don’t include the new checkTrackingProduct step, so product mismatch validation will be bypassed for those event types. If the check is intended to be global, add checkTrackingProduct to those overridden handler step lists as well.

PN-18166 add handler to check mismatch between payload and paperTrack…

9cfe9fc

…ing product

DacunzoMa requested a review from Vallasc as a code owner February 13, 2026 14:51

DacunzoMa requested a review from Copilot February 13, 2026 14:51

Copilot started reviewing on behalf of DacunzoMa February 13, 2026 14:52 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PN-18166] add handler to check mismatch between payload and paperTracking product#240

[PN-18166] add handler to check mismatch between payload and paperTracking product#240
DacunzoMa wants to merge 1 commit intofeature/PN-15211from
feature/PN-18166

DacunzoMa commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	VALUES_NOT_MATCHING("Errore nella validazione degli allegati della sequenza: mancano degli allegati"),
	VALUES_NOT_MATCHING("Errore nella validazione: i valori acquisiti non corrispondono a quelli attesi (es. tipo prodotto)"),

	throwable.getMessage().contains("Product type mismatch for trackingId null: expected AR, but got ALL"))
	throwable.getMessage().contains("Product type mismatch for trackingId null: expected AR, but got RIR"))

-        String productType = EventStatusCodeEnum.fromKey(statusCode).getProductType().getValue();
+        EventStatusCodeEnum eventStatus = EventStatusCodeEnum.fromKey(statusCode);
+        if (eventStatus == null) {
+            String errorMsg = String.format("Unsupported statusCode %s for trackingId %s", statusCode, context.getTrackingId());
+            Map<String, Object> additionalDetails = Map.of("statusCode", statusCode,
+                    "statusTimestamp", Objects.toString(context.getPaperProgressStatusEvent().getStatusDateTime(), null)
+            );
+            //TODO: aggiornare dopo il merge del branch 18163
+            return Mono.error(new PnPaperTrackerValidationException(
+                    errorMsg,
+                    PaperTrackingsErrorsMapper.buildPaperTrackingsError(
+                            context.getPaperTrackings(),
+                            context.getPaperProgressStatusEvent().getStatusCode(),
+                            ErrorCategory.INCONSISTENT_STATE,
+                            ErrorCause.VALUES_NOT_MATCHING,
+                            errorMsg,
+                            FlowThrow.SEQUENCE_VALIDATION,
+                            ErrorType.ERROR,
+                            context.getEventId()
+                    )));
+        }
+        String productType = eventStatus.getProductType().getValue();

Conversation

DacunzoMa commented Feb 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant